Bug 267608 - net-im/dino: do not stop fetch for sqlite3 dependency
Summary: net-im/dino: do not stop fetch for sqlite3 dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-06 23:28 UTC by Bryan Baldwin
Modified: 2022-11-12 08:58 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ashish)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Baldwin 2022-11-06 23:28:20 UTC 
Is it really necessary to block user's fetching distfiles for a check if sqlite3 is installed with UNICODE61 enabled?

Can this be pushed to a later stage when it matters?
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-11-12 03:07:25 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=44471d06e0eadb0f9e929281938ed8db434d45be

commit 44471d06e0eadb0f9e929281938ed8db434d45be
Author:     Ashish SHUKLA <ashish@FreeBSD.org>
AuthorDate: 2022-11-12 02:57:53 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2022-11-12 02:58:53 +0000

    net-im/dino: Update to 0.3.1

    - Add option for notifications sound
    - Remove the upstreamed patch
    - Move SQLite3 dependency check to pre-configure[0]

    PR:             267608 [0]
    Reported by:    Bryan Baldwin <bryan at katofiad dot co dot nz> [0]

 net-im/dino/Makefile                                       | 14 +++++++++-----
 net-im/dino/distinfo                                       |  6 +++---
 ...patch-libdino_src_service_call__peer__state.vala (gone) | 14 --------------
 net-im/dino/pkg-plist                                      |  1 +
 4 files changed, 13 insertions(+), 22 deletions(-)
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2022-11-12 08:58:43 UTC 
This should not block fetching of distfiles anymore.

Thanks for letting me know.