Bug 267721 - editors/gedit-plugins pkg-plist issue, Missing: share/glib-2.0/schemas/org.gnome.gedit.plugins.translate.gschema.xml
Summary: editors/gedit-plugins pkg-plist issue, Missing: share/glib-2.0/schemas/org.gn...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-12 00:05 UTC by alt2600
Modified: 2022-11-12 17:24 UTC (History)
2 users (show)

See Also:
nc: maintainer-feedback+


Attachments
[patch] fix for missing 'translate' schema (540 bytes, patch)
2022-11-12 05:07 UTC, John Hein
jcfyecrayz: maintainer-approval? (nc)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description alt2600 2022-11-12 00:05:12 UTC
I think this can just be patched out of the pkg-plist, but didn't want to just provided that as not sure it is the intent to not enable the translate plugin, or if my dirty build system is just doing dirty things. configure isn't listing the translate plugin as being enabled, and the translate plugin itself is no longer in the pkg-plist, but the xml schema for it is still listed in the pkg-plist. the previous plugin version definitely has a translate plugin based on running a pkg info -l against it.

computer@/usr/ports/editors/gedit-plugins|$ sudo make check-orphans
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: share/glib-2.0/schemas/org.gnome.gedit.plugins.translate.gschema.xml
===> Error: Plist issues found.
*** Error code 1


but translate isn't even a plugin that seems to be enabled

make configure snippet

Configuring gpdefs.py using configuration
Configuring bookmarks.plugin.desktop.in using configuration
Configuring bracketcompletion.plugin.desktop.in using configuration
Configuring charmap.plugin.desktop.in using configuration
Configuring codecomment.plugin.desktop.in using configuration
Configuring colorpicker.plugin.desktop.in using configuration
Configuring colorschemer.plugin.desktop.in using configuration
Configuring drawspaces.plugin.desktop.in using configuration
Configuring git.plugin.desktop.in using configuration
Configuring joinlines.plugin.desktop.in using configuration
Configuring multiedit.plugin.desktop.in using configuration
Configuring sessionsaver.plugin.desktop.in using configuration
Configuring smartspaces.plugin.desktop.in using configuration
Configuring synctex.plugin.desktop.in using configuration
Configuring terminal.plugin.desktop.in using configuration
Configuring textsize.plugin.desktop.in using configuration
Found pkg-config: /usr/local/bin/pkgconf (1.8.0)
Program glib-compile-resources found: YES (/usr/local/bin/glib-compile-resources)
Configuring wordcompletion.plugin.desktop.in using configuration
Program itstool found: YES (/usr/local/bin/itstool)
Program msgmerge found: YES (/usr/local/bin/msgmerge)
Program msgfmt found: YES (/usr/local/bin/msgfmt)
Message: Configuration:

        gedit-plugins version 43.1

        Prefix: /usr/local

        Enabled plugins:
                bookmarks
                bracketcompletion
                charmap
                codecomment
                colorpicker
                colorschemer
                drawspaces
                git
                joinlines
                multiedit
                sessionsaver
                smartspaces
                synctex
                terminal
                textsize
                wordcompletion

        Disabled plugins:

Build targets in project: 224
Comment 1 John Hein 2022-11-12 04:02:12 UTC
I can reproduce in poudriere (stable/12 amd64):

/usr/ports/editors/gedit-plugins # make install
===>  Installing for gedit-plugins-43.1
===>  Checking if gedit-plugins is already installed
===>   Registering installation for gedit-plugins-43.1
pkg-static: Unable to access file /wrkdirs/usr/ports/editors/gedit-plugins/work/stage/usr/local/share/glib-2.0/schemas/org.gnome.gedit.plugins.translate.gschema.xml:No such file or directory
*** Error code 1


Committer CC'd
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-11-12 04:45:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=86d9bd96acf7ade65ae0c5042fe4b0607cc4537d

commit 86d9bd96acf7ade65ae0c5042fe4b0607cc4537d
Author:     Neel Chauhan <nc@FreeBSD.org>
AuthorDate: 2022-11-12 04:44:01 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-11-12 04:44:01 +0000

    editors/gedit-plugins: Remove old gschema file

    PR:             267721
    Reported by:    alt2600

 editors/gedit-plugins/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Comment 3 Neel Chauhan freebsd_committer freebsd_triage 2022-11-12 04:46:37 UTC
Sorry for this, can you test the latest branch?

I won't close until it's resolved for you all.
Comment 4 John Hein 2022-11-12 05:07:51 UTC
Created attachment 238027 [details]
[patch] fix for missing 'translate' schema

It looks like 43.1 has removed the translate schema, and this was missed in the commit.

QA:
  - portlint (ok - no new warnings)

  - portclippy (ok - no new ordering problems reported)
    - maybe the existing ordering discrepancies should be fixed while here, but this patch does not do so.

  - poudriere (ok - testport now succeeds)
Comment 5 Neel Chauhan freebsd_committer freebsd_triage 2022-11-12 17:24:53 UTC
I've done the same thing in 86d9bd96acf7ade65ae0c5042fe4b0607cc4537d.

Fetch the latest ports tree and try again.