Bug 267808 - security/crowdsec: update to 1.4.3
Summary: security/crowdsec: update to 1.4.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Nuno Teixeira
URL: https://github.com/crowdsecurity/crow...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-16 10:58 UTC by marco
Modified: 2022-12-22 08:08 UTC (History)
3 users (show)

See Also:
marco: maintainer-feedback+
eduardo: merge-quarterly-

Attachments
patch for crowdsec 1.4.2 and blocklist mirror 0.0.1 (16.59 KB, patch)
2022-11-16 10:58 UTC, marco 		marco: maintainer-approval+
Details | Diff
patch for crowdsec 1.4.3 and blocklist mirror 0.0.1 (16.73 KB, patch)
2022-11-30 21:45 UTC, marco 		marco: maintainer-approval+
Details | Diff
patch for crowdsec 1.4.3 (8.26 KB, patch)
2022-12-01 21:50 UTC, marco 		marco: maintainer-approval+
Details | Diff
patch for crowdsec 1.4.3 with proposed changes (8.60 KB, patch)
2022-12-21 13:59 UTC, marco 		marco: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description marco 2022-11-16 10:58:26 UTC 
Created attachment 238116 [details]
patch for crowdsec 1.4.2 and blocklist mirror 0.0.1

Includes performance improvements and features from v1.4.2, and a cron job to keep the installed hub plugins up to date.

The new Blocklist Mirror package is a way to integrate appliances or firewall software by providing a list of IPs at an http endpoint.
Comment 1 William Desportes 2022-11-21 20:29:57 UTC 
Waiting on this one to update my blog post: https://blog.williamdes.eu/Infrastructure/tutorials/install-crowdsec-and-bouncer-on-pfsense/
Comment 2 marco 2022-11-22 09:21:34 UTC 
I just noticed that the crowdsec package now requires go 1.19 to build. What's the right way to declare the dependency? I'm not using go:modules
Comment 3 marco 2022-11-30 21:45:18 UTC 
Created attachment 238461 [details]
patch for crowdsec 1.4.3 and blocklist mirror 0.0.1

Upstream update; both packages now depend on go 1.19
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-01 18:55:53 UTC 
Hello,

Could you please create a PR for new port?
You can use "Depends on" if needed betwwen new port and update port.

Thanks
Comment 5 marco 2022-12-01 21:50:23 UTC 
Created attachment 238479 [details]
patch for crowdsec 1.4.3
Comment 6 marco 2022-12-01 21:58:46 UTC 
(In reply to Nuno Teixeira from comment #4)

Of course! Separate issue in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268105

Thanks
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-01 22:04:46 UTC 
(In reply to marco from comment #6)

It misses diff of new port and PR tittle should be:
[NEW PORT] <category>/<port name>: Short descrition (Makefile COMMENT field is ok)

Thanks
Comment 8 marco 2022-12-20 14:33:36 UTC 
Hi,

since the other patch has been merged, I don't see any other blocking issues on this one.
Comment 9 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-21 08:21:12 UTC 
Small fixes to be done:

- portlint: unmute ${INSTALL_DATA} command at line 55
- plist: etc/cron.d/crowdsec -> %%ETCDIR%%/cron.d/crowdsec
- Q/A tests: re-check REINPLACE cmds, config/profiles.yaml not being modified
- portclippy: Out of order targets: 1 post-patch, 2 do-install, 3 post-install
Comment 10 marco 2022-12-21 13:58:12 UTC 
(In reply to Nuno Teixeira from comment #9)

Thanks for the review!

I'm not so sure about this though:

- plist: etc/cron.d/crowdsec -> %%ETCDIR%%/cron.d/crowdsec


because I need to have it in /usr/local/etc/, not /usr/local/etc/crowdsec/

I applied the other changes and put a new patch.
Comment 11 marco 2022-12-21 13:59:00 UTC 
Created attachment 238958 [details]
patch for crowdsec 1.4.3 with proposed changes
Comment 12 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-21 20:28:33 UTC 
(In reply to marco from comment #10)

You are right.
Comment 13 commit-hook freebsd_committer freebsd_triage 2022-12-22 08:04:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=50118f50cae2c4f607603c661fc1eb24431cb9c6

commit 50118f50cae2c4f607603c661fc1eb24431cb9c6
Author:     Marco <marco@crowdsec.net>
AuthorDate: 2022-12-22 08:01:22 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-12-22 08:03:50 +0000

    security/crowdsec: Update to 1.4.3

    ChangeLog:      https://github.com/crowdsecurity/crowdsec/releases/tag/v1.4.2
    PR:             267808

 security/crowdsec/Makefile                     | 38 +++++++++++++++++---------
 security/crowdsec/distinfo                     |  6 ++--
 security/crowdsec/files/crowdsec.cron.in (new) |  2 ++
 security/crowdsec/files/patch-Makefile (gone)  | 12 --------
 security/crowdsec/files/pkg-deinstall.in       |  4 +--
 security/crowdsec/files/pkg-message.in         |  2 +-
 security/crowdsec/files/upgrade-hub.in (new)   | 17 ++++++++++++
 security/crowdsec/pkg-plist                    | 12 ++++----
 8 files changed, 57 insertions(+), 36 deletions(-)
Comment 14 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-22 08:08:33 UTC 
Not sure about MFH this update since 2022Q4 is almost ending and besides bug fixes, it has new features too.

I will decline it but if you feel that it really must be MFH please put "?" again on merge flag.

Committed, thanks!