Bug 267868 - audio/ardour: Update to 7.2.0 release, replace audio/ardour6.
Summary: audio/ardour: Update to 7.2.0 release, replace audio/ardour6.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://ardour.org/whatsnew.html
Keywords:
Depends on:
Blocks: 267065
  Show dependency treegraph
 
Reported: 2022-11-19 21:09 UTC by Florian Walpen
Modified: 2022-12-26 07:17 UTC (History)
1 user (show)

See Also:


Attachments
Update to 7.1.0 release, replace audio/ardour6. (29.39 KB, patch)
2022-11-19 21:09 UTC, Florian Walpen
no flags Details | Diff
Update to 7.2.0 release, replace audio/ardour6. (29.79 KB, patch)
2022-12-17 14:21 UTC, Florian Walpen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Walpen 2022-11-19 21:09:03 UTC
Created attachment 238183 [details]
Update to 7.1.0 release, replace audio/ardour6.

This patch provides an update to Ardour 7.1.0, thereby replacing Ardour 6.9.0 in audio/ardour6 and moving the port to audio/ardour. There's no reason to keep the major version in the portname, we only had one version for quite some time.

The patch also incorporates bug #267065, relaxing the version requirement on the python build dependency.

I did some brief testing on 13.0-RELEASE and found no regressions so far.
Apply with "git am".

Some notes about the changes I made:

Issue 1 - Official download is now tailored to browsers only, that's why the distfile is named "510". Put it in a named and versioned subdirectory to not mess up the distfiles directory. I didn't find a better download alternative. Github is not an option, because the download there is deliberately made empty (sic).

Issue 2 - Even though I followed the advice in the porters handbook to the best of my knowledge, portlint warns about the use of DISTFILES and DISTNAME. The problem is the odd distfile name (Issue 1) combined with non-matching extraction path and portname. If I follow the suggestions of portlint, I have to define WRKSRC above the license block which portlint doesn't like either.

Issue 3 - Ardour includes its major version (e.g. "ardour7") in many pkg-plist paths. I factored these out into a substitution variable named ARDOUR_MAJOR, to ease future updates to the port. Some of these substitutions came through the portname previously.
Comment 1 Florian Walpen 2022-12-17 14:21:07 UTC
Created attachment 238868 [details]
Update to 7.2.0 release, replace audio/ardour6.

Update the patch to 7.2.0 release of Ardour, briefly tested on 13.1-RELEASE.
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-24 10:24:04 UTC
Hello,

Nice work on this port.

Currently it doesn't have a maintainer, are you willing to maintain it?
Comment 3 Florian Walpen 2022-12-25 12:10:47 UTC
(In reply to Nuno Teixeira from comment #2)

Hi Nuno Teixeira,

I'm only a casual user of this software, but that's probably better than no maintainer at all. Feel free to put me in as the maintainer (same e-mail as in the patch), or I can update the patch tomorrow when I'm back at my workstation.
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-25 12:17:42 UTC
(In reply to Florian Walpen from comment #3)

- Submitter becomes maintainer

Thanks
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-12-26 07:15:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e5453d2a9f4944a40f4e10df52b3f360746f7414

commit e5453d2a9f4944a40f4e10df52b3f360746f7414
Author:     Florian Walpen <dev@submerge.ch>
AuthorDate: 2022-12-26 07:07:01 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-12-26 07:14:35 +0000

    audio/ardour: Update to 7.2.0 release, replace audio/ardour6

     - Submitter becomes maintainer

    This patch provides an update to Ardour 7.1.0, thereby replacing Ardour
    6.9.0 in audio/ardour6 and moving the port to audio/ardour. There's no
    reason to keep the major version in the portname, we only had one version
    for quite some time.

    The patch also incorporates bug #267065, relaxing the version requirement
    on the python build dependency.

    Some notes about the changes I made:

    Issue 1 - Official download is now tailored to browsers only, that's why
    the distfile is named "510". Put it in a named and versioned subdirectory
    to not mess up the distfiles directory. I didn't find a better download
    alternative. Github is not an option, because the download there is
    deliberately made empty (sic).

    Issue 2 - Even though I followed the advice in the porters handbook to
    the best of my knowledge, portlint warns about the use of DISTFILES and
    DISTNAME. The problem is the odd distfile name (Issue 1) combined with
    non-matching extraction path and portname. If I follow the suggestions of
    portlint, I have to define WRKSRC above the license block which portlint
    doesn't like either.

    Issue 3 - Ardour includes its major version (e.g. "ardour7") in many
    pkg-plist paths. I factored these out into a substitution variable named
    ARDOUR_MAJOR, to ease future updates to the port. Some of these
    substitutions came through the portname previously.

    ChangeLog:      https://ardour.org/whatsnew.html
    PR:             267065, 267868

 MOVED                                              |   2 +-
 audio/Makefile                                     |   2 +-
 audio/ardour/Makefile (new)                        | 102 ++++++++
 audio/ardour/distinfo (new)                        |   3 +
 audio/{ardour6 => ardour}/pkg-descr                |   0
 audio/{ardour6 => ardour}/pkg-plist                | 260 +++++++++++----------
 audio/ardour6/Makefile (gone)                      | 116 ---------
 audio/ardour6/distinfo (gone)                      |   3 -
 .../patch-libs_ardour_plugin__manager.cc (gone)    |  18 --
 9 files changed, 246 insertions(+), 260 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-26 07:17:46 UTC
Consider reformat Makefile with portfmt.

Committed, thanks to maintain this port!