Bug 267927 - textproc/py-sphinxcontrib-towncrier: Update to 0.3.1a3
Summary: textproc/py-sphinxcontrib-towncrier: Update to 0.3.1a3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Nicola Vitale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-22 17:36 UTC by Nicola Vitale
Modified: 2022-12-30 10:05 UTC (History)
3 users (show)

See Also:
sunpoet: maintainer-feedback+


Attachments
patch to update textproc/py-sphinxcontrib-towncriere to 0.3.1a3 (1.07 KB, patch)
2022-11-22 17:36 UTC, Nicola Vitale
no flags Details | Diff
This patch adds devel/py-importlib-metadata to run dependecies (1.35 KB, patch)
2022-11-24 14:45 UTC, Nicola Vitale
nivit: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nicola Vitale freebsd_committer freebsd_triage 2022-11-22 17:36:57 UTC
Created attachment 238254 [details]
patch to update textproc/py-sphinxcontrib-towncriere to 0.3.1a3
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-11-22 22:43:45 UTC
Current version in tree seems to break sphinx

...
Running Sphinx v4.5.0
pip version: 22.2
pip release: 22.2.2

Extension error:
Could not import extension sphinxcontrib.towncrier (exception: cannot import name 'load_config_from_file' from 'towncrier._settings' (/usr/local/lib/python3.9/site-packages/towncrier/_settings/__init__.py))
*** Error code 1

How to reproduce:
build devel/py-pip with docs
Comment 2 Wen Heping freebsd_committer freebsd_triage 2022-11-23 02:37:48 UTC
ping ...

It is a critical patch !
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-11-23 21:06:48 UTC
(In reply to Nicola Vitale from comment #0)

The patch is incomplete. Please commit with conditional RUN_DEPENDS on py-importlib-metadata. See [1].

[1] https://github.com/sphinx-contrib/sphinxcontrib-towncrier/blob/v0.3.1a3/setup.cfg#L56

(In reply to Daniel Engberg from comment #1)

It was OK before py-towncrier 20.8.0 update. See [2].

[2] https://github.com/sphinx-contrib/sphinxcontrib-towncrier/commit/4fac58fc2e49adf1a64a03d2ac8fd5410359b085
Comment 4 Nicola Vitale freebsd_committer freebsd_triage 2022-11-24 14:45:05 UTC
Created attachment 238300 [details]
This patch adds devel/py-importlib-metadata to run dependecies

I have added devel/py-importlib-metadata to RUN_DEPENDS when Python ver. < 3.8.

Note, however, that devel/phinx adds it as its run-dependency for all versions of Python < 3.1:

https://cgit.freebsd.org/ports/tree/textproc/py-sphinx/Makefile#n51

https://github.com/sphinx-doc/sphinx/blob/master/pyproject.toml#L73

So maybe that's a surplus...
Comment 5 Nicola Vitale freebsd_committer freebsd_triage 2022-11-24 14:48:50 UTC
(In reply to Nicola Vitale from comment #4)
"phinx adds it as its run-dependency for all versions of Python < *3.10*" obviously...
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-11-25 17:02:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4f955d3a346f58cfba00293b582c289ece58566c

commit 4f955d3a346f58cfba00293b582c289ece58566c
Author:     Nicola Vitale <nivit@FreeBSD.org>
AuthorDate: 2022-11-25 16:56:27 +0000
Commit:     Nicola Vitale <nivit@FreeBSD.org>
CommitDate: 2022-11-25 16:56:27 +0000

    textproc/py-sphinxcontrib-towncrier: Update to 0.3.1a3

    PR:     267927
    Reported by:    nivit
    Approved by:    sunpoet (maintainer)

 textproc/py-sphinxcontrib-towncrier/Makefile | 10 ++++++++--
 textproc/py-sphinxcontrib-towncrier/distinfo |  6 +++---
 2 files changed, 11 insertions(+), 5 deletions(-)
Comment 7 Nicola Vitale freebsd_committer freebsd_triage 2022-11-25 17:07:24 UTC
(In reply to Po-Chuan Hsieh from comment #3)

Committed, thank you for the feedback!