Bug 267943 - net-mgmt/zabbix6-server: LogFile config parameter not patched for /var/log/zabbix
Summary: net-mgmt/zabbix6-server: LogFile config parameter not patched for /var/log/za...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Juraj Lutter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-23 09:06 UTC by Michael Osipov
Modified: 2022-11-29 12:32 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (otis)

Attachments
Git-formatted patch (1.48 KB, patch)
2022-11-23 09:08 UTC, Michael Osipov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov 2022-11-23 09:06:23 UTC 
Moving from Zabbix 5 to 6 it seems that LogFile has not been patched in the Makefile 'post-patch' target also /var/log/zabbix/ is always assumed. I'd expect that logfiles land there by default.
Comment 1 Michael Osipov 2022-11-23 09:08:44 UTC 
Created attachment 238275 [details]
Git-formatted patch

Here is a patch. Just copied from 5. Works in poudriere:
nobody@123-release-amd64-default-head:/usr/local/etc/zabbix6 % grep -r LogFile=/ .
./zabbix_agentd.conf:LogFile=/var/log/zabbix/zabbix_agentd.log
./zabbix_agentd.conf.sample:LogFile=/var/log/zabbix/zabbix_agentd.log
./zabbix_proxy.conf:LogFile=/var/log/zabbix/zabbix_proxy.log
./zabbix_server.conf:LogFile=/var/log/zabbix/zabbix_server.log
./zabbix_proxy.conf.sample:LogFile=/var/log/zabbix/zabbix_proxy.log
./zabbix_server.conf.sample:LogFile=/var/log/zabbix/zabbix_server.log
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-11-28 21:13:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=80a2fce1d2b6071173203e7ee1c8eb09edb46663

commit 80a2fce1d2b6071173203e7ee1c8eb09edb46663
Author:     Juraj Lutter <otis@FreeBSD.org>
AuthorDate: 2022-11-28 21:00:44 +0000
Commit:     Juraj Lutter <otis@FreeBSD.org>
CommitDate: 2022-11-28 21:12:41 +0000

    net-mgmt/zabbix6-server: Update to 6.0.11

    - Update to 6.0.11
    - Fix build of agent with pcre2
    - Small makefile cleanups
    - Fix LogFile path in configs
    - Fix pkg-message dates

    PR:     268032
    PR:     267925
    PR:     267943

 net-mgmt/zabbix6-proxy/Makefile              |  2 -
 net-mgmt/zabbix6-server/Makefile             | 74 ++++++++++++++++------------
 net-mgmt/zabbix6-server/distinfo             |  6 +--
 net-mgmt/zabbix6-server/files/pkg-message.in | 23 +++++----
 net-mgmt/zabbix6-server/pkg-plist.frontend   |  1 -
 5 files changed, 57 insertions(+), 49 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-11-29 12:30:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=76f20363dcfcedacbb80224d4b752d27fa887f5b

commit 76f20363dcfcedacbb80224d4b752d27fa887f5b
Author:     Juraj Lutter <otis@FreeBSD.org>
AuthorDate: 2022-11-29 09:58:25 +0000
Commit:     Juraj Lutter <otis@FreeBSD.org>
CommitDate: 2022-11-29 12:29:27 +0000

    net-mgmt/zabbix62-server: Update to 6.2.5

    - Update to 6.2.5
    - Fix build of agent with pcre2
    - Small makefile cleanups
    - Fix LogFile path in configs

    PR:     268032
    PR:     267943

 net-mgmt/zabbix62-proxy/Makefile            |  2 -
 net-mgmt/zabbix62-server/Makefile           | 79 +++++++++++++++++------------
 net-mgmt/zabbix62-server/distinfo           |  6 +--
 net-mgmt/zabbix62-server/pkg-plist.frontend |  1 -
 4 files changed, 49 insertions(+), 39 deletions(-)
Comment 4 Juraj Lutter freebsd_committer freebsd_triage 2022-11-29 12:32:03 UTC 
Committed (based on your patch), thanks.