Bug 268023 - math/suitesparse update deleted ability to select BLAS libraries, was this intended?
Summary: math/suitesparse update deleted ability to select BLAS libraries, was this in...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-fortran (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-27 22:47 UTC by alt2600
Modified: 2022-12-15 22:49 UTC (History)
2 users (show)

See Also:
thierry: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description alt2600 2022-11-27 22:47:59 UTC
commit hard codes
USES+=		blaslapack:openblas

but the options only seemed cleanup not deleted from bsd.suitesparse.mk . selecting ATLAS no longer works. Is the port still supposed to support multiple BLAS libraries?
Comment 1 Dima Pasechnik 2022-11-27 23:05:49 UTC
ATLAS (upstream) appears to have been abandoned about 3 years ago, stable releases have not been done for 7+ years.

Nobody uses it any more, I suppose. OpenBLAS appears to be the only viable open-source option.
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2022-11-28 18:42:41 UTC
(In reply to Dima Pasechnik from comment #1)
Yes, you are right. Upstream recommends Intel MKL, but this is closed source and not available for FreeBSD.

Anyway, this option exists if someone wants to check, and it was a mistake to force OpenBLAS, which is already the option set by default.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-11-28 18:43:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=977730c0c177a5636383a925a0b471283078b365

commit 977730c0c177a5636383a925a0b471283078b365
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2022-11-28 18:38:21 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2022-11-28 18:42:30 +0000

    math/suitesparse: do not force OpenBLAS

    The different implementations of BLAS may be choosen by an option radio
    and it was a mistake to force it (a remainder of some test…).

    Do not bump PORTREVISION since this is the default.

    PR:             268023
    Reported by:    alt2600 (at) icloud.com

 math/suitesparse/bsd.suitesparse.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 alt2600 2022-11-29 00:30:10 UTC
(In reply to Thierry Thomas from comment #2)

upgrade using ATLAS worked fine. Thank you.

wondering, after your work fixing lapack for atlas, there was something in the bugzilla/or somewhere anyway that you might be looking at updating atlas at the time. Have you started? I was thinking of giving it a go if not. I know it is mainly comparing our patches against what went upstream and its a lot of patches to compare. Would also likely look to use the DEV branch as upstream says it has better optimizations than the release for modern archs, ie anything we are using these days for computers. Wouldn't be able to test sparc, or the other archs, maybe powerpc? not sure, but certainly could test against amd64 and dependent software in our ports tree. let me know.
Comment 5 Thierry Thomas freebsd_committer freebsd_triage 2022-11-29 20:53:35 UTC
As Dima said, ATLAS (upstream) appears to have been abandoned:
- the latest stable release is dated 2016-07-28;
- the latest unstable tarball is dated 2018-10-05.
Thus I guess that new CPUs or architectures are not well supported…

Another problem is that to be optimized, it must be built directly on the target machine: that means no package and no cross-compilation.

For these reasons, the FreeBSD port math/atlas-devel has been removed in 2014 , and the port math/atlas is outdated (3.8.4 but upstream has 3.10.3!).

I could try to update it and/or resurrect math/atlas-devel, but do not hesitate to beat me!
Comment 6 Thierry Thomas freebsd_committer freebsd_triage 2022-12-15 17:28:14 UTC
First step done: math/atlas has just been upgraded to the latest stable release.
Comment 7 alt2600 2022-12-15 22:49:34 UTC
(In reply to Thierry Thomas from comment #6)

much appreciated!!!