Bug 268060 - print/fontforge: Update to 20220308
Summary: print/fontforge: Update to 20220308
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/fontforge/fontforg...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-29 16:43 UTC by Naram Qashat
Modified: 2022-12-01 01:33 UTC (History)
2 users (show)

See Also:


Attachments
fontforge-20220308.patch (7.29 KB, patch)
2022-11-29 16:43 UTC, Naram Qashat
cyberbotx: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2022-11-29 16:43:44 UTC
Created attachment 238425 [details]
fontforge-20220308.patch

* Update to 20220308
* Update Makefile (add LIB_DEPENDS to print/harfbuzz for GTK3 and X11 options)
* Update distinfo
* Update pkg-plist

Side-note, I am not sure why, but poudriere testport, when getting to the check-plist stage, was only able to tell me about files that were never installed at all, but was not able to tell me about files that were being installed with different port options. Most of the %%<option>%% removals did not trigger any change in check-plist (it still said everything was fine). I verified that these files were being installed by looking at Fontforge's CMakeLists.txt files in their GitHub repo.

Changelog: https://github.com/fontforge/fontforge/releases/tag/20220308

Tested via poudriere for 13.1-amd64, 13.1-i386, 12.3-amd64 and 12.3-i386. Passes portlint.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-30 17:54:12 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.


Thanks!

(In reply to Naram Qashat from comment #0)

Did you actually build with those options in poudriere?
Comment 2 Naram Qashat 2022-11-30 20:36:20 UTC
(In reply to Fernando Apesteguía from comment #1)

When I was testing for 13.1-amd64, I made a separate set so I could test all the options one at a time. For instance, I would turn the 2012 option on and the TANGO option off. Before changing the pkg-plist, poudriere testport, when it got to check-plist, did not complain about the missing files from pixmaps. When I removed the %%TANGO%% parts from those files which the 2012 theme also install and then ran poudriere testport again, check-plist again did not complain.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-11-30 22:25:17 UTC
(In reply to Naram Qashat from comment #2)

`poudriere -c`? (-c Run make config for the given port.)
Comment 4 Naram Qashat 2022-11-30 22:32:00 UTC
(In reply to Nuno Teixeira from comment #3)

No, I was using make.conf files within /usr/local/etc/poudriere.d for this. I made sure that the options were being respected when I checked the poudriere logs.
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-01 00:14:04 UTC
(In reply to Naram Qashat from comment #4)

Nice work on pkg-plist.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-12-01 01:32:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=257086f41e1619782323985f4856c8caeb008a7a

commit 257086f41e1619782323985f4856c8caeb008a7a
Author:     Naram Qashat <cyberbotx@cyberbotx.com>
AuthorDate: 2022-12-01 01:29:45 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-12-01 01:31:20 +0000

    print/fontforge: Update to 20220308

    ChangeLog:      https://github.com/fontforge/fontforge/releases/tag/20220308
    PR:             268060

 print/fontforge/Makefile  |  7 +++--
 print/fontforge/distinfo  |  6 ++--
 print/fontforge/pkg-plist | 72 +++++++++++++++++++++++++++--------------------
 3 files changed, 48 insertions(+), 37 deletions(-)
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-01 01:33:09 UTC
Committed, thanks!