Bug 268119 - sysutils/hammer2: Update to 1.0.4
Summary: sysutils/hammer2: Update to 1.0.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL: https://www.freshports.org/sysutils/h...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-02 07:20 UTC by kusumi.tomohiro
Modified: 2022-12-26 00:44 UTC (History)
5 users (show)

See Also:
grahamperrin: merge-quarterly?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kusumi.tomohiro 2022-12-02 07:20:04 UTC 
Fix build error due to readdir cookie type mismatch on i386.

* Build log: https://pkg-status.freebsd.org/beefy15/data/131i386-default/0772795015a6/logs/errors/hammer2-1.0.1.log
* GitHub branch: https://github.com/kusumi/freebsd-ports/commits/hammer2_3

This update effectively disables HAMMER2's NFS support on FreeBSD 13.X, as there is no real solution to support HAMMER2's 64 bits cookie when VFS doesn't support 64 bits cookie.

The cookie size has been expanded to 64 bits in FreeBSD src commit b214fcceacad6b842545150664bd2695c1c2b34f which first appears in 14-CURRENT.
https://github.com/freebsd/freebsd-src/commit/b214fcceacad6b842545150664bd2695c1c2b34f
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2022-12-02 07:20:04 UTC 
Maintainer informed via mail
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-03 17:51:29 UTC 
Could you provide a patch?

Thanks
Comment 3 kusumi.tomohiro 2022-12-03 18:35:16 UTC 
I pasted my GitHub branch URL as I assumed one would just merge from Git branch, but here it is.

https://github.com/kusumi/freebsd-ports/commit/e8bc3ded9efc215bf584d7be6ce8d343eb9a15e2.patch
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-12-04 13:00:00 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=aae93d3bc98f4dcab1858add34e0440e277a5944

commit aae93d3bc98f4dcab1858add34e0440e277a5944
Author:     Tomohiro Kusumi <tkusumi@netbsd.org>
AuthorDate: 2022-12-02 07:03:20 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-12-04 12:55:11 +0000

    sysutils/hammer2: Update to 1.0.4

    Changelog:      https://github.com/kusumi/freebsd_hammer2/blob/master/CHANGES
    PR:             268119

 sysutils/hammer2/Makefile | 2 +-
 sysutils/hammer2/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 5 Graham Perrin freebsd_committer freebsd_triage 2022-12-04 16:26:00 UTC 
If I understand correctly: given the (limited) support for 13, should there be a merge to quarterly?

Thanks
Comment 6 kusumi.tomohiro 2022-12-04 20:03:26 UTC 
(In reply to Graham Perrin from comment #5)

The only limitation vs x86_64 (or any other arch where unsigned long is 64 bits) is NFS, and I doubt anyone really needs NFS over read-only HAMMER2.

So I believe it should be handled / merged the same on 13.X.
Comment 7 Koichiro Iwao freebsd_committer freebsd_triage 2022-12-26 00:44:43 UTC 
This port has been newly added quarter 4 in 2022. So not added 2022Q4 branch. We don't need to merge into quarterly branch.