Bug 268172 - mail/roundcube-carddav: please update to 4.4.4 to support php81
Summary: mail/roundcube-carddav: please update to 4.4.4 to support php81
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Pietro Cerutti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-05 13:50 UTC by Fabian Wenk
Modified: 2022-12-05 17:15 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (gahr)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Wenk 2022-12-05 13:50:42 UTC
After upgrading from lang/php80 to lang/php81, the rebuild of mail/roundcube-carddav failed with this error:

Port marked as IGNORE: mail/roundcube-carddav:
does not work with PHP versions 81 82 and 81 is installed.

According to https://github.com/mstilkerich/rcmcarddav/releases there is version 4.4.4 available since 2022-08-22, and it looks like this should work with php81.
Comment 1 Pietro Cerutti freebsd_committer freebsd_triage 2022-12-05 15:38:01 UTC
Thanks Fabian. I don't have a php81 environment yet, so I can't test this. But I am willing to update the port to 4.4.4 and remove the restriction on php81 if you can confirm that it does indeed work fine.
Comment 2 Fabian Wenk 2022-12-05 16:22:24 UTC
(In reply to Pietro Cerutti from comment #1)

I have first deleted the installed pkg and then manually installed it into /usr/local/www/roundcube/plugins/carddav/. I have also applied the patch /usr/ports/mail/roundcube-carddav/files/patch-carddav.php and did 'apachectl graceful'. 
I created a contact, edited the contact and used it to send mail and then deleted it again. All worked so far.
Comment 3 Pietro Cerutti freebsd_committer freebsd_triage 2022-12-05 17:13:58 UTC
Thanks a lot!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-12-05 17:15:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a1f596a64c2631ca50a091bd987524dd143db7f4

commit a1f596a64c2631ca50a091bd987524dd143db7f4
Author:     Pietro Cerutti <gahr@FreeBSD.org>
AuthorDate: 2022-12-05 17:12:06 +0000
Commit:     Pietro Cerutti <gahr@FreeBSD.org>
CommitDate: 2022-12-05 17:13:52 +0000

    mail/roundcube-carddav: update to 4.4.4, unignore with php 8.1

    PR:             268172
    Reported by:    Fabian Wenk <fabian@wenks.ch>
    Tested by:      Fabian Wenk <fabian@wenks.ch>

 mail/roundcube-carddav/Makefile  |  4 ++--
 mail/roundcube-carddav/distinfo  |  6 +++---
 mail/roundcube-carddav/pkg-plist | 15 ++++++++-------
 3 files changed, 13 insertions(+), 12 deletions(-)