Bug 268177 - x11-themes/kde-icons-black-and-white: fixes corrupt Makefile, distinfo && pkg-message files
Summary: x11-themes/kde-icons-black-and-white: fixes corrupt Makefile, distinfo && pkg...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords: dogfood, easy
Depends on:
Blocks:
 
Reported: 2022-12-05 18:15 UTC by Chris Hutchinson
Modified: 2022-12-16 23:09 UTC (History)
3 users (show)

See Also:
portmaster: maintainer-feedback+
fernape: merge-quarterly+


Attachments
git diff for x11-themes/kde-icons-black-and-white (1.30 KB, patch)
2022-12-05 18:15 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff
git diff for x11-themes/kde-icons-black-and-white (final) (1.87 KB, patch)
2022-12-05 19:17 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2022-12-05 18:15:29 UTC
Created attachment 238548 [details]
git diff for x11-themes/kde-icons-black-and-white

While I haven't the time to plow through git history
to discover how/why this happened. Somewhere along
the line, the Makefile and or the distinfo file for this
port were altered; and as a consequence, the source became
unavailable. As such; the port was marked BROKEN. What a
mess. :-(

Anyway, the git diff attached to this pr fixes it.

Please commit ASAP.

Thank you. :-)

--chris
Comment 1 Chris Hutchinson 2022-12-05 19:17:04 UTC
Created attachment 238555 [details]
git diff for x11-themes/kde-icons-black-and-white (final)

Update to last patch, as pkg-message was
also corrupted. This patch is the final version.
Please commit so this port can be built again.

--chris
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-12-05 19:21:02 UTC
Did you test this?
Upstream comments suggests that this set isn't working as intended
https://store.kde.org/p/1120904
Comment 3 Chris Hutchinson 2022-12-05 19:31:30 UTC
(In reply to Daniel Engberg from comment #2)
The port was marked BROKEN for missing source.
The source was where I said it was when I wrote
the Makefile and distinfo. Somebody modified those
files and committed those changes. That broke
the port.
The attached diff fixes the port.
Nobody has expressed any problems with the port
except as in #257242 which involvrd the language
used in pkg-message. The git diff attached to this
pr(1) also fixes those. They were already corrected.
But whomever committed their own changes to this port
removed (reverted) them.

Please commit && thank you very much.

--chris
Comment 4 Chris Hutchinson 2022-12-05 19:35:53 UTC
x11-themes/kde-icons-black-and-white % make -DBATCH check-plist

===>  License theme theme accepted by the user
===>   kde-icons-black-and-white-2.0.a depends on file: /usr/local/sbin/pkg - found
=> black-and-white.tar.gz doesn't seem to exist in /root/DEV/PONYC/distfiles/KDE.
=> Attempting to fetch https://BSDforge.com/projects/source/x11-themes/kde-icons-black-and-white/black-and-white.tar.gz
black-and-white.tar.gz                                6546 kB  403 MBps    00s
===> Fetching all distfiles required by kde-icons-black-and-white-2.0.a for building
===>  Extracting for kde-icons-black-and-white-2.0.a
=> SHA256 Checksum OK for KDE/black-and-white.tar.gz.
===>  Patching for kde-icons-black-and-white-2.0.a
===>  Configuring for kde-icons-black-and-white-2.0.a
===>  Staging for kde-icons-black-and-white-2.0.a
===>   Generating temporary packing list
====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)
Warning: License does not allow package to be distributed, ports depending on this one will be ignored
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)

x11-themes/kde-icons-black-and-white % make -DBATCH stage-qa
====> Running Q/A tests (stage-qa)
Warning: License does not allow package to be distributed, ports depending on this one will be ignored

x11-themes/kde-icons-black-and-white % make -DBATCH check-sanity

===>  License theme theme accepted by the user
Comment 5 Chris Hutchinson 2022-12-08 03:56:29 UTC
pkg fallout indicates quarterly is also broken.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-12-16 16:24:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=743aad0dbc35150bd939db52301c929f6bb711c8

commit 743aad0dbc35150bd939db52301c929f6bb711c8
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2022-12-16 06:47:07 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-12-16 16:20:27 +0000

    x11-themes/kde-icons-black-and-white: Fix fetch

    Unbreak port and update pkg-message file.

    PR:             257242 268177
    Reported by:    portmaster@bsdforge.com (maintainer)
    MFH:            2022Q4 (quarterly is also broken)

 x11-themes/kde-icons-black-and-white/Makefile    | 6 ++----
 x11-themes/kde-icons-black-and-white/distinfo    | 5 +++--
 x11-themes/kde-icons-black-and-white/pkg-message | 4 ++--
 3 files changed, 7 insertions(+), 8 deletions(-)
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2022-12-16 16:26:40 UTC
Committed,

Note that distinfo did not have a TIMESTAMP and I had to run "make makesum".

Thanks!
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-12-16 16:27:02 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f3b5f5fc0afecb2d2627841932db39c1b2193b45

commit f3b5f5fc0afecb2d2627841932db39c1b2193b45
Author:     Chris Hutchinson <portmaster@bsdforge.com>
AuthorDate: 2022-12-16 06:47:07 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-12-16 16:22:01 +0000

    x11-themes/kde-icons-black-and-white: Fix fetch

    Unbreak port and update pkg-message file.

    PR:             257242 268177
    Reported by:    portmaster@bsdforge.com (maintainer)
    MFH:            2022Q4 (quarterly is also broken)

    (cherry picked from commit 743aad0dbc35150bd939db52301c929f6bb711c8)

 x11-themes/kde-icons-black-and-white/Makefile    | 4 ++--
 x11-themes/kde-icons-black-and-white/distinfo    | 5 +++--
 x11-themes/kde-icons-black-and-white/pkg-message | 4 ++--
 3 files changed, 7 insertions(+), 6 deletions(-)
Comment 9 Chris Hutchinson 2022-12-16 23:09:38 UTC
(In reply to Fernando Apesteguía from comment #7)
> Note that distinfo did not have a TIMESTAMP and I had to run "make makesum".
Crazy! I see that but I have no idea how the TIMESTAMP got stripped off.
Thanks a million, Fernando!

--chris