Ports of python modules which come from python itself (databases/py-sqlite3, databases/py-gdbm, x11-toolkits/py-tkinter) use custom setup.py files. These use distutils which are deprecated and removed in upcoming python 3.12. Switch these to setuptools to allow building with python3. Buildtested with all supported python versions.
setup.py itself is also deprecated. If we are to continue having these separated out from the base Python distribution, please use pyproject.toml instead.
pyproject.toml is not yet supported by our Uses/python.mk (I've had to add `setup.py` with `from setuptools import setup; setup()` for a couple of ports which have really dropped it) so migrating off it is a large task and out of scope of this pr. I'm also not quite sure how we can switch to pyproject.toml for at least py-sqlite, as setup.py there contains some logic dependent on python version.
I'm going to commit that support within the week, pending "test suite" results (see https://wiki.freebsd.org/Python/PEP-517 and bug 255722). This is very much in scope here because the former method is no longer compliant with modern Python packaging standards.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7446740638e7d833fde0962e71ef440a6af3c749 commit 7446740638e7d833fde0962e71ef440a6af3c749 Author: Dmitry Marakasov <amdmi3@FreeBSD.org> AuthorDate: 2022-12-15 15:07:26 +0000 Commit: Dmitry Marakasov <amdmi3@FreeBSD.org> CommitDate: 2022-12-15 15:14:33 +0000 */py-{gdbm,sqlite3,tkinter}: switch from distutils to setuptools For python modules which come from python itself, switch from distutils (no longer present in python 3.12) to setuptools, fixing these mudules for python 3.12. PR: 268283 Approved by: vishwin (python@) databases/py-gdbm/files/setup3.py | 12 +++++++----- databases/py-sqlite3/files/setup3.py | 13 +++++++------ x11-toolkits/py-tkinter/files/setup3.py | 12 ++++++------ 3 files changed, 20 insertions(+), 17 deletions(-)
This was not approved, please revert. maintainer-feedback was to prevent the timeout only.
> This was not approved It was. > maintainer-feedback was to prevent the timeout only. Sorry, there's no way for me to interpret explicit approval as non-approval. > please revert. On which basis? This fixes setup.py for python 3.12 and is required for its addition. It does not change change the behavior for other versions. As mentioned, it does not intersect with your work - you're free to replace setup.py support with whatever regardless of whether setup.py's for these 3 ports use distutils or setuptools.
'Set (+) when you provide feedback. Avoids "maintainer timeout"' is all maintainer-feedback means here. The feedback in previous comments was not approval to commit. Python 3.12 has not even reached release candidate yet. The base distribution will continue to successfully build without these, as we have experienced for so many versions now. For the separated components alluded to here, things are going to break or hold other items up, and they will get worked on, but do it properly. setup.py is deprecated along with distutils getting removed, so continuing to use the former is not acceptable, even if it does not error out.
> The feedback in previous comments was not approval to commit Oh, my bad then. Bugzilla's, to be precise. > Python 3.12 has not even reached release candidate yet This is not relevant to adding it to the tree, the same way how previous prereleases were added (and helped a lot to prepare the tree for the new python version). > setup.py is deprecated along with distutils getting removed, so continuing to use the former is not acceptable, even if it does not error out. This is nonsence, as "continuing to use" setup.py's for these ports is the only thing which keeps them working. As long as setup.py's are in place, these should be maintained and kept functioning, that's what I do. There's no alternative to them. Please provide a valid reason for it to be rolled back, such as it breaks something or it blocks someone's work. For now it looks like you're trying to block both my and Wen's, who did similar python3.12 port in parallel.
setup.py has been deprecated since setuptools 58.3.0 (https://github.com/pypa/setuptools/commit/fc5c3083908170e1cbfd1dec91f87a3e2707e3fa), so if anyone is that anal about using setup.py (on Python 3), go ahead and add a devel/py-setuptools58 to BUILD_DEPENDS. distutils will not get retroactively removed in future point releases of existing Python major releases, so that method continues to work there. The alternative for this case is to construct pyproject.toml, which, surprise, also works for every supported Python 3 production release! Python 3.12 not even reaching release candidate or in our tree is very relevant, not least *precisely* due to distutils removal amongst other items. distutils removal from the base distribution is not merely a technical change, but a structural change on how our corner of the Python packaging ecosystem moves forward, and it starts here. The valid reason to revert is the lack of explicit approval, periodt.
(In reply to Charlie Li from comment #9) > setup.py has been deprecated since setuptools 58.3.0 (https://github.com/pypa/setuptools/commit/fc5c3083908170e1cbfd1dec91f87a3e2707e3fa) ... distutils will not get retroactively removed in future point releases of existing Python major releases, so that method continues to work there Well this is in fact the valid reason for revert. The only one mentioned in the tread so far.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=62723bbe60705c70cf2dceb23a22a73bdd4d4ae3 commit 62723bbe60705c70cf2dceb23a22a73bdd4d4ae3 Author: Dmitry Marakasov <amdmi3@FreeBSD.org> AuthorDate: 2022-12-15 17:29:27 +0000 Commit: Dmitry Marakasov <amdmi3@FreeBSD.org> CommitDate: 2022-12-15 17:31:40 +0000 Revert "*/py-{gdbm,sqlite3,tkinter}: switch from distutils to setuptools" This reverts commit 7446740638e7d833fde0962e71ef440a6af3c749. The change is not valid as setuptools have deprecated setup.py, while distutils will be supported in existing point releases. Python 3.12 support will require different solution. PR: 268283 databases/py-gdbm/files/setup3.py | 12 +++++------- databases/py-sqlite3/files/setup3.py | 13 ++++++------- x11-toolkits/py-tkinter/files/setup3.py | 12 ++++++------ 3 files changed, 17 insertions(+), 20 deletions(-)
I think this is the first unblocked issue to get to Python 3.12. What would we need to do to resolve this?
Created attachment 249898 [details] Proposed PEP517 switch (apply via git am) Hi. I've created pyproject.toml for sqlite module that works for python3 (python27 is left on distutils). I'm not using py-installer because it cannot install anything outside site-packages dir. poudriere checks passed for py39, py311, and py27. BTW, homeassistant dropped 3.11 support and now requires 3.12.