Bug 268353 - archivers/ark: compile failure - mode_t
Summary: archivers/ark: compile failure - mode_t
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-13 13:06 UTC by Jason Beech-Brandt
Modified: 2022-12-13 15:23 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+


Attachments
v1 (1.56 KB, patch)
2022-12-13 14:51 UTC, Tobias C. Berner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Beech-Brandt 2022-12-13 13:06:45 UTC
I'm getting a compile failure with ark-22.12.0:

/usr/bin/c++ -DDEPENDENCY_TOOL=\"ldd\" -DKCOREADDONS_LIB -DKF_DEPRECATED_WARNINGS_SINCE=0x060000 -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DEPRECATED_WARNINGS_SINCE=0x060000 -DQT_DISABLE_DEPRECATED_BEFORE=0x050f00 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_FOREACH -DQT_NO_KEYWORDS -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_URL_CAST_FROM_STRING -DQT_STRICT_ITERATORS -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_XML_LIB -DTRANSLATION_DOMAIN=\"ark\" -D_LARGEFILE64_SOURCE -Dkerfuffle_EXPORTS -I/usr/ports/archivers/ark/work/.build/kerfuffle -I/usr/ports/archivers/ark/work/ark-22.12.0/kerfuffle -I/usr/ports/archivers/ark/work/.build/kerfuffle/kerfuffle_autogen/include -isystem /usr/local/include/KF5/KPty -isystem /usr/local/include/KF5 -isystem /usr/local/include/qt5 -isystem /usr/local/include/qt5/QtCore -isystem /usr/local/lib/qt5/mkspecs/freebsd-clang -isystem /usr/local/include/KF5/KCoreAddons -isystem /usr/local/include/KF5/KI18n -isystem /usr/local/include/KF5/KWidgetsAddons -isystem /usr/local/include/qt5/QtWidgets -isystem /usr/local/include/qt5/QtGui -isystem /usr/local/include/qt5/QtConcurrent -isystem /usr/local/include/KF5/KConfig -isystem /usr/local/include/KF5/KConfigCore -isystem /usr/local/include/KF5/KIOCore -isystem /usr/local/include/KF5/KIO -isystem /usr/local/include/KF5/KService -isystem /usr/local/include/qt5/QtNetwork -isystem /usr/local/include/qt5/QtDBus -isystem /usr/local/include/KF5/KIOWidgets -isystem /usr/local/include/KF5/KIOGui -isystem /usr/local/include/KF5/KWindowSystem -isystem /usr/local/include/KF5/KJobWidgets -isystem /usr/local/include/KF5/Solid -isystem /usr/local/include/KF5/KCompletion -isystem /usr/local/include/KF5/KIOFileWidgets -isystem /usr/local/include/KF5/KBookmarks -isystem /usr/local/include/qt5/QtXml -isystem /usr/local/include/KF5/KItemViews -isystem /usr/local/include/KF5/KXmlGui -isystem /usr/local/include/KF5/KConfigWidgets -isystem /usr/local/include/KF5/KCodecs -isystem /usr/local/include/KF5/KConfigGui -isystem /usr/local/include/KF5/KAuthWidgets -isystem /usr/local/include/KF5/KAuthCore -isystem /usr/local/include/KF5/KAuth -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -fno-operator-names -fno-exceptions -Wno-gnu-zero-variadic-macro-arguments -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Werror=init-self -Werror=undef -Wvla -Wdate-time -pedantic -Wzero-as-null-pointer-constant -fdiagnostics-color=always -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -DNDEBUG -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -std=c++17 -MD -MT kerfuffle/CMakeFiles/kerfuffle.dir/kerfuffle_autogen/mocs_compilation.cpp.o -MF kerfuffle/CMakeFiles/kerfuffle.dir/kerfuffle_autogen/mocs_compilation.cpp.o.d -o kerfuffle/CMakeFiles/kerfuffle.dir/kerfuffle_autogen/mocs_compilation.cpp.o -c /usr/ports/archivers/ark/work/.build/kerfuffle/kerfuffle_autogen/mocs_compilation.cpp
In file included from /usr/ports/archivers/ark/work/.build/kerfuffle/kerfuffle_autogen/mocs_compilation.cpp:6:
In file included from /usr/ports/archivers/ark/work/.build/kerfuffle/kerfuffle_autogen/EWIEGA46WW/moc_archiveinterface.cpp:10:
/usr/ports/archivers/ark/work/.build/kerfuffle/kerfuffle_autogen/EWIEGA46WW/../../../../ark-22.12.0/kerfuffle/archiveinterface.h:170:40: error: unknown type name 'mode_t'; did you mean '__mode_t'?
    static QString permissionsToString(mode_t perm);
                                       ^~~~~~
                                       __mode_t
/usr/include/sys/_types.h:51:20: note: '__mode_t' declared here
typedef __uint16_t      __mode_t;       /* permissions */
                        ^
1 error generated.
ninja: build stopped: subcommand failed.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-13 14:00:11 UTC
(In reply to Jason Beech-Brandt from comment #0)
Moin moin 

Thanks for the report -- what architecture and FreeBSD version are you experiencing this issue on?


mfg Tobias
Comment 2 Jason Beech-Brandt 2022-12-13 14:03:24 UTC
Sorry should have put that in - this is amd64 and I'm running 12.4-RELEASE
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-13 14:44:35 UTC
(In reply to Jason Beech-Brandt from comment #2)
no worries, I'll try to reproduce, fix it upstream and then put it in the tree :)
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-13 14:45:48 UTC
(In reply to Tobias C. Berner from comment #3)
https://invent.kde.org/berner/ark/-/commit/d2d631aa1a4a8f61e80ae5bf28f7632a9cb876b0 


looks like it is already fixed upstream
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-13 14:51:21 UTC
Created attachment 238761 [details]
v1

Please try the attached patch:

https://people.freebsd.org/~tcberner/patches/0001-archivers-ark-fix-build-on-FreeBSD-12.x.patch
Comment 6 Jason Beech-Brandt 2022-12-13 15:09:02 UTC
The patch fixes things for me, thanks
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-12-13 15:21:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=016f8aac1768778686ae62e4c35dbf0f7527a5c7

commit 016f8aac1768778686ae62e4c35dbf0f7527a5c7
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2022-12-13 14:48:15 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2022-12-13 15:20:48 +0000

    archivers/ark: fix build on FreeBSD 12.x

    Import upstream fix.

    PR:             268353
    Reported by:            Jason Beech-Brandt <jjb-b@hotmail.com>

 archivers/ark/Makefile | 3 +++
 archivers/ark/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 8 Tobias C. Berner freebsd_committer freebsd_triage 2022-12-13 15:23:19 UTC
Thanks for testing.