Bug 268505 - mail/imaptools: update to 1.136, fix MASTER_SITES && WWW
Summary: mail/imaptools: update to 1.136, fix MASTER_SITES && WWW
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-21 22:50 UTC by Chris Hutchinson
Modified: 2022-12-31 22:02 UTC (History)
1 user (show)

See Also:
bofh: maintainer-feedback-
portmaster: maintainer-feedback?


Attachments
git diff for mail/imaptools (1.86 KB, patch)
2022-12-21 22:50 UTC, Chris Hutchinson
no flags Details | Diff
git diff for mail/imaptools (version 2) (1.67 KB, patch)
2022-12-27 04:44 UTC, Chris Hutchinson
portmaster: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2022-12-21 22:50:11 UTC
Created attachment 238964 [details]
git diff for mail/imaptools

The attached git diff (patch) updates mail/imaptools to 1.136.
I've been using this for years and discovered the WWW listed
in the Makefile hasn't been under the authors control since
2016. As a result, I took the liberty of collecting all the
source and history and performed some cleanup and standardization.
I'm going to maintain the source.

Imaptools-1.136 changelog:
provide a home where it can be evaluated and actively maintained
provide a web page
perform source cleanup
update source where required
What's next for 1.137?
Standardize, update and consolidate source
Remove usage from source headers
place pod within the source to facilitate usage/man pages
???

Changes to port
Makefile
distinfo
pkg-descr

Tests and functions as intended on 12/13(AMD64)

That's it!

P.S. If the current maintainer is un(able|interested). I'd
be happy to maintain this port. As I now maintain the source. :-)

Thanks again!

--Chris
Comment 1 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-12-24 01:51:06 UTC
Thanks for the patch specially taking over the project and updating the codebase to match recent Perl Updates.. However I have some different say and approach on situations like these specially when the author of the original application has passed away.

If you consider the git* cultures there are lots of forks around the different public git repos of the same application. The question about who's version is better than others is a trivial question and cannot be solved when there is no centralized maintainer. In such cases it is always good not to release new version out of it; but use a different tag/commit hash to get the source tarballs. Because at a later date someone might take over the project and can create an official release based on the LICENSES scheme for the source code.

In this scenario I would advise not to use the version bump and go ahead with git hashes to download the sources and create an update. You might think this is a non trivial issue but we have seen cases like these in previous when someone took over a project, forked it and released a new version as the project was silent. And after a while someone officially took over the dead project and released a version with same number which might be conflicting.
Comment 2 Chris Hutchinson 2022-12-25 07:12:25 UTC
(In reply to Muhammad Moinur Rahman from comment #1)
Thanks for the reply, and merry Christmas, if it applies! :-)

As to your reply;
The source was not under RCS or VCS. I simply placed
it under VCS so that it would be easier to manage, and
for others to contribute.
Perhaps I simply can't follow your intended message?

Thanks again!

--Chris
Comment 3 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-12-25 12:53:52 UTC
(In reply to Chris Hutchinson from comment #2)
Merry Christmas and advanced Happy New Year.

My concern is not releasing this under RCS/VCS but my concern is that you have created a new version release(1.136 the original one was 1.135) out of this. Which I actually do not support from forks as the original application might be resurrected again by someone making it official. And at that point that official fork might release a new version 1.136 which will be directly conflicting with your version of 1.136. But here in FreeBSD ports tree we have options to download original sources although there was no official releases. I believe now if you read my previous comments again it will make sense.

If you want to check how that works, visit https://fdp.bofh.network/books/porters-handbook/book/#makefile-master_sites-github and check Example 16 and Example 19. In case you are still unsure what to do wait for a while, I will take care of the issue in next month. This is also the end of the quarterly and I have some other works to do on the tree before the end of the quarter.
Comment 4 Chris Hutchinson 2022-12-25 23:56:43 UTC
(In reply to Muhammad Moinur Rahman from comment #3)
While I got your message. I'm still somewhat unclear as to
the reasoning; as imaputils itself appears to violate that.
No matter. I can simply change the source tag to match the
initial import of the original source; thereby satisfying
your concerns.
I'll do that tomorrow, and submit a patch.

Thanks, and an advanced Happy New Year to you! :-)

--Chris
Comment 5 Chris Hutchinson 2022-12-27 04:44:00 UTC
Created attachment 239056 [details]
git diff for mail/imaptools (version 2)

OK. Here's the patch as promised. This version should
meets your expressed grievances regarding the previous
patch.

All the best to you.

--Chris
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-12-31 22:00:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=79cd5d1ad4b99364fd1194b1c181365b4c5ec708

commit 79cd5d1ad4b99364fd1194b1c181365b4c5ec708
Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
AuthorDate: 2022-12-31 18:41:15 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2022-12-31 21:58:52 +0000

    mail/imaptools: Change upstream to managed fork

    Chris is maintaining an updated fork of the tools as the author of the
    application sadly passed away. This patch changes the upstream to use
    the fork.

    - Mark NO_ARCH

    PR:             268505
    Reported by:    portmaster@bsdforge.com

 mail/imaptools/Makefile  | 20 +++++++++++++-------
 mail/imaptools/distinfo  |  5 +++--
 mail/imaptools/pkg-descr |  2 +-
 3 files changed, 17 insertions(+), 10 deletions(-)
Comment 7 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2022-12-31 22:02:04 UTC
Committed with changes.