Bug 268519 - archivers/libdeflate: Update to 1.15
Summary: archivers/libdeflate: Update to 1.15
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL: https://github.com/ebiggers/libdeflat...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-22 22:48 UTC by Daniel Engberg
Modified: 2023-01-05 08:26 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments
Patch for libdeflate (4.56 KB, patch)
2022-12-22 22:48 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-12-22 22:48:30 UTC
Created attachment 238980 [details]
Patch for libdeflate

* Switch to CMake (upstream)
* Backport upstream commit 98174ac5e6fe2a806923bcb6bfa24cdbf32c79d0
* Switch to pkg-plist

Compile and runtime tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.3-RELEASE (amd64)
Poudriere testport OK 13.1-RELEASE (i386)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-01-01 15:15:04 UTC
Tested with following users in Poudriere, FreeBSD 12.3-RELEASE (amd64):

archivers/advancecomp
biology/fastp
biology/htslib
biology/vt
devel/notcurses
graphics/tiff
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-01-03 08:23:50 UTC
Friendly ping
Comment 3 Alexey Dokuchaev freebsd_committer freebsd_triage 2023-01-03 09:25:04 UTC
> cmake:testing pathfix
Interesting: pathfix apparently does its thing, looking at the log diff:

--- Installing: $wrkdir/stage/usr/local/lib/pkgconfig/libdeflate.pc
+-- Installing: $wrkdir/stage/usr/local/libdata/pkgconfig/libdeflate.pc

But resulting pkg-plist is correct regardless of USES+=pathfix.

> Backport upstream commit 98174ac5e6fe2a806923bcb6bfa24cdbf32c79d0
How exactly is it needed?  Looks like it affects futimes(2) detection.  What's desired logic here?
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-01-03 09:57:20 UTC
Hi,

There's a "safeguard" here https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n3538 but I prefer to fix paths so output and logs are consistent.

To be honest I backported 98174ac5e6fe2a806923bcb6bfa24cdbf32c79d0 simply because of consistentcy so unit tests reflects on release binaries.

Best regards,
Daniel
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-01-05 08:23:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c8d13ef7f3386389410c492dedb63858bbe7f1cc

commit c8d13ef7f3386389410c492dedb63858bbe7f1cc
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-01-05 08:21:46 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2023-01-05 08:21:46 +0000

    archivers/libdeflate: update the port to version 1.15

    - The build system had been switched to CMake, adjust the Makefile
      accordingly and convert outgrown PLIST_FILES into static pkg-plist
    - Backport one upstream commit for the sake of consistency, so unit
      tests reflect on release binaries (it also happens to inadvertently
      inhibit detection of futimes(2), which is deprecated interface as
      it does not provide nanosecond accuracy, so it's probably okay)
    - Do not pass "-O2 -DNDEBUG" on release CFLAGS: -O2 is redundant and
      NDEBUG is not actually used anywhere in the library source code

    PR:     268519

 archivers/libdeflate/Makefile                    | 23 +++++++++----------
 archivers/libdeflate/distinfo                    |  8 ++++---
 archivers/libdeflate/files/patch-Makefile (gone) | 29 ------------------------
 archivers/libdeflate/pkg-plist (new)             | 13 +++++++++++
 4 files changed, 29 insertions(+), 44 deletions(-)
Comment 6 Alexey Dokuchaev freebsd_committer freebsd_triage 2023-01-05 08:26:21 UTC
Thank you for elaborate patch and your patience.