Bug 268538 - dns/c-ares: Update to 1.19.0 and switch to CMake
Summary: dns/c-ares: Update to 1.19.0 and switch to CMake
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ryan Steinmetz
URL: https://c-ares.org/changelog.html#1_19_0
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-24 11:28 UTC by Daniel Engberg
Modified: 2023-01-29 18:51 UTC (History)
0 users

See Also:
zi: maintainer-feedback+


Attachments
Patch for c-ares (792 bytes, patch)
2022-12-24 11:28 UTC, Daniel Engberg
no flags Details | Diff
Patch for c-ares (6.80 KB, patch)
2023-01-29 14:25 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-12-24 11:28:42 UTC
Created attachment 238998 [details]
Patch for c-ares

We build test suite by default but it's not connected so we might as well disable it for now. While add it change PORTVERSION to DISTVERSION to follow Porters Handbook more closely and remove c-ares.haxx.se as it redirects to c-ares.org. Add GitHub as primary site and fall back to c-ares.org if it fails for better connectivity and download speed.

Compile tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist)
Comment 1 Ryan Steinmetz freebsd_committer freebsd_triage 2022-12-24 14:19:09 UTC
Guess we can roll this in during the next update.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-01-29 14:25:09 UTC
Created attachment 239784 [details]
Patch for c-ares

- Use GitHub as primary mirror for better connectivity and use main site as fallback
- Switch to CMake to provide .cmake files, improve compilation performance and adhere framework options
  Additionally also aligns with other distributions such as Alpine, Arch, Fedora, MacPorts and openSUSE
- Drop CONFIG_INFO patch, this is no longer needed by UnrealIRCd
- Enable "make test", only build test suite when requested, disable online tests and use Googletest from tree instead of bundled version

Compile and runtime tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.3-RELEASE (amd64)
Poudriere testport OK 13.1-RELEASE (i386)

Compile tested with following consumers using Poudriere (12.3-RELEASE (amd64)):
devel/bear
devel/google-cloud-cpp
devel/google-cloud-cpp117
devel/grpc
devel/grpc142
devel/py-gevent
devel/py-grpcio
devel/py-grpcio-tools
games/bzflag
games/bzflag-server
irc/ircproxy
mail/greylite
net/frr7
net/frr8
net/megacmd
net/mosquitto
net/rubygem-grpc
net/rubygem-grpc142
net/shadowsocks-libev
net/sipsak
net/wireshark
net-mgmt/xymon-server
security/sssd
security/zeek
www/envoy (skipped, marked as broken)
www/nghttp2
www/node
www/node14
www/node16
Comment 3 Ryan Steinmetz freebsd_committer freebsd_triage 2023-01-29 15:47:00 UTC
Approved.  Please feel free to commit.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-01-29 18:50:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4357da1d4e4deb422e7744e1dfd6927a196195c1

commit 4357da1d4e4deb422e7744e1dfd6927a196195c1
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-01-29 18:47:33 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-01-29 18:49:36 +0000

    dns/c-ares: Update to 1.19.0 and switch to CMake

    - Use GitHub as primary mirror for better connectivity and use
      main site as fallback
    - Switch to CMake to provide .cmake files, improve compilation
      performance and adhere framework options
      Additionally also aligns port with other distributions such as
      Alpine, Arch, Fedora, MacPorts and openSUSE
    - Drop CONFIG_INFO patch, this is no longer needed by UnrealIRCd
    - Enable "make test", only build test suite when requested, disable
      online tests and use Googletest from tree instead of bundled version

    Changelog: https://c-ares.org/changelog.html#1_19_0

    PR:             268538
    Reviewed by:    zi (maintainer)

 dns/c-ares/Makefile                              | 37 +++++-------
 dns/c-ares/distinfo                              |  6 +-
 dns/c-ares/files/ares-config-info.patch (gone)   | 73 ------------------------
 dns/c-ares/files/patch-test_CMakeLists.txt (new) | 34 +++++++++++
 dns/c-ares/pkg-plist                             | 10 +++-
 5 files changed, 59 insertions(+), 101 deletions(-)