Bug 268566 - audio/lame: Remove libsndfile support and modernize port
Summary: audio/lame: Remove libsndfile support and modernize port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexander Leidinger
URL:
Keywords:
Depends on:
Blocks: 268621
  Show dependency treegraph
 
Reported: 2022-12-26 08:27 UTC by Daniel Engberg
Modified: 2023-01-03 10:59 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (netchild)


Attachments
Patch for lame (1.41 KB, patch)
2023-01-03 09:07 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-12-26 08:27:34 UTC
* Remove libsndfile support as this will cause a circular dependency as of 1.2.0 [1]
* Do some minor change to port to make it follow Porters Handbook more closely and easier to read

1: https://github.com/libsndfile/libsndfile/blob/master/cmake/SndFileChecks.cmake#L52

Compile tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-01-03 09:07:32 UTC
Created attachment 239227 [details]
Patch for lame

Actually attach patch...
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-01-03 10:58:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=214c275778984faddbff27ca960d51380b64acc8

commit 214c275778984faddbff27ca960d51380b64acc8
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-01-03 10:33:34 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-01-03 10:33:38 +0000

    audio/lame: Remove libsndfile support and modernize port

    Remove libsndfile support as this will cause circular dependency
    with upcoming release of libsndfile 1.2.0. While it's possible to
    disable usage of specific external libraries to some extent we want
    to follow upstream as closely as possible instead of having to work
    around such issues. If better input support is needed ffmpeg provides
    support for LAME (by default), much better input format support and
    very little overhead. While at it, do some minor changes to Makefile.

    PR:             268566
    Reviewed by:    netchild (maintainer via private e-mail)

 audio/lame/Makefile | 26 ++++++++++----------------
 1 file changed, 10 insertions(+), 16 deletions(-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-01-03 10:59:41 UTC
Committed