Bug 268572 - devel/libgit2: Don't build unit tests by default and improve "make test"
Summary: devel/libgit2: Don't build unit tests by default and improve "make test"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Fechner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-26 18:13 UTC by Daniel Engberg
Modified: 2023-01-13 08:16 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mfechner)

Attachments
Patch for libgit2 (5.95 KB, patch)
2022-12-26 18:13 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-12-26 18:13:11 UTC 
Created attachment 239037 [details]
Patch for libgit2

Only build test suite when we request it and adjust tests

There's still one failure that seems to be occurring if you're running as root [1] and I'm unable to work out where and/or if upstream ever fixed this test.

References:
https://github.com/archlinux/svntogit-packages/blob/packages/libgit2/trunk/PKGBUILD
1: https://github.com/libgit2/libgit2/issues/6307
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-01-13 07:01:28 UTC 
Friendly ping
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-01-13 08:13:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bc220a9f11481453f1f9b3864dcadc2c37b8eca8

commit bc220a9f11481453f1f9b3864dcadc2c37b8eca8
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-01-13 08:11:10 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2023-01-13 08:13:08 +0000

    devel/libgit2: only build test suite when we request it and adjust tests

    There's still one failure that seems to be occurring if you're running as
    root [1] and I'm unable to work out where and/or if upstream ever fixed this test.

    References:
    https://github.com/archlinux/svntogit-packages/blob/packages/libgit2/trunk/PKGBUILD
    1: https://github.com/libgit2/libgit2/issues/6307

    PR:             268572

 devel/libgit2/Makefile                             |  16 ++-
 .../patch-tests_libgit2_network_url_parse.c (new)  | 116 +++++++++++++++++++++
 2 files changed, 122 insertions(+), 10 deletions(-)
Comment 3 Matthias Fechner freebsd_committer freebsd_triage 2023-01-13 08:16:04 UTC 
Hi Daniel,

thanks for contribution and the friendly reminder ;)

I committed it.