Bug 268595 - sysutils/p5-File-Rename: Update to 1.99
Summary: sysutils/p5-File-Rename: Update to 1.99
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-27 08:38 UTC by Wen Heping
Modified: 2023-01-11 13:56 UTC (History)
1 user (show)

See Also:
vidar: maintainer-feedback+


Attachments
Update to 1.99 (883 bytes, text/plain)
2022-12-27 08:38 UTC, Wen Heping
no flags Details
git format-patch, update to 1.99 (works) (2.92 KB, patch)
2022-12-27 11:07 UTC, Vidar Karlsen
vidar: maintainer-approval+
Details | Diff
update to 1.992 (1.63 KB, patch)
2022-12-28 09:07 UTC, Vidar Karlsen
vidar: maintainer-approval+
Details | Diff
update to 2.00 (1.92 KB, patch)
2023-01-02 14:47 UTC, Vidar Karlsen
vidar: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wen Heping freebsd_committer freebsd_triage 2022-12-27 08:38:23 UTC
Created attachment 239060 [details]
Update to 1.99

Update to 1.99
Comment 1 Vidar Karlsen 2022-12-27 11:07:28 UTC
Created attachment 239063 [details]
git format-patch, update to 1.99 (works)

Thanks for the heads-up, I had missed the newer releases.

It turned out, however, not to be a matter of a simple version bump. A few more changes are required. I'm attaching a new patch.

It's been tested to build, install and run in poudriere under 13.1 and 12.3.
Comment 2 Vidar Karlsen 2022-12-27 11:10:32 UTC
Please note that there is a ^M control character in the Makefile, line 21, as it needs to run a sed replace command prior to the patch target. Is there a better way to solve this?
Comment 3 Vidar Karlsen 2022-12-28 09:07:02 UTC
Created attachment 239081 [details]
update to 1.992

Two new versions dropped, fixing the missing shebang and thus removing the need for the previous sed replacement confusion.
Comment 5 Li-Wen Hsu freebsd_committer freebsd_triage 2022-12-29 08:53:21 UTC
Submitter is committer.
Comment 6 Vidar Karlsen 2023-01-02 14:47:15 UTC
Created attachment 239214 [details]
update to 2.00

2.00 was released.

TL;DR changelog:
- Adding unicode support
- Now requiring options BEFORE code/files
- bin/unsafe-rename retains the old behavior with no_require_order

QA:
portlint looks fine.
poudriere testport on 13.1-amd64 looks fine.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-01-11 13:55:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=51af18c057bb6b83699ec801e5a19068ae622bca

commit 51af18c057bb6b83699ec801e5a19068ae622bca
Author:     Wen Heping <wen@FreeBSD.org>
AuthorDate: 2023-01-11 13:53:54 +0000
Commit:     Wen Heping <wen@FreeBSD.org>
CommitDate: 2023-01-11 13:53:54 +0000

    sysutils/p5-File-Rename: Update to 2.00

    PR:             268595
    Reported by:    wen@
    Approved by:    maintainer

 sysutils/p5-File-Rename/Makefile  | 2 +-
 sysutils/p5-File-Rename/distinfo  | 6 +++---
 sysutils/p5-File-Rename/pkg-plist | 4 ++++
 3 files changed, 8 insertions(+), 4 deletions(-)