Bug 268691 - emulators/{mame,mess}: Update to 0.254
Summary: emulators/{mame,mess}: Update to 0.254
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL: https://www.mamedev.org/releases/what...
Keywords:
Depends on:
Blocks: 271324
  Show dependency treegraph
 
Reported: 2023-01-01 08:39 UTC by Alastair Hogge
Modified: 2023-05-09 08:13 UTC (History)
2 users (show)

See Also:
agh: maintainer-feedback+


Attachments
Patch to update MAME/MESS to 0.251 (4.81 KB, patch)
2023-01-01 11:47 UTC, Alastair Hogge
agh: maintainer-approval+
Details | Diff
Patch to update MAME/MESS to 0.252 (12.29 KB, patch)
2023-02-24 14:15 UTC, Alastair Hogge
agh: maintainer-approval+
Details | Diff
Update MAME to 0.254 and remove MESS (197.37 KB, text/plain)
2023-05-08 09:11 UTC, Alastair Hogge
no flags Details
Update MAME to 0.254 and remove MESS (133.97 KB, patch)
2023-05-08 09:46 UTC, Alastair Hogge
agh: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alastair Hogge 2023-01-01 08:39:50 UTC
https://www.mamedev.org/?p=520
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2023-01-01 10:06:40 UTC
Forgot to attach the patch?
Comment 2 Alastair Hogge 2023-01-01 10:21:20 UTC
(In reply to Li-Wen Hsu from comment #1)

Still working on it.
Comment 3 Alastair Hogge 2023-01-01 11:47:49 UTC
Created attachment 239175 [details]
Patch to update MAME/MESS to 0.251

I have yet to test the patch with poudriere-testport—will update the report when I have.
Comment 4 Alastair Hogge 2023-01-01 23:13:54 UTC
Comment on attachment 239175 [details]
Patch to update MAME/MESS to 0.251

Patch passed poudriere-testport.
Comment 5 Alastair Hogge 2023-01-02 02:33:59 UTC
The poudriere-bulk build of mame-0.251 is failing on my system, yet the poudriere-testport build is passing. So I have removed the "maintainer-approval+" flag from the diff until I understand what is going on, and have a solution.
Comment 6 Li-Wen Hsu freebsd_committer freebsd_triage 2023-01-02 02:36:47 UTC
(In reply to Alastair Hogge from comment #5)
`poudriere bulk` works on my system for {13.1, 12.3}x{amd64, i386}. Maybe it's local error like out of memory or timeout. Do you want to share the log somewhere?
Comment 7 Alastair Hogge 2023-01-02 03:18:22 UTC
I am suspecting it is local to my system too, I have also noted that the error changes between build attempts. I am thinking right now, that the patch can be committed, and any problems can be addressed when pkg-fallout notifies me.

Build logs for your interest.
https://dpaste.com/DFXHLZKKA
https://dpaste.com/E6E6NFACP
Comment 8 Alastair Hogge 2023-01-02 03:19:39 UTC
Sorry, late sentence in last comment was meant to be a question.
Comment 9 Alastair Hogge 2023-01-02 03:33:03 UTC
The bulk build seems to OK at the moment with MAKE_JOBS_UNSAFE=yes, so I think we can right it off as a local problem to my host.
Comment 10 Alastair Hogge 2023-02-24 14:15:14 UTC
Created attachment 240375 [details]
Patch to update MAME/MESS to 0.252

Patch to update MAME/MESS to 0.251
Comment 11 Alastair Hogge 2023-03-30 07:57:05 UTC
https://www.mamedev.org/releases/whatsnew_0253.txt
Comment 12 Alastair Hogge 2023-04-07 07:39:44 UTC
Regarding 0.253, NetBSD is also having the same build issues as FreeBSD:
https://github.com/mamedev/mame/issues/11049
Comment 13 Alastair Hogge 2023-04-07 07:40:41 UTC
Compressing src/mame/layout/zodiac.lay...
Compressing src/mame/layout/zoo.lay...
.../emulators/mame/work/mame-mame0253/scripts/toolchain.lua:65: attempt to concatenate a nil value (field '?')
stack traceback:
        .../emulators/mame/work/mame-mame0253/scripts/toolchain.lua:65: in function 'androidToolchainRoot'
        .../emulators/mame/work/mame-mame0253/scripts/toolchain.lua:494: in function 'toolchain'
        ...atch/emulators/mame/work/mame-mame0253/scripts/genie.lua:1150: in main chunk
        [C]: in upvalue 'builtin_dofile'
        [string "premake = { }..."]:109: in function 'dofile'
        [string "_WORKING_DIR        = os.getcwd()..."]:46: in function '_premake_main'
gmake: *** [makefile:1424: build/projects/sdl/mame/gmake-netbsd/Makefile] Error 1
gmake: *** Waiting for unfinished jobs....
*** Error code 2
Comment 14 Alastair Hogge 2023-04-11 22:51:59 UTC
NetBSD/pkgsrc might have a fix:
https://github.com/NetBSD/pkgsrc/tree/trunk/emulators/mame
Comment 15 Alastair Hogge 2023-05-08 09:11:16 UTC
Created attachment 242050 [details]
Update MAME to 0.254 and remove MESS

Update MAME to 0.254 and remove MESS:

* the MESS ${SUBTARGET} is obsolete and the build infrastructure has been removed upstream, the port itself is just MAME with the mess name for the binary, so remove the port.
* address more port{clippy,fmt,lint} Makefile hits
* add more licenses to the Makefile
* make use of NetBSD's pkgsrc fix (https://github.com/NetBSD/pkgsrc/commit/d4e7255760d39e8133aa7b12b0db27b0edd40486#diff-424a85c0a27e860e9dfc1d15061b1a4b8a0fabb1ff7fba7f2ddcfca351d8a94b) to restore building on FreeBSD
* poudriere-testport passes for {amd64,i386}-{12.4,13.1,13.2}-RELEASE
Comment 16 Alastair Hogge 2023-05-08 09:15:44 UTC
Comment on attachment 242050 [details]
Update MAME to 0.254 and remove MESS

B0rked patch
Comment 17 Alastair Hogge 2023-05-08 09:46:10 UTC
Created attachment 242054 [details]
Update MAME to 0.254 and remove MESS

Correct patch.
Comment 18 commit-hook freebsd_committer freebsd_triage 2023-05-09 08:00:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3841ad2f6e56bcb80d80bcda7dd83fcb6fd9c3af

commit 3841ad2f6e56bcb80d80bcda7dd83fcb6fd9c3af
Author:     Alastair Hogge <agh@riseup.net>
AuthorDate: 2023-05-09 07:53:43 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2023-05-09 07:59:12 +0000

    emulators/mame: Update to 0.254

    emulators/mess has been merged to emulators/mame in the upstream.

    PR:             268691

 MOVED                                              |    1 +
 emulators/Makefile                                 |    1 -
 emulators/mame/Makefile                            |   85 +-
 emulators/mame/distinfo                            |    6 +-
 .../mame/files/patch-scripts_toolchain.lua (new)   |   12 +
 emulators/mame/pkg-plist                           |   32 +-
 emulators/mess/Makefile (gone)                     |   13 -
 emulators/mess/pkg-descr (gone)                    |    3 -
 emulators/mess/pkg-plist (gone)                    | 2224 --------------------
 9 files changed, 80 insertions(+), 2297 deletions(-)
Comment 19 Li-Wen Hsu freebsd_committer freebsd_triage 2023-05-09 08:00:58 UTC
Committed, thanks for the new patch and sorry for the delay.

BTW, a small fix applied to the MOVED entry.
Comment 20 Alastair Hogge 2023-05-09 08:13:56 UTC
(In reply to Li-Wen Hsu from comment #19)

Thank you, however, I am sorry I let port lag behind so many releases.

> BTW, a small fix applied to the MOVED entry.

Much improved, thanks again.