Created attachment 239290 [details] patch to the ports tree Hello! So, my little project d11amp saw its release 0.60, and a very short while later, release 0.61. So please do not be alarmed about missing a release. :) You can find my patch to the OpenBSD ports tree attached to this Email. Changelog: * Improved Playlist * Improved Keyboard Control * Improved Audio Output options Enjoy! P.S.: Actually, this one renders #268359 obsolete...
(In reply to Thomas Dettbarn from comment #0) Thanks, this looks *almost* perfect. A style nitpick: PLIST_FILES belongs *after* the "make block" (where you define your TEST stuff). And then, as your upstream *does* respect DESTDIR now, the whole do-install: rule should be unnecessary. I will just test that now (will take a while again as I have to rebuild lots of updated packages ...) A little tip for upstream: you could make it even more flexible using a structure e.g. like this: --- PREFIX?=/usr/local BINDIR?=$(PREFIX)/bin MANDIR?=$(PREFIX)/share/man INSTALLBIN=$(DESTDIR)$(BINDIR) ... --- But it's of course fine as it is now for packaging purposes!
(In reply to Felix Palmen from comment #1) Thank you very much. Regarding the PLIST position: I do not 100% understand where you would put it... May I thus bother you to commit it in the proper way? (You are the expert on ports. So I assume it would be quicker than for you to tell me where to put it, me creating/testing a new patch to the ports tree, me uploading the patch here, you committing it anyways...) As for the do_install: Unfortunately, since I made a snafu in d11amp's Makefile. Having said target in the port's Makefile is currently the better option. I can promise you to fix it with the next release.
(In reply to Thomas Dettbarn from comment #2) > May I thus bother you to commit it in the proper way? I had to wait for test builds anyways, so I'm just trying to help you become a "perfect" ports maintainer quickly ;) Of course I can just do minor adjustments! > As for the do_install: Unfortunately, since I made a snafu in d11amp's > Makefile. Having said target in the port's Makefile is currently the better > option. Testing it, I've seen the gotchas. But for both of them exist less intrusive options than a 'do-install' target: * The binary is installed unstripped. For that, better add a 'post-install' target that just strips it. Of course, it would be nicer if your upstream Makefile would do the stripping (either using 'strip' directly or using the '-s' flag with 'install') when not doing a debug build. * The man install path is wrong for FreeBSD. As I wrote above, it would probably make sense to explicitly make this configurable in the upstream Makefile, independently of DESTDIR. But anyways, we can already override it as it is, so let's do this instead of a custom 'do-install'. Further finding, it still links unnecessary libraries, so I had to readd LDFLAGS+= -Wl,--as-needed This would probably make sense in the upstream Makefile as well. All in all, the port to be committed should look like this: https://reviews.freebsd.org/D37974 -- just tell me whether you're fine with it!
(In reply to Felix Palmen from comment #3) Very fine! Thank you!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0941047a34de2c295d68f6c8a5db6ad8bcc999ec commit 0941047a34de2c295d68f6c8a5db6ad8bcc999ec Author: Thomas Dettbarn <dettus@dettus.net> AuthorDate: 2023-01-05 23:10:00 +0000 Commit: Felix Palmen <zirias@FreeBSD.org> CommitDate: 2023-01-09 08:23:06 +0000 audio/d11amp: Add new port D11AMP is an oldskool MP3 player. In addition to being a frontend to mpg123, it can handle WinAMP's treasure trove of skins. PR: 268776 Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D37974 audio/Makefile | 1 + audio/d11amp/Makefile (new) | 33 +++++++++++++++++++++++++++++++++ audio/d11amp/distinfo (new) | 3 +++ audio/d11amp/pkg-descr (new) | 2 ++ 4 files changed, 39 insertions(+)
Committed, thanks!