Created attachment 239313 [details] sysutils/filewatcherd: fix argument parsing on arm/arm64 Don't use char to store the return value of getopt_long, use int instead. See also: https://github.com/faelys/filewatcherd/issues/5 Tested with Poudriere on armv7 arm64 FreeBSD 13.1. Please MFH if possible.
Comment on attachment 239313 [details] sysutils/filewatcherd: fix argument parsing on arm/arm64 Good catch, thanks a lot for reporting it!
It might not be obvious, but I'm also upstream of this package. So I'm approving everything here, but I will fix it upstream within a few days. I let you decide whether it's worth the effort to patch it now in the ports infrastructure instead of waiting for the released fix.
Do what you believe is best. This issue was relayed to me by a user. It's not a big priority.
(In reply to Natacha Porté from comment #2) Any progress with the upstream fix?
Sorry for the delay, I got a bit side-tracked by personal stuff. I think I managed a 1.0 release including the fix, so the upstream side should be done. Will you do the ports side or do you prefer me to do it?
(In reply to Natacha Porté from comment #5) Thank you for committing the fix. It's your port, so I think it's better if you submitted the update.
Nice! Waiting on https://github.com/faelys/filewatcherd/releases/tag/1.0 update diff. Cheers
Created attachment 239825 [details] sysutils/filewatcherd: update to 1.0 Here is a very simple patch to update to 1.0. It works on my amd64 poudriere, I don't have an easy access an arm machine to ensure it actually fixes the issue.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7124540f1aed5cbb68480ed79a1149c368dcd0fb commit 7124540f1aed5cbb68480ed79a1149c368dcd0fb Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2023-01-31 10:04:47 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2023-01-31 10:13:16 +0000 sysutils/filewatcherd: Update to 1.0 Fix build on arm/arm64: Don't use char to store the return value of getopt_long, use int instead. ChangeLog: https://github.com/faelys/filewatcherd/releases/tag/1.0 See also: https://github.com/faelys/filewatcherd/issues/5 PR: 268793 MFH: 2023Q1 (build fixes) sysutils/filewatcherd/Makefile | 7 +++++-- sysutils/filewatcherd/distinfo | 6 +++--- 2 files changed, 8 insertions(+), 5 deletions(-)
A commit in branch 2023Q1 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a8361b60e79a426c7e5d7915825fc56c49481a57 commit a8361b60e79a426c7e5d7915825fc56c49481a57 Author: Robert Clausecker <fuz@fuz.su> AuthorDate: 2023-01-31 10:04:47 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2023-01-31 10:14:31 +0000 sysutils/filewatcherd: Update to 1.0 Fix build on arm/arm64: Don't use char to store the return value of getopt_long, use int instead. ChangeLog: https://github.com/faelys/filewatcherd/releases/tag/1.0 See also: https://github.com/faelys/filewatcherd/issues/5 PR: 268793 MFH: 2023Q1 (build fixes) (cherry picked from commit 7124540f1aed5cbb68480ed79a1149c368dcd0fb) sysutils/filewatcherd/Makefile | 7 +++++-- sysutils/filewatcherd/distinfo | 6 +++--- 2 files changed, 8 insertions(+), 5 deletions(-)
Committed, thanks!