Bug 268852 - net-mgmt/unbound_exporter - rc-script has wrong arguments
Summary: net-mgmt/unbound_exporter - rc-script has wrong arguments
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-10 08:30 UTC by Lutz Donnerhacke
Modified: 2024-03-24 17:38 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (aduitsis)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lutz Donnerhacke freebsd_committer freebsd_triage 2023-01-10 08:30:50 UTC
The unbound_exporter does not start again after updates.

Reason are wrong arguments:
 - the argument is `web.listen-address` not `web.listen-adress`
 - multi-line arguments need to be concatenated by backslashes

Patch:

```
--- x   2023-01-10 09:17:42.535941000 +0100
+++ /usr/local/etc/rc.d/unbound_exporter        2023-01-10 09:13:55.360577000 +0100
@@ -44,7 +44,7 @@
        ${unbound_exporter_cert:+-unbound.cert $unbound_exporter_cert} \
        ${unbound_exporter_host:+-unbound.host $unbound_exporter_host} \
        ${unbound_exporter_key:+-unbound.key $unbound_exporter_key} \
-       ${unbound_exporter_bind:+-web.listen-address $unbound_exporter_bin}
-       ${unbound_exporter_path:+-web.telemetry-patch $unbound_exporter_path}
+       ${unbound_exporter_bind:+-web.listen-adress $unbound_exporter_bind} \
+       ${unbound_exporter_path:+-web.telemetry-patch $unbound_exporter_path} \
        ${unbound_exporter_args}"
```
Comment 1 Athanasios Douitsis 2023-01-16 02:37:57 UTC
Hello and happy new year,

Thank you very much for the patch and my apologies for the delayed response. I'll try to incorporate it in the next few days. 

Kind regards,
Athanasios
Comment 2 Xin LI freebsd_committer freebsd_triage 2023-01-16 22:52:01 UTC
Happy new year!  This is a "me too" as I'm hitting this recently and fixed it locally (and can confirm that the proposed patch will fix it, I have the exactly same change locally).  Please let us know if you are happy with the change :)
Comment 3 Athanasios Douitsis 2023-01-16 23:02:04 UTC
Hello folks, happy new year again!

By any chance, would any of you folks be willing to take over the port maintenance please?

Kind regards,
Athanasios
Comment 4 Lutz Donnerhacke freebsd_committer freebsd_triage 2023-01-19 08:31:42 UTC
(In reply to Athanasios Douitsis from comment #3)
Yep. Could do.
Comment 5 Athanasios Douitsis 2023-01-19 10:45:27 UTC
Okay, thanks Lutz, that's awesome. How do I make you the maintainer please?
Comment 6 Dave Hayes 2023-04-12 20:53:05 UTC
--- unbound_exporter.stock	2023-04-12 13:47:10.081266000 -0700
+++ unbound_exporter	2023-04-12 13:49:44.875511000 -0700
@@ -44,7 +44,7 @@
 	${unbound_exporter_cert:+-unbound.cert $unbound_exporter_cert} \
 	${unbound_exporter_host:+-unbound.host $unbound_exporter_host} \
 	${unbound_exporter_key:+-unbound.key $unbound_exporter_key} \
-	${unbound_exporter_bind:+-web.listen-adress $unbound_exporter_bin}
+	${unbound_exporter_bind:+-web.listen-address $unbound_exporter_bind}
 	${unbound_exporter_path:+-web.telemetry-patch $unbound_exporter_path}
 	${unbound_exporter_args}"

There's a couple of issues on that line, not just one. Any news on getting this patch committed?
Comment 7 Mark Linimon freebsd_committer freebsd_triage 2023-08-22 20:28:35 UTC
With bugmeister hat, reassign to committer/volunteer.
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-03-24 17:37:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1133b74a3687e4e06df12c7a015fde15f0d41134

commit 1133b74a3687e4e06df12c7a015fde15f0d41134
Author:     Xin LI <delphij@FreeBSD.org>
AuthorDate: 2024-03-04 06:30:56 +0000
Commit:     Xin LI <delphij@FreeBSD.org>
CommitDate: 2024-03-24 17:34:51 +0000

    net-mgmt/unbound_exporter: upgrade to 0.4.6.

    PR:             ports/277467, ports/270442, ports/268852
    Approved by:    maintainer timeout

 net-mgmt/unbound_exporter/Makefile                 | 28 ++++++---
 net-mgmt/unbound_exporter/distinfo                 | 32 +++++++---
 .../unbound_exporter/files/patch-go.mod (gone)     | 31 ----------
 .../unbound_exporter/files/patch-go.sum (gone)     | 11 ----
 .../files/patch-vendor_modules.txt (gone)          | 70 ----------------------
 .../unbound_exporter/files/unbound_exporter.in     |  4 +-
 6 files changed, 46 insertions(+), 130 deletions(-)