Bug 268932 - graphics/pngquant: enable OpenMP support
Summary: graphics/pngquant: enable OpenMP support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alex Kozlov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-13 15:15 UTC by Jan Beich
Modified: 2023-01-14 05:46 UTC (History)
0 users

See Also:
ak: maintainer-feedback+

Attachments
v1 (apply via "git am") (1.56 KB, patch)
2023-01-13 15:15 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2023-01-13 15:15:14 UTC 
Created attachment 239445 [details]
v1 (apply via "git am")

Note, OpenMP is enabled in pngquant package at least on Alpine, Arch, Fedora, Void.
Comment 1 Alex Kozlov freebsd_committer freebsd_triage 2023-01-13 19:40:29 UTC 
I remember some reports about problems with openmp with base clang in FreeBSD 11/12, perhaps it's better to add this option, but make it default only after 12.x EoL ?
Comment 2 Jan Beich freebsd_committer freebsd_triage 2023-01-13 22:49:04 UTC 
Bug 214877 predates libomp in lib/Makefile which appears since releng/11.3 (base 30c9ca9148bc8), releng/12.1 (base b5893f02214da) and releng/13.0 (base b0840a28f6f66) and predates devel/openmp removal (ports 69a54b62a91f).

FreeBSD < 12.2 has been EOL since 2021-01-31 (thus not supported by ports/ tree anymore) while testing 12.* is trivial via poudriere.

There should be no issues. Even if base lacks OpenMP support (e.g., 32-bit powerpc) it will bring lang/gcc via USES=compiler:gcc-c++11-lib.
Comment 3 Alex Kozlov freebsd_committer freebsd_triage 2023-01-13 22:54:11 UTC 
Ok. I will commit your prs shortly.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-01-14 05:45:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a722f5607582b5065442d3eefeed9538d359b144

commit a722f5607582b5065442d3eefeed9538d359b144
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-01-14 05:42:58 +0000
Commit:     Alex Kozlov <ak@FreeBSD.org>
CommitDate: 2023-01-14 05:42:58 +0000

    graphics/pngquant: enable openmp, unbundle libimagequant

    - Use graphics/libimagequant instead of bundled version [1]
    - Re-add OPENMP option, enable it by default [2]

    PR:     268931 [1]
    PR:     268932 [2]

 graphics/pngquant/Makefile | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)