Bug 268959 - security/step-certificates: update to 0.23.1
Summary: security/step-certificates: update to 0.23.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2023-01-14 19:30 UTC by Markus Wipp
Modified: 2023-01-23 12:21 UTC (History)
1 user (show)

See Also:

Attachments
git-patch (2.33 KB, patch)
2023-01-14 19:30 UTC, Markus Wipp 		mw: maintainer-approval+
Details | Diff
git patch new (2.33 KB, patch)
2023-01-16 18:20 UTC, Markus Wipp 		mw: maintainer-approval+
Details | Diff
git patch new 2 (2.19 KB, patch)
2023-01-17 18:56 UTC, Markus Wipp 		mw: maintainer-approval+
Details | Diff
git patch new 3 (5.33 KB, patch)
2023-01-20 19:52 UTC, Markus Wipp 		mw: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Wipp 2023-01-14 19:30:37 UTC 
Created attachment 239473 [details]
git-patch

Hello all, 

find attached the patch to update to newest version of step-certificates

Best regards
Markus
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-15 19:29:04 UTC 
^Triage: Simplifying title

^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.

Q/A: PORTREVISION should be removed


Thanks!
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-16 08:07:07 UTC 
There are errors. Also, why did you remove the WWW line from Makefile? It has to be there.

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%DOCSDIR%%/CONTRIBUTING.md
Error: Missing: %%DOCSDIR%%/GETTING_STARTED.md
Error: Missing: %%DOCSDIR%%/acme.md
Error: Missing: %%DOCSDIR%%/database.md
Error: Missing: %%DOCSDIR%%/defaults.md
Error: Missing: %%DOCSDIR%%/docker.md
Error: Missing: %%DOCSDIR%%/images/connect-with-mtls-2.png
Error: Missing: %%DOCSDIR%%/images/oidc1.png
Error: Missing: %%DOCSDIR%%/images/oidc2.png
Error: Missing: %%DOCSDIR%%/images/oidc3.png
Error: Missing: %%DOCSDIR%%/images/step-ca-2-legged.gif
Error: Missing: %%DOCSDIR%%/images/step-ca-3-legged.gif
Error: Missing: %%DOCSDIR%%/kms.md
Error: Missing: %%DOCSDIR%%/provisioners.md
Error: Missing: %%DOCSDIR%%/questions.md
Error: Missing: %%DOCSDIR%%/revocation.md
===> Error: Plist issues found.
*** Error code 1
Comment 3 Markus Wipp 2023-01-16 18:20:57 UTC 
Created attachment 239506 [details]
git patch new

reworked the patch. sorry for the trouble
Comment 4 Markus Wipp 2023-01-16 18:22:30 UTC 
(In reply to Fernando Apesteguía from comment #1)
removed it
Comment 5 Markus Wipp 2023-01-16 18:23:05 UTC 
(In reply to Fernando Apesteguía from comment #2)
WWW - line was shown by portlint -C, now during reworking the patch it was no longer showing this behavior. so WWW is in again
issue should be fixed now.
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-17 12:05:38 UTC 
This is the same patch as before :S
It removes the WWW line, etc...
Comment 7 Markus Wipp 2023-01-17 18:56:58 UTC 
Created attachment 239541 [details]
git patch new 2

sorry, somehow uploaded the old file again
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-18 10:59:35 UTC 
(In reply to Markus Wipp from comment #7)
*sigh*

This patch is not right. It does not address the problem in pkg-plist. *PLEASE*, *PLEASE*, check your patches and test the port *BEFORE* submission.
Comment 9 Markus Wipp 2023-01-20 19:52:57 UTC 
Created attachment 239616 [details]
git patch new 3

sorry 1000 times, I don't know why i missed this the last time.
should work now. ran it 3 times through poudriere now and it always succeded.
Comment 10 commit-hook freebsd_committer freebsd_triage 2023-01-23 12:21:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a5d8b4b18551f4b1727eaed8a074d7355e193e90

commit a5d8b4b18551f4b1727eaed8a074d7355e193e90
Author:     Markus Wipp <mw@wipp.bayern>
AuthorDate: 2023-01-21 16:16:36 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-01-23 12:16:48 +0000

    security/step-certificates: update to 0.23.1

    PR:             268959
    Reported by:    mw@wipp.bayern (maintainer)

 security/step-certificates/Makefile  | 10 ++++--
 security/step-certificates/distinfo  | 10 +++---
 security/step-certificates/pkg-plist | 59 +++++++++++++++++++++++++++---------
 3 files changed, 56 insertions(+), 23 deletions(-)
Comment 11 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-23 12:21:25 UTC 
Committed,

Thanks!