Bug 269105 - net-mgmt/nfs-exporter: broken on powerpc
Summary: net-mgmt/nfs-exporter: broken on powerpc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-22 21:56 UTC by Alan Somers
Modified: 2023-01-23 15:19 UTC (History)
1 user (show)

See Also:

Attachments
Mark the port as BROKEN on powerpc (892 bytes, patch)
2023-01-22 21:57 UTC, Alan Somers 		asomers: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2023-01-22 21:56:01 UTC 
An upstream library requires 64-bit atomics and therefore can't build on powerpc.  The port should be BROKEN on that arch.
Comment 1 Alan Somers freebsd_committer freebsd_triage 2023-01-22 21:57:13 UTC 
Created attachment 239647 [details]
Mark the port as BROKEN on powerpc

This patch should fix the problem, but I need a ports committer to approve it.
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2023-01-23 15:04:47 UTC 
I think it's better to use NOT_FOR_ARCHS in this case. Per [1] BROKEN is reserved for ports that currently do not compile, install, deinstall, or run correctly. Use it for ports where the problem is believed to be temporary.

you can use this instead:
NOT_FOR_ARCHS= powerpc
NOT_FOR_ARCHS_REASON_powerpc= needs 64-bit atomics

[1] https://docs.freebsd.org/en/books/porters-handbook/book/#dads-noinstall

Approved by: mikael
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-01-23 15:17:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a8806c5adaab9c0f0b109889d3de65192989461b

commit a8806c5adaab9c0f0b109889d3de65192989461b
Author:     Alan Somers <asomers@FreeBSD.org>
AuthorDate: 2023-01-22 21:54:10 +0000
Commit:     Alan Somers <asomers@FreeBSD.org>
CommitDate: 2023-01-23 15:15:55 +0000

    net-mgmt/nfs-exporter: disable on powerpc

    An upstream library requires 64-bit atomics and therefore can't build on
    powerpc.

    PR:             269105
    Approved by:    mikael (ports)
    Sponsored by:   Axcient

 net-mgmt/nfs-exporter/Makefile | 4 ++++
 1 file changed, 4 insertions(+)
Comment 4 Alan Somers freebsd_committer freebsd_triage 2023-01-23 15:19:09 UTC 
Thanks for the tip, Mikael!