Bug 269289 - [exp-run] Update default Go version to 1.20
Summary: [exp-run] Update default Go version to 1.20
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Port Management Team
URL: https://go.dev/doc/go1.20
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-02 14:01 UTC by Dmitri Goutnik
Modified: 2023-02-09 19:36 UTC (History)
1 user (show)

See Also:
dmgk: exp-run?

Attachments
go1.20.patch (480 bytes, patch)
2023-02-02 14:01 UTC, Dmitri Goutnik 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2023-02-02 14:01:39 UTC 
Created attachment 239862 [details]
go1.20.patch

go1.20 has been released, I'd like to request an exp-run to update the default Go version to 1.20.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-02-03 19:52:00 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b7dcaa6d32c949e194639977d7b89d1af5314c1f

commit b7dcaa6d32c949e194639977d7b89d1af5314c1f
Author:     Dmitri Goutnik <dmgk@FreeBSD.org>
AuthorDate: 2023-02-03 15:57:44 +0000
Commit:     Dmitri Goutnik <dmgk@FreeBSD.org>
CommitDate: 2023-02-03 18:09:11 +0000

    www/pydio-cells: Pin Go version to 1.19

    vendor/github.com/lucas-clemente/quic-go/internal/qtls/go120.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet.

    quic-go doesn't support go1.20 yet, keep building this port with go1.19
    for now.

    PR:             269289
    Reported by:    exp-run

 www/pydio-cells/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-02-03 19:52:01 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c3636dc5d9a66808e665755caa8f543dc6481896

commit c3636dc5d9a66808e665755caa8f543dc6481896
Author:     Dmitri Goutnik <dmgk@FreeBSD.org>
AuthorDate: 2023-02-03 15:53:02 +0000
Commit:     Dmitri Goutnik <dmgk@FreeBSD.org>
CommitDate: 2023-02-03 18:09:05 +0000

    net/storj: Pin Go version to 1.19

    vendor/github.com/lucas-clemente/quic-go/internal/qtls/go120.go:6:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet.

    quic-go doesn't support go1.20 yet, keep building this port with go1.19
    for now.

    PR:             269289
    Reported by:    exp-run

 net/storj/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-02-03 19:52:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e41e27b19194be93c1bad06a10dafc9211264960

commit e41e27b19194be93c1bad06a10dafc9211264960
Author:     Dmitri Goutnik <dmgk@FreeBSD.org>
AuthorDate: 2023-02-03 15:55:51 +0000
Commit:     Dmitri Goutnik <dmgk@FreeBSD.org>
CommitDate: 2023-02-03 18:09:08 +0000

    www/caddy: Pin Go version to 1.19

    vendor/github.com/lucas-clemente/quic-go/internal/qtls/go120.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet.

    quic-go doesn't support go1.20 yet, keep building this port with go1.19
    for now.

    PR:             269289
    Reported by:    exp-run

 www/caddy/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-02-03 19:52:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9bb7a77ba08d30edbffc8a956ca445bbafa8b31d

commit 9bb7a77ba08d30edbffc8a956ca445bbafa8b31d
Author:     Dmitri Goutnik <dmgk@FreeBSD.org>
AuthorDate: 2023-02-03 15:50:41 +0000
Commit:     Dmitri Goutnik <dmgk@FreeBSD.org>
CommitDate: 2023-02-03 18:09:02 +0000

    net-im/dendrite: Pin Go version to 1.19

    vendor/github.com/lucas-clemente/quic-go/internal/qtls/go120.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet.

    quic-go doesn't support go1.20 yet, keep building this port with go1.19
    for now.

    PR:             269289
    Reported by:    exp-run

 net-im/dendrite/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-02-03 19:52:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fe49bf2a8987602bafa1246f6084cfcd84c0e080

commit fe49bf2a8987602bafa1246f6084cfcd84c0e080
Author:     Dmitri Goutnik <dmgk@FreeBSD.org>
AuthorDate: 2023-02-03 15:44:50 +0000
Commit:     Dmitri Goutnik <dmgk@FreeBSD.org>
CommitDate: 2023-02-03 18:08:52 +0000

    dns/dnscrypt-proxy2: Pin Go version to 1.19

    vendor/github.com/lucas-clemente/quic-go/internal/qtls/go120.go:6:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet.

    quic-go doesn't support go1.20 yet, keep building this port with go1.19
    for now.

    PR:             269289
    Reported by:    exp-run

 dns/dnscrypt-proxy2/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-02-03 19:52:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a104d4542fd4ed8644df1eaabfd003065edceea0

commit a104d4542fd4ed8644df1eaabfd003065edceea0
Author:     Dmitri Goutnik <dmgk@FreeBSD.org>
AuthorDate: 2023-02-03 16:55:47 +0000
Commit:     Dmitri Goutnik <dmgk@FreeBSD.org>
CommitDate: 2023-02-03 18:09:14 +0000

    net/traefik: Pin Go version to 1.19

    vendor/github.com/lucas-clemente/quic-go/internal/qtls/go120.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet.

    quic-go doesn't support go1.20 yet, keep building this port with go1.19
    for now.

    PR:             269289
    Reported by:    exp-run

 net/traefik/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 Dmitri Goutnik freebsd_committer freebsd_triage 2023-02-03 19:58:07 UTC 
Thanks. These two failures doesn't seem to be caused by Go the version bump:

https://pkg-status.freebsd.org/package22/data/131amd64-default-foo/2023-02-02_20h05m12s/logs/mergestat-0.5.4_8.log

# github.com/libgit2/git2go/v33
vendor/github.com/libgit2/git2go/v33/Build_system_dynamic.go:12:3: error: "Invalid libgit2 version; this git2go supports libgit2 between v1.3.0 and v1.3.0"
# error "Invalid libgit2 version; this git2go supports libgit2 between v1.3.0 and v1.3.0"
  ^
1 error generated.

https://pkg-status.freebsd.org/package22/data/131amd64-default-foo/2023-02-02_20h05m12s/logs/fvwm3-1.0.5_3.log

===>  Building package for fvwm3-1.0.5_3
pkg-static: Unable to access file /wrkdirs/usr/ports/x11-wm/fvwm3/work/stage/usr/local/bin/FvwmPrompt:No such file or directory

This looks like a pkg-plist issue.
Comment 9 Antoine Brodin freebsd_committer freebsd_triage 2023-02-08 08:55:03 UTC 
The fvwm3 is related to the bump, if you look at the log:

checking for go... go
checking whether go version is >= 1.14.x (1.20)... no - version is: 1.20
Comment 10 commit-hook freebsd_committer freebsd_triage 2023-02-08 11:46:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3e12079bd176e79c358750425bdd479b8fcbe323

commit 3e12079bd176e79c358750425bdd479b8fcbe323
Author:     Dmitri Goutnik <dmgk@FreeBSD.org>
AuthorDate: 2023-02-08 11:39:20 +0000
Commit:     Dmitri Goutnik <dmgk@FreeBSD.org>
CommitDate: 2023-02-08 11:45:02 +0000

    x11-wm/fvwm3: Pin Go version to 1.19

    checking for go... go
    checking whether go version is >= 1.14.x (1.20)... no - version is: 1.20

    Configure script doesn't know about go1.20 yes, keep building this
    port with go1.19 for now.

    PR:             269289
    Reported by:    exp-run

 x11-wm/fvwm3/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2023-02-09 19:36:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3d2ef90d0f941012262285b93a854172a7dc3c79

commit 3d2ef90d0f941012262285b93a854172a7dc3c79
Author:     Dmitri Goutnik <dmgk@FreeBSD.org>
AuthorDate: 2023-02-09 19:30:56 +0000
Commit:     Dmitri Goutnik <dmgk@FreeBSD.org>
CommitDate: 2023-02-09 19:34:44 +0000

    Mk/bsd.default-versions.mk: Update GO_DEFAULT to 1.20

    PR:             269289
    Exp-run by:     antoine

 Mk/bsd.default-versions.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)