Bug 269303 - www/gitlab-pages: Remove custom post-fetch and do-install targets
Summary: www/gitlab-pages: Remove custom post-fetch and do-install targets
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-03 12:02 UTC by Dmitri Goutnik
Modified: 2023-02-03 15:02 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (swills)

Attachments
gitlab-pages.diff (1.76 KB, patch)
2023-02-03 12:02 UTC, Dmitri Goutnik 		dmgk: maintainer-approval?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer freebsd_triage 2023-02-03 12:02:14 UTC 
Created attachment 239875 [details]
gitlab-pages.diff

Remove custom targets, just pulling go.mk directly from gitlab.com is enough and targets provided by go.mk work fine here.

Builds OK in poudriere 131a.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-02-03 15:02:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f9ba0a00fccc399026105c4eb125ced955d40b47

commit f9ba0a00fccc399026105c4eb125ced955d40b47
Author:     Dmitri Goutnik <dmgk@freebsd.org>
AuthorDate: 2023-02-03 14:58:16 +0000
Commit:     Matthias Fechner <mfechner@FreeBSD.org>
CommitDate: 2023-02-03 14:58:16 +0000

    www/gitlab-pages: simplify Makefile

    Remove custom targets, just pulling go.mk directly from gitlab.com
    is enough and targets provided by go.mk work fine here.

    PR:             269303

 www/gitlab-pages/Makefile | 26 +++-----------------------
 1 file changed, 3 insertions(+), 23 deletions(-)
Comment 2 Matthias Fechner freebsd_committer freebsd_triage 2023-02-03 15:02:20 UTC 
Thank you!