Bug 269372 - lang/clover: enable on aarch64
Summary: lang/clover: enable on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2023-02-06 15:11 UTC by Jan Beich
Modified: 2023-12-01 08:23 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)


Attachments
v1 (apply via "git am") (1.65 KB, patch)
2023-02-06 15:11 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2023-02-06 15:11:11 UTC
Created attachment 239947 [details]
v1 (apply via "git am")

amdgpu.ko from drm-kmod is supported on non-x86 archs, and clover is already enabled on powerpc64.

Disclaimer: I don't have aarch64 hardware and currently can't test build via qemu-user-static.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2023-11-29 10:27:34 UTC
Ping
Comment 2 Ronald Klop freebsd_committer freebsd_triage 2023-11-29 10:37:30 UTC
(In reply to Jan Beich from comment #1)
I'm trying to build this now on my RPI4.
NB: the patch didn't apply cleanly, but made the changes by hand. No problem.
And I'm not involved with X11. I can just compile test this.
Comment 3 Emmanuel Vadot freebsd_committer freebsd_triage 2023-11-29 10:44:21 UTC
Both drm-510-kmod and drm-515-kmod aren't supported on aarch64 atm so there is no need for this.
Comment 4 Emmanuel Vadot freebsd_committer freebsd_triage 2023-11-29 10:45:07 UTC
Sorry, drm-510-kmod is, I'm ok if this was tested.
Comment 5 Ronald Klop freebsd_committer freebsd_triage 2023-12-01 07:42:41 UTC
Hi. This compiles fine on aarch64.

Only thing I encountered is that graphics/mesa-devel has a plist error if you run poudriere with stage-qa. I assume this also happens for other ARCHS than aarch64.
The port lang/clover (which this PR is actually about) builds without any errors in stage-qa on aarch64.

Shall I commit your patch or are you able to do that yourself as you have a @freebsd.org email?

[01:17:08] ===========================================================================
[01:17:08] ====> Running Q/A tests (stage-qa)
[01:17:21] Warning: you might not need LIB_DEPENDS on libOpenGL.so
[01:17:21] Warning: you might not need LIB_DEPENDS on libunwind.so
[01:17:21] Warning: you might not need LIB_DEPENDS on libLLVMSPIRVLib.so.15
[01:17:21] ====> Checking for pkg-plist issues (check-plist)
[01:17:21] ===> Parsing plist
[01:17:22] ===> Checking for items in STAGEDIR missing from pkg-plist
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/armada-drm_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/exynos_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/hdlcd_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/hx8357d_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/ili9225_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/ili9341_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/imx-dcss_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/imx-drm_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/imx-lcdif_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/ingenic-drm_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/kirin_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/komeda_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/mali-dp_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/mcde_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/mediatek_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/meson_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/mi0283qt_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/mxsfb-drm_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/pl111_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/rcar-du_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/repaper_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/st7586_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/st7735r_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/stm_dri.so
[01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/sun4i-drm_dri.so
[01:17:22] Error: Orphaned: lib/gallium-pipe%%SUFFIX%%/pipe_kmsro.so
[01:17:22] ===> Checking for items in pkg-plist which are not in STAGEDIR
[01:17:22] ===> Error: Plist issues found.
[01:17:22] *** Error code 1
[01:17:22] 
[01:17:22] Stop.
[01:17:22] make: stopped in /usr/ports/graphics/mesa-devel
[01:17:22] =>> Error: check-plist failures detected
[01:34:17] =>> Cleaning up wrkdir
[01:34:18] ===>  Cleaning for mesa-devel-23.3.b.389
[01:34:22] build of graphics/mesa-devel | mesa-devel-23.3.b.389 ended at Thu Nov 30 21:50:21 UTC 2023
[01:34:22] build time: 01:33:35
[01:34:22] !!! build failure encountered !!!
Comment 6 Emmanuel Vadot freebsd_committer freebsd_triage 2023-12-01 08:08:08 UTC
Compile is one thing, it probably works but I'd like to have someone to confirm before commiting this.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-12-01 08:09:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b3e7e5941966af8d1bf87ec2ee537865acbf7c0e

commit b3e7e5941966af8d1bf87ec2ee537865acbf7c0e
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-02-06 15:04:48 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-12-01 08:08:43 +0000

    lang/clover: enable on aarch64

    drm-510-kmod (amdgpu.ko) provides AMD GPU support on aarch64.

    PR:             269372
    Tested by:      ronald
    Approved by:    manu

 graphics/mesa-devel/Makefile | 2 --
 lang/clover/Makefile         | 4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)
Comment 8 Jan Beich freebsd_committer freebsd_triage 2023-12-01 08:19:04 UTC
> graphics/mesa-devel has a plist error
[...]
> [01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/armada-drm_dri.so
> [01:17:22] Error: Orphaned: lib/dri%%SUFFIX%%/exynos_dri.so
[...]

I'm not sure why mesa-dri isn't affected and would prefer to avoid adding tons of @comment lines.

See also
https://gitlab.freedesktop.org/mesa/mesa/-/blob/mesa-23.1.8/src/gallium/targets/dri/meson.build#L70-94
https://gitlab.freedesktop.org/mesa/mesa/-/blob/mesa-23.1.8/meson.build#L196
https://gitlab.freedesktop.org/mesa/mesa/-/commit/8cfc17bdda31
Comment 9 Jan Beich freebsd_committer freebsd_triage 2023-12-01 08:21:49 UTC
(In reply to Emmanuel Vadot from comment #6)
Doh, I didn't notice this before landing (riding on comment 4 approval). Do you want me to revert?
Comment 10 Emmanuel Vadot freebsd_committer freebsd_triage 2023-12-01 08:23:00 UTC
(In reply to Jan Beich from comment #9)

It's commited so leave it that way, if someone complain that it doesn't work I'll just revert this.