Bug 269397 - cad/k40-whisperer: Replace reference to PY_PILLOW with its value
Summary: cad/k40-whisperer: Replace reference to PY_PILLOW with its value
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yasuhiro Kimura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-08 07:09 UTC by Yasuhiro Kimura
Modified: 2023-02-10 05:58 UTC (History)
0 users

See Also:
0mp: maintainer-feedback+

Attachments
Patch file (981 bytes, patch)
2023-02-08 07:09 UTC, Yasuhiro Kimura 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2023-02-08 07:09:38 UTC 
Created attachment 239983 [details]
Patch file

Since this port works with Python 3.6 and later, the value of PY_PILLOW doesn't change. So replace reference to it with its value.

This is preparation to remove PY_PILLOW.
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2023-02-08 07:41:30 UTC 
Thanks for the patch. Feel free to commit!

BTW, I think this kind of changes fall under the ports manager blanket as “framework modernization”. :)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-02-10 05:52:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e9a1fa9fa1431e16ae722305a5a6b740250a402d

commit e9a1fa9fa1431e16ae722305a5a6b740250a402d
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2023-02-08 02:11:19 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2023-02-10 05:50:33 +0000

    cad/k40-whisperer: Replace reference to PY_PILLOW with its value

    Since this port works with Python 3.6 and later, the value of
    PY_PILLOW doesn't change. So replace reference to it with its value.

    PR:             269397
    Approved by:    maintainer

 cad/k40-whisperer/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)