Bug 269412 - comms/py-fritzconnection: update to 1.11.0 for updates and bugfixes
Summary: comms/py-fritzconnection: update to 1.11.0 for updates and bugfixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL: https://github.com/kbr/fritzconnectio...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-08 14:44 UTC by Michael Büker
Modified: 2023-02-12 12:24 UTC (History)
2 users (show)

See Also:


Attachments
portstree patch for update to 1.11.0 (1.99 KB, patch)
2023-02-08 14:44 UTC, Michael Büker
freebsd: maintainer-approval+
Details | Diff
portstree patch for update to 1.11.0 (963 bytes, patch)
2023-02-08 19:44 UTC, Michael Büker
freebsd: maintainer-approval+
Details | Diff
portstree patch for update to 1.11.0 (1.38 KB, patch)
2023-02-11 13:49 UTC, Michael Büker
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Büker 2023-02-08 14:44:12 UTC
Created attachment 239998 [details]
portstree patch for update to 1.11.0

Changes since last ports version 1.10.2:

- upper limit for dependency pinning removed to support installation on more recent environments.
- New `FritzAuthorizationError` raised on calling actions without the proper permissions (#170)
- Faster cache validation.
- New property `updatecheck` allows access to router attributes without permissions (#168)
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2023-02-08 19:07:14 UTC
is the diff against textproc/py-sphinx-autodoc-typehints intentional?
Comment 2 Michael Büker 2023-02-08 19:44:53 UTC
Created attachment 240003 [details]
portstree patch for update to 1.11.0

It is not, I'm sorry. Thanks for pointing out my mistake, I've corrected the patch.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2023-02-10 14:58:33 UTC
Hello,

USE_PYTHON= pytest include automatic test dependencies and test target

You can simplify and modernize Makefile:

Remove TEST_DEPENDS:
-TEST_DEPENDS=  ${PYTHON_PKGNAMEPREFIX}pytest>=0:devel/py-pytest@${PY_FLAVOR}

Remove do-test target:
-do-test:
-       @cd ${WRKSRC} && ${PYTHON_CMD} -m pytest

Add pytest to USE_PYTHON:
+USE_PYTHON=    autoplist distutils pytest

Could you check it?
Comment 4 Michael Büker 2023-02-11 13:49:59 UTC
Created attachment 240087 [details]
portstree patch for update to 1.11.0

Thank you! This seems to work well: Tests run as expected with "make test" with the suggested moditications.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-02-12 12:23:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5e8c80dedee23b5eb974c15795dcb16a0e3fb336

commit 5e8c80dedee23b5eb974c15795dcb16a0e3fb336
Author:     Michael Büker <freebsd@michael-bueker.de>
AuthorDate: 2023-02-12 12:21:45 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-02-12 12:21:45 +0000

    comms/py-fritzconnection: Update to 1.11.0

    ChangeLog:      https://github.com/kbr/fritzconnection/compare/1.10.2...1.11.0
    PR:             269412

 comms/py-fritzconnection/Makefile | 10 +++-------
 comms/py-fritzconnection/distinfo |  6 +++---
 2 files changed, 6 insertions(+), 10 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2023-02-12 12:24:31 UTC
Committed, thanks!