Bug 269504 - net-p2p/transmission-cli - New version available 4.0.3
Summary: net-p2p/transmission-cli - New version available 4.0.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Robert Clausecker
URL:
Keywords:
: 272240 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-02-12 00:03 UTC by Dutchman01
Modified: 2023-09-23 15:56 UTC (History)
21 users (show)

See Also:
mondo.debater_0q: maintainer-feedback+


Attachments
Proposed patch (10.76 KB, patch)
2023-06-29 04:17 UTC, Rafe
no flags Details | Diff
proposed updated patch (10.87 KB, patch)
2023-07-01 02:32 UTC, Rafe
no flags Details | Diff
Proposed patch to update port to 4.0.3 and modernize it (42.18 KB, patch)
2023-07-07 04:11 UTC, Rafe
no flags Details | Diff
Proposed patch to update port to 4.0.3 and modernize it (36.40 KB, patch)
2023-07-07 14:30 UTC, Rafe
no flags Details | Diff
Revised patch (41.73 KB, patch)
2023-08-08 07:25 UTC, Rafe
no flags Details | Diff
Complete patch to 4.0.4 (41.62 KB, patch)
2023-08-29 13:04 UTC, Rafe
no flags Details | Diff
git patch to 4.0.4 (46.08 KB, patch)
2023-08-29 16:05 UTC, Rafe
fuz: maintainer-approval+
Details | Diff
poudriere build log: transmission-cli 4.0.4 (229.06 KB, text/plain)
2023-08-30 16:39 UTC, Rafe
no flags Details
poudriere build log: transmission-daemon 4.0.4 (234.21 KB, text/plain)
2023-08-30 16:43 UTC, Rafe
no flags Details
poudriere build log: transmission-full 4.0.4 (536.46 KB, text/plain)
2023-08-30 16:43 UTC, Rafe
no flags Details
poudriere build log: transmission-gtk 4.0.4 (370.69 KB, text/plain)
2023-08-30 16:44 UTC, Rafe
no flags Details
poudriere build log: transmission-qt 4.0.4 (360.33 KB, text/plain)
2023-08-30 16:44 UTC, Rafe
no flags Details
poudriere build log: transmission-utils 4.0.4 (227.43 KB, text/plain)
2023-08-30 16:44 UTC, Rafe
no flags Details
Updated patch w/ revisions to MOVED & net-p2p/Makefile (53.27 KB, patch)
2023-09-01 08:12 UTC, Rafe
mondo.debater_0q: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dutchman01 2023-02-12 00:03:39 UTC
Hi a new transmission daemon/cli has been released

please see: https://github.com/transmission/transmission/releases/tag/4.0.0

and https://transmissionbt.com/

Can you please upgrade the port.

Regards
Comment 1 Alexandre C. Guimarães freebsd_committer freebsd_triage 2023-02-12 00:34:46 UTC
Hi,

The update is in WIP state. This port is particularly time consuming and I have had not too much free time recently. Hopefully I finish it this week.

Thank you.
Comment 2 Artyom Davidov 2023-02-20 21:45:07 UTC
FYI transmission 4.0.1 is scheduled to be released on 22 Feb 2023.
It contains a number of bug-fixes for the issues discovered after 4.0.0 was released.
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2023-03-05 14:08:23 UTC
Moin moin 

I'll take a look at updating it to 4.0.1.


mfg Tobias
Comment 4 Dutchman01 2023-03-17 02:56:24 UTC
Any update on it Tobias?
Comment 5 Jerry Jacobs 2023-03-19 09:05:41 UTC
Seems 4.0.2 is out since a few days ago. https://github.com/transmission/transmission/releases/tag/4.0.2
Comment 6 Artyom Davidov 2023-03-24 17:59:16 UTC
If someone will port transmission 4.0.x to FreeBSD I guess it will be better to keep tranmission 3.x as a separate port for some time because even the latest 4.0.2 have some issues.
Comment 7 Jerry Jacobs 2023-03-24 20:27:17 UTC
(In reply to Artyom Davidov from comment #6)

I totally agree to have two versions of the transmission-* ports, because version 3 and 4 are a major update and can cause problems (also when trying to upgrade). I have not tried to upgrade a version 3 instance to version 4, but runned them separately. I could not find a migration guide from 3 to 4.
Comment 8 Artyom Davidov 2023-03-24 22:11:21 UTC
(In reply to Jerry Jacobs from comment #7)
There is no upgrade guide just because it was supposed to be in-place upgrade.
So you just remove transmission 3, install transmission 4, point it to the previous version's directory structure and configuration file(s) and you're good to go.
But there were some issues that should be fixed in 4.0.2 and as a fail-safe measure it'll be better to make a backup of the "torrents" folder at least, to be able to safely fallback to transmission 3 in case of any problems with transmission 4.
Comment 9 luna 2023-03-25 04:17:45 UTC
I can see several issues with this position. First, the 3.x branch won't be receiving further updates. In general, the ports tree does not provide ports for software that upstream has abandoned. Second, foregoing or postponing updating ports because they have known bugs will mean nothing ever gets updated; all software has bugs. The most useful things one can do at this point are either to be patient or provide a patch for the port.
Comment 10 Dutchman01 2023-04-01 09:55:24 UTC
(In reply to Alexandre C. Guimarães from comment #1)

is there anything we can test already, we are so many weeks later now.

Regards
Comment 11 jaskerx 2023-05-01 17:35:04 UTC
Is there any progress being made here? Might we get an ETA, or an update as to what's going on?
Comment 12 Dutchman01 2023-06-15 21:24:54 UTC
And again 7 weeks passed away without news or ETA
i lost hope we see a port upgrade soon.
Comment 13 Rafe 2023-06-29 04:17:03 UTC
Created attachment 243068 [details]
Proposed patch

This patch refashions net-p2p/transmission as a basic release of Transmission 4.0.3. This port's structure is overly complicated currently, and it appears cleanest to move away from numerous slave ports.

I leave it to others to add GTK and QT flavors.
Comment 14 Jerry Jacobs 2023-06-29 20:43:48 UTC
The proposed patch looks much cleaner what I can judge. In my opinion splitting the GUI builds to different independent ports is much better as for servers most people don't use a gui and it depends on a ton of GUI framework bytes idle on the storage. But the downside is multiple ports must be maintained, but its almost copy-pasta then. Thanks for your work @Rafe.
Comment 15 Rafe 2023-06-30 22:35:46 UTC
Comment on attachment 243068 [details]
Proposed patch

>From d34379c9b200e324fe4dbb93333cee77c1598e83 Mon Sep 17 00:00:00 2001
>From: md0q <mondo.debater_0q@icloud.com>
>Date: Thu, 29 Jun 2023 06:03:23 +0200
>Subject: [PATCH]  net-p2p/transmission: Updated to provide a basic CLI version
> of the post recent release (4.0.3)
>
> PR:	269504 - New version available 4.0.0
>---
> net-p2p/transmission/Makefile              | 81 ++++++++++++++--------
> net-p2p/transmission/distinfo              | 15 ++++
> net-p2p/transmission/files/transmission.in | 70 +++++++++++++++++++
> net-p2p/transmission/pkg-descr             |  1 +
> net-p2p/transmission/pkg-plist             | 56 +++++++++++++++
> 5 files changed, 196 insertions(+), 27 deletions(-)
> create mode 100644 net-p2p/transmission/distinfo
> create mode 100644 net-p2p/transmission/files/transmission.in
> create mode 100644 net-p2p/transmission/pkg-plist
>
>diff --git a/net-p2p/transmission/Makefile b/net-p2p/transmission/Makefile
>index 0ac76799b609..505ba4ffc0da 100644
>--- a/net-p2p/transmission/Makefile
>+++ b/net-p2p/transmission/Makefile
>@@ -1,29 +1,56 @@
>-PORTNAME=	transmission
>-DISTVERSION=	3.00
>-PORTREVISION=	1
>-CATEGORIES=	net-p2p
>-
>-MAINTAINER=	rigoletto@FreeBSD.org
>-COMMENT=	Meta-port for Transmission BitTorrent client
>-WWW=		https://www.transmissionbt.com/
>-
>-USES=		metaport
>-
>-OPTIONS_DEFINE=		CLI DAEMON GTK QT UTILS WEB
>-OPTIONS_DEFAULT=	${OPTIONS_DEFINE}
>-
>-CLI_DESC=		Command line version
>-DAEMON_DESC=		Daemon version
>-GTK_DESC=		GTK version
>-QT_DESC=		Qt version
>-UTILS_DESC=		Command line tools
>-WEB_DESC=		Web client
>-
>-CLI_RUN_DEPENDS=	transmission-cli:net-p2p/transmission-cli
>-DAEMON_RUN_DEPENDS=	transmission-daemon:net-p2p/transmission-daemon
>-GTK_RUN_DEPENDS=	transmission-gtk:net-p2p/transmission-gtk
>-QT_RUN_DEPENDS=		transmission-qt:net-p2p/transmission-qt
>-UTILS_RUN_DEPENDS=	transmission-create:net-p2p/transmission-utils
>-WEB_RUN_DEPENDS=	${DATADIR}/web/index.html:www/transmission-web
>+PORTNAME=       transmission
>+DISTVERSION=    4.0.3
>+PORTREVISION=   0
>+CATEGORIES=     net-p2p
>+
>+MAINTAINER=     mondo.debater_0q@icloud.com
>+COMMENT=        Transmission BitTorrent client
>+WWW=            https://www.transmissionbt.com/
>+LICENSE=	GPLv3+
>+
>+USES=		cpe
>+
>+CPE_VENDOR=	transmissionbt
>+CPE_PRODUCT=	transmission
>+
>+USE_GITHUB=	YES
>+GH_TUPLE=	google:googletest:af29db7:googletest/third-party/googletest \
>+		transmission:libutp:c95738b:transmission/third-party/libutp \
>+		transmission:fast_float:6624977:fast_float/third-party/fast_float \
>+		transmission:utfcpp:b85efd6:utfcpp/third-party/utfcpp \
>+		transmission:fmt:c4ee726:fmt/third-party/fmt \
>+		transmission:wide-integer:4de0b52:wideinteger/third-party/wide-integer \
>+
>+USERS=		transmission
>+GROUPS=		transmission
>+USE_RC_SUBR=	transmission
>+
>+LIB_DEPENDS=	libcurl.so:ftp/curl \
>+                libb64.so:converters/libb64 \
>+                libevent.so:devel/libevent \
>+		libfmt.so:devel/libfmt \
>+		libpsl.so:dns/libpsl \
>+                libdht.so:devel/jech-dht \
>+		libdeflate.so:archivers/libdeflate \
>+		libnatpmp.so:net/libnatpmp \
>+                libminiupnpc.so:net/miniupnpc \
>+
>+USES=		cmake iconv libtool localbase pkgconfig ssl
>+
>+CMAKE_OFF=	ENABLE_MAC WITH_SYSTEMD USE_SYSTEM_UTP REBUILD_WEB
>+CMAKE_ON=	ENABLE_CLI USE_SYSTEM_EVENT2 USE_SYSTEM_DEFLATE USE_SYSTEM_DHT USE_SYSTEM_MINIUPNPC USE_SYSTEM_NATPMP USE_SYSTEM_PSL USE_SYSTEM_B64 
>+CMAKE_ARGS=    -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_C_STANDARD_INCLUDE_DIRECTORIES=/usr/local/include -DCMAKE_CXX_STANDARD_INCLUDE_DIRECTORIES=/usr/local/include 
>+
>+OPTIONS_DEFINE=	DOCS NLS TESTS UTILS 
>+OPTIONS_DEFAULT= TESTS UTILS 
>+TESTS_DESC= 	Build unit tests
>+UTILS_DESC=	Build utilities (create, edit, show)
>+
>+NLS_CMAKE_BOOL=	ENABLE_NLS
>+NLS_USES=	gettext-runtime:run
>+
>+DOCS_CMAKE_ON=	-DCMAKE_INSTALL_DOCDIR=${DOCSDIR}
>+
>+TESTS_CMAKE_BOOL=	ENABLE_TESTS
> 
> .include <bsd.port.mk>
>diff --git a/net-p2p/transmission/distinfo b/net-p2p/transmission/distinfo
>new file mode 100644
>index 000000000000..637f3e0e741d
>--- /dev/null
>+++ b/net-p2p/transmission/distinfo
>@@ -0,0 +1,15 @@
>+TIMESTAMP = 1688004984
>+SHA256 (transmission-transmission-4.0.3_GH0.tar.gz) = f6184a199c9878695cec020fab7cc9859309496e96f218a7753fd501434c632c
>+SIZE (transmission-transmission-4.0.3_GH0.tar.gz) = 9062467
>+SHA256 (google-googletest-af29db7_GH0.tar.gz) = cebd59f4dd7380870c4cbc57f75bd4453d84c68847fee020c95019b2841ae7a2
>+SIZE (google-googletest-af29db7_GH0.tar.gz) = 841006
>+SHA256 (transmission-libutp-c95738b_GH0.tar.gz) = 0cf69bccedab159c7d1b52cbb6f7085ef567ed5bf46d541f7d2074130d181ff1
>+SIZE (transmission-libutp-c95738b_GH0.tar.gz) = 59671
>+SHA256 (transmission-fast_float-6624977_GH0.tar.gz) = a7fed3253e8604ad0b3c0649f7b99e004f61bf0b82096f43edbb597f9a9b4dc3
>+SIZE (transmission-fast_float-6624977_GH0.tar.gz) = 76763
>+SHA256 (transmission-utfcpp-b85efd6_GH0.tar.gz) = 98c7f02180c92a6b5fa90bbf157c3f441fcf47565c10948d221de3097893507a
>+SIZE (transmission-utfcpp-b85efd6_GH0.tar.gz) = 27376
>+SHA256 (transmission-fmt-c4ee726_GH0.tar.gz) = 05ba66b0a9ed040e5cfb07e845a0aa61fdbbb9a0cbd22a1860a303e8cbf343e4
>+SIZE (transmission-fmt-c4ee726_GH0.tar.gz) = 833672
>+SHA256 (transmission-wide-integer-4de0b52_GH0.tar.gz) = 8754e29f002ba78228675ad95b7eb4d828e23c7a4ec227815fe8a2238c8111eb
>+SIZE (transmission-wide-integer-4de0b52_GH0.tar.gz) = 124910
>diff --git a/net-p2p/transmission/files/transmission.in b/net-p2p/transmission/files/transmission.in
>new file mode 100644
>index 000000000000..6bbd39ba7830
>--- /dev/null
>+++ b/net-p2p/transmission/files/transmission.in
>@@ -0,0 +1,70 @@
>+#!/bin/sh
>+
>+# PROVIDE: transmission
>+# REQUIRE: DAEMON
>+# KEYWORD: shutdown
>+#
>+# Add the following lines to /etc/rc.conf to enable this service:
>+#
>+# transmission_enable:	     Set to NO by default. Set it to YES to enable it.
>+# transmission_watch_dir:    Directory for torrent files to download
>+#			     automatically. Off by default unless you add
>+#			     a path.
>+# transmission_conf_dir:     Directory where transmission configuration
>+#			     data is stored.
>+#			     Default: %%PREFIX%%/etc/transmission/home
>+# transmission_download_dir: Directory to store downloaded data.
>+#			     Default: %%PREFIX%%/etc/transmission/home/Downloads
>+# transmission_user:	     The user account transmission daemon runs as what
>+#			     you want it to be. It uses 'transmission' user by
>+#			     default.
>+# transmission_web_home:     Use alternative directory for the web interface
>+#			     files, such as javascript, html and graphics.
>+# transmission_chown:	     By default, transmission checks and fixes the
>+#			     permissions for its home directory.  If this
>+#			     causes problems, set this variable to no.
>+#
>+
>+. /etc/rc.subr
>+
>+name=transmission
>+rcvar=transmission_enable
>+
>+load_rc_config $name
>+
>+: ${transmission_enable:=NO}
>+: ${transmission_conf_dir=%%PREFIX%%/etc/transmission/home}
>+: ${transmission_download_dir=%%PREFIX%%/etc/transmission/home/Downloads}
>+: ${transmission_user:=transmission}
>+transmission_group=${transmission_group:-$transmission_user}
>+: ${transmission_chown:=yes}
>+
>+command=%%PREFIX%%/bin/transmission-daemon
>+pidfile=/var/run/transmission/daemon.pid
>+extra_commands=reload
>+start_precmd=transmission_prestart
>+
>+transmission_flags=" \
>+	${transmission_watch_dir:+-c ${transmission_watch_dir}} \
>+	${transmission_conf_dir:+-g ${transmission_conf_dir}} \
>+	${transmission_download_dir:+-w ${transmission_download_dir}} \
>+	${pidfile:+-x $pidfile} \
>+	${transmission_flags}"
>+
>+transmission_prestart()
>+{
>+	install -d -o $transmission_user ${pidfile%/*}
>+	if checkyesno transmission_chown; then
>+		mkdir -p $transmission_conf_dir $transmission_download_dir
>+		chown $transmission_user:$transmission_group $transmission_download_dir
>+		chown -R $transmission_user:$transmission_group $transmission_conf_dir
>+		chgrp $transmission_group $transmission_conf_dir
>+		chmod 750 $transmission_conf_dir
>+	fi
>+	if [ -n "$transmission_web_home" ]; then
>+		TRANSMISSION_WEB_HOME=$transmission_web_home
>+		export TRANSMISSION_WEB_HOME
>+	fi
>+}
>+
>+run_rc_command $1
>diff --git a/net-p2p/transmission/pkg-descr b/net-p2p/transmission/pkg-descr
>index 06d951f08f52..5af1fdb65073 100644
>--- a/net-p2p/transmission/pkg-descr
>+++ b/net-p2p/transmission/pkg-descr
>@@ -3,3 +3,4 @@ powerful BitTorrent client. Its simple, intuitive interface is designed
> to integrate tightly with whatever computing environment you choose to
> use. Transmission strikes a balance between providing useful functionality
> without feature bloat. Furthermore, it is free for anyone to use or modify.
>+
>diff --git a/net-p2p/transmission/pkg-plist b/net-p2p/transmission/pkg-plist
>new file mode 100644
>index 000000000000..81a36ca4e6b3
>--- /dev/null
>+++ b/net-p2p/transmission/pkg-plist
>@@ -0,0 +1,56 @@
>+bin/transmission-cli
>+bin/transmission-create
>+bin/transmission-daemon
>+bin/transmission-edit
>+bin/transmission-remote
>+bin/transmission-show
>+%%PORTDOCS%%%%DOCSDIR%%/AUTHORS
>+%%PORTDOCS%%%%DOCSDIR%%/COPYING
>+%%PORTDOCS%%%%DOCSDIR%%/README.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.42-and-older.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.50.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.51.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.52.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.60.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.61.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.70.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.71.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.72.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.73.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.74.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.75.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.76.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.77.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.80.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.81.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.82.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.83.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.84.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.90.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.91.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.92.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.93.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-2.94.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-3.00.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-4.0.0-beta-1.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-4.0.0-beta-2.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-4.0.0-beta-3.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-4.0.0.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-4.0.1.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-4.0.2.md
>+%%PORTDOCS%%%%DOCSDIR%%/news/news-4.0.3.md
>+%%PORTDOCS%%%%DOCSDIR%%/rpc-spec.md
>+%%PORTDOCS%%%%DOCSDIR%%/send-email-when-torrent-done.sh
>+share/man/man1/transmission-cli.1.gz
>+share/man/man1/transmission-create.1.gz
>+share/man/man1/transmission-daemon.1.gz
>+share/man/man1/transmission-edit.1.gz
>+share/man/man1/transmission-remote.1.gz
>+share/man/man1/transmission-show.1.gz
>+%%DATADIR%%/public_html/images/favicon.ico
>+%%DATADIR%%/public_html/images/favicon.png
>+%%DATADIR%%/public_html/images/webclip-icon.png
>+%%DATADIR%%/public_html/index.html
>+%%DATADIR%%/public_html/transmission-app.js
>+%%DATADIR%%/public_html/transmission-app.js.LICENSE.txt
>-- 
>2.41.0
>
Comment 16 Rafe 2023-07-01 02:32:27 UTC
Created attachment 243087 [details]
proposed updated patch
Comment 17 Rafe 2023-07-07 04:11:30 UTC
Created attachment 243295 [details]
Proposed patch to update port to 4.0.3 and modernize it

Apologies for adding so many comments. I've updated the proposed patch for GUI builds and to modernize it:
-Flavors added for GTK3 and QT5
–Fix build issue for GTK3 (upstream PR accepted)
-Rationalize the port options menu in lieu of slave ports
-Conform man page placement to the hierarchy.

Port builds cleanly for all flavors under the proposed patch. I run headless, however, so further testing of the GUI flavors would be appreciated.

While I have labelled myself as port maintainer in the proposed patch, I have no pride in authorship. I do so merely because this port appears to otherwise be abandoned.
Comment 18 François Charlier 2023-07-07 09:02:50 UTC
cli flavor built & tested on 12.4-RELEASE

Works fine.


However I think the patch should not remove the net-p2p/transmission-remote-gui port which is not a flavor of the main transmission server/cli/gui.
Comment 19 Rafe 2023-07-07 14:30:53 UTC
Created attachment 243305 [details]
Proposed patch to update port to 4.0.3 and modernize it

Thanks for pointing this out; I didn't realize that was a separate port. I've reverted the deletion in the attached patch and submitted the patch for review. https://reviews.freebsd.org/D40910.
Comment 20 Rafe 2023-08-08 07:25:25 UTC
Created attachment 243953 [details]
Revised patch

Revised patch.
Comment 21 Rafe 2023-08-29 13:04:53 UTC
Created attachment 244441 [details]
Complete patch to 4.0.4

Updated patch to build 4.0.4
Comment 22 François Charlier 2023-08-29 15:08:16 UTC
Hi, this patch doesn't apply to the latest git tree.

Could you rebase your patch please (and ideally use git format-patch to generate the diff as mentioned in the porter's handbook [1] ) ?

[1] https://docs.freebsd.org/en/books/porters-handbook/upgrading/#git-diff
Comment 23 Rafe 2023-08-29 15:57:07 UTC
(In reply to François Charlier from comment #22)

Strange, I rebased right before I uploaded the patch to arc. I'll submit a new patch instead of the arc patch.
Comment 24 Rafe 2023-08-29 16:05:06 UTC
Created attachment 244444 [details]
git patch to 4.0.4
Comment 25 François Charlier 2023-08-29 17:20:06 UTC
(In reply to Rafe from comment #24)

Works for me (daemon flavor). Patch applies using `git apply …`. Builds and runs fine.
Comment 26 jaskerx 2023-08-29 17:35:31 UTC
Are we ever going to see version 4 hit the ports repo? I don't understand why  rigoletto passed the maintainership over to tcberner who has not made a peep in over six months. What is going on here?
Comment 27 Rafe 2023-08-30 15:31:01 UTC
Maintainer has failed to respond for five months. I am requesting a maintainer timeout.
Comment 28 Robert Clausecker freebsd_committer freebsd_triage 2023-08-30 15:45:59 UTC
Comment on attachment 244444 [details]
git patch to 4.0.4

Maintainer timeout.
Comment 29 Robert Clausecker freebsd_committer freebsd_triage 2023-08-30 15:46:56 UTC
Return to pool as tcberner does not seem to be working on this one.
Comment 30 Anton Saietskii 2023-08-30 16:23:29 UTC
(In reply to Rafe from comment #24)

I believe attaching poudriere build log would assist greatly in faster commit. Additionally, looks like ports/MOVED & ports/net/Makefile needs to be touched.
Comment 31 Rafe 2023-08-30 16:39:52 UTC
Created attachment 244475 [details]
poudriere build log: transmission-cli 4.0.4
Comment 32 Rafe 2023-08-30 16:43:10 UTC
Created attachment 244477 [details]
poudriere build log: transmission-daemon 4.0.4
Comment 33 Rafe 2023-08-30 16:43:36 UTC
Created attachment 244478 [details]
poudriere build log: transmission-full 4.0.4
Comment 34 Rafe 2023-08-30 16:44:10 UTC
Created attachment 244479 [details]
poudriere build log: transmission-gtk 4.0.4
Comment 35 Rafe 2023-08-30 16:44:36 UTC
Created attachment 244480 [details]
poudriere build log: transmission-qt 4.0.4
Comment 36 Rafe 2023-08-30 16:44:59 UTC
Created attachment 244481 [details]
poudriere build log: transmission-utils 4.0.4
Comment 37 Kurt Jaeger freebsd_committer freebsd_triage 2023-09-01 06:20:46 UTC
(In reply to Anton Saietskii from comment #30)
Attaching build logs is no longer recommended, as it bloats the bugzilla storage. If you ran a build, mentioning that it worked is sufficient.
Comment 38 Rafe 2023-09-01 08:12:14 UTC
Created attachment 244548 [details]
Updated patch w/ revisions to MOVED & net-p2p/Makefile
Comment 39 Rafe 2023-09-01 08:13:26 UTC
(In reply to Kurt Jaeger from comment #37)

Thank you, this is mentioned in the commit message, which is included in the updated patch.
Comment 40 Robert Clausecker freebsd_committer freebsd_triage 2023-09-01 10:01:33 UTC
(In reply to Kurt Jaeger from comment #37)

It would be great if we had some written guidelines for that.  Other committers seem to still request build logs.
Comment 41 Robert Clausecker freebsd_committer freebsd_triage 2023-09-06 00:50:50 UTC
To be committed with my next batch.
Comment 42 Tobias C. Berner freebsd_committer freebsd_triage 2023-09-06 17:22:49 UTC
(In reply to Robert Clausecker from comment #41)
Moin moin 

I'm not the maintainer of this port -- there seems to be some confusion. 
I had some WIP patch, that I failed to find time to finish with. 

Please feel free to update and take maintainership of this port as you will :)


mfg Tobias
Comment 43 commit-hook freebsd_committer freebsd_triage 2023-09-10 16:15:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e5731e2bf4e706904cae6131fc5e7fd32d6814c7

commit e5731e2bf4e706904cae6131fc5e7fd32d6814c7
Author:     Rafe <mondo.debater_0q@icloud.com>
AuthorDate: 2023-09-06 00:45:48 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-09-10 16:12:57 +0000

    net-p2p/libutp: update to g20230213

    In preparation of the following net-p2p/transmission update.
    The library must be updated in lockstep.

    PR:             269504
    Reported by:    dutchman01@quicknet.nl
    Approved by:    rigoletto, tcberner (maintainer timeout)
    Reviewed By:    fcharlier_ploup.net
    Differential Revision: https://reviews.freebsd.org/D40910

 net-p2p/libutp/Makefile                   | 17 ++++++++---------
 net-p2p/libutp/distinfo                   |  6 +++---
 net-p2p/libutp/files/patch-CMakeLists.txt | 30 ++++++++++++++++++++++--------
 net-p2p/libutp/pkg-plist (new)            | 10 ++++++++++
 4 files changed, 43 insertions(+), 20 deletions(-)
Comment 44 commit-hook freebsd_committer freebsd_triage 2023-09-10 16:15:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8da970ab75e1a1031d93ff8e1aa8e3ff71afef07

commit 8da970ab75e1a1031d93ff8e1aa8e3ff71afef07
Author:     Rafe <mondo.debater_0q@icloud.com>
AuthorDate: 2023-09-06 00:49:34 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-09-10 16:12:57 +0000

    net-p2p/transmission: Update 3.00 -> 4.0.4 & modernize port

    This turns previous slave-ports net-p2p/transmission-{cli,daemon,gtk,qt,utils}
    and www/transmission-web into flavours of net-p2p/transmission.

    What's new in 4.0.4 (vis-a-vis 3.00)
    * Resource Efficiency: code profiled and improved
    * Code Modernization: standardization on C++ tools
    * Support for BitTorrent v2 torrents & hybrid torrents
    * New web client
    * Lots of bug fixes

    Changelog: https://github.com/transmission/transmission/releases/tag/4.0.4

    PR:             269504
    Reported by:    dutchman01@quicknet.nl
    Approved by:    rigoletto, tcberner (maintainer timeout)
    Reviewed By:    fcharlier_ploup.net
    Differential Revision: https://reviews.freebsd.org/D40910

 MOVED                                              |   6 +
 net-p2p/Makefile                                   |   5 -
 net-p2p/transmission-cli/Makefile (gone)           |  91 -----------
 net-p2p/transmission-cli/distinfo (gone)           |   3 -
 .../files/patch-CMakeLists.txt (gone)              |  26 ---
 .../files/patch-cmake_FindDHT.cmake (gone)         |  12 --
 .../patch-libtransmission_CMakeLists.txt (gone)    |  11 --
 .../files/patch-libtransmission_tr-dht.c (gone)    |  11 --
 .../files/patch-qt_Application.h (gone)            |  10 --
 net-p2p/transmission-cli/pkg-descr (gone)          |   7 -
 net-p2p/transmission-cli/pkg-plist (gone)          |   8 -
 net-p2p/transmission-daemon/Makefile (gone)        |  18 --
 net-p2p/transmission-daemon/pkg-descr (gone)       |   9 -
 net-p2p/transmission-daemon/pkg-message (gone)     |  22 ---
 net-p2p/transmission-daemon/pkg-plist (gone)       |   9 -
 net-p2p/transmission-gtk/Makefile (gone)           |  18 --
 net-p2p/transmission-gtk/pkg-descr (gone)          |   7 -
 net-p2p/transmission-qt/Makefile (gone)            |  19 ---
 net-p2p/transmission-qt/pkg-descr (gone)           |  11 --
 net-p2p/transmission-utils/Makefile (gone)         |  12 --
 net-p2p/transmission-utils/pkg-descr (gone)        |   7 -
 net-p2p/transmission-utils/pkg-plist (gone)        |  14 --
 net-p2p/transmission/Makefile                      | 182 ++++++++++++++++++---
 net-p2p/transmission/distinfo (new)                |  11 ++
 .../files/patch-gtk_DetailsDialog.cc (new)         |  10 ++
 .../files/transmission.in                          |   8 -
 net-p2p/transmission/pkg-plist.cli (new)           |  29 ++++
 net-p2p/transmission/pkg-plist.daemon (new)        |  29 ++++
 net-p2p/transmission/pkg-plist.full (new)          | 155 ++++++++++++++++++
 .../pkg-plist => transmission/pkg-plist.gtk}       |  36 ++--
 .../pkg-plist => transmission/pkg-plist.qt}        |  30 +++-
 net-p2p/transmission/pkg-plist.utils (new)         |  18 ++
 www/Makefile                                       |   1 -
 www/transmission-web/Makefile (gone)               |  15 --
 www/transmission-web/pkg-descr (gone)              |  14 --
 35 files changed, 472 insertions(+), 402 deletions(-)
Comment 45 Robert Clausecker freebsd_committer freebsd_triage 2023-09-10 16:44:41 UTC
Thank you for your contribution.
Comment 46 jaskerx 2023-09-10 18:03:50 UTC
Did something go wrong? Freshports showing current commit as version 3.00_5:

https://www.freshports.org/net-p2p/transmission-daemon/

Or is this just Freshports problem?
Comment 47 Robert Clausecker freebsd_committer freebsd_triage 2023-09-10 18:05:58 UTC
(In reply to jaskerx from comment #46)

That port no longer exists, so you are seeing the last state before it was deleted.  It has been replaced by net-p2p/transmission@daemon
Comment 48 Jan Beich freebsd_committer freebsd_triage 2023-09-10 18:35:04 UTC
*** Bug 272240 has been marked as a duplicate of this bug. ***