After my troubles with 6.4.1 I attempted to try 6.5.1. Update my local ports tree. cd /usr/ports/net-im/signal-desktop. make. Make fails with: ... yarn install v1.22.18 [1/5] Validating package.json... [2/5] Resolving packages... [3/5] Fetching packages... [4/5] Linking dependencies... warning " > focus-trap-react@8.8.1" has unmet peer dependency "prop-types@^15.7.2". warning " > react-contextmenu@2.11.0" has incorrect peer dependency "react@^0.14.0 || ^15.0.0 || ^16.0.1". warning " > react-contextmenu@2.11.0" has incorrect peer dependency "react-dom@^0.14.0 || ^15.0.0 || ^16.0.1". warning " > react-contextmenu@2.11.0" has unmet peer dependency "prop-types@^15.0.0". warning " > react-sortable-hoc@2.0.0" has unmet peer dependency "prop-types@^15.5.7". warning " > react-virtualized@9.22.3" has incorrect peer dependency "react@^15.3.0 || ^16.0.0-alpha". warning " > react-virtualized@9.22.3" has incorrect peer dependency "react-dom@^15.3.0 || ^16.0.0-alpha". warning " > @storybook/addon-knobs@6.4.0" has unmet peer dependency "@storybook/api@^6.4.0". warning " > @storybook/addon-knobs@6.4.0" has unmet peer dependency "@storybook/components@^6.4.0". warning " > @storybook/addon-knobs@6.4.0" has unmet peer dependency "@storybook/core-events@^6.4.0". warning " > @storybook/addon-knobs@6.4.0" has unmet peer dependency "@storybook/theming@^6.4.0". warning " > @storybook/react@6.5.6" has unmet peer dependency "require-from-string@^2.0.2". warning " > css-loader@3.2.0" has incorrect peer dependency "webpack@^4.0.0". warning " > endanger@7.0.4" has incorrect peer dependency "danger@^10.5.3". warning " > file-loader@4.2.0" has incorrect peer dependency "webpack@^4.0.0". warning " > style-loader@1.0.0" has incorrect peer dependency "webpack@^4.0.0". [######################---------------------------------------------------------------- [5/5] Building fresh packages... warning Ignored scripts due to flag. Done in 430.59s. tar: Failed to open '/usr/ports/distfiles/signal-desktop-6.5.1-yarn-cache.tar.gz' *** Error code 1 Stop. make: stopped in /usr/ports/net-im/signal-desktop A make clean, followed by a make, also fails in the same way. --Chris P.S. In case it's not already evident; I'm tracking 13.
yarn website is far from reliable, you'll have to persist and try until it succeeds.
The 6.6.0 build fails for me (build in poudriere), but in a different way: yarn install v1.22.19 [1/6] Validating package.json... [2/6] Resolving packages... [3/6] Fetching packages... [4/6] Linking dependencies... warning " > focus-trap-react@8.8.1" has unmet peer dependency "prop-types@^15.7.2". warning " > react-contextmenu@2.11.0" has incorrect peer dependency "react@^0.14.0 || ^15.0.0 || ^16.0.1". warning " > react-contextmenu@2.11.0" has incorrect peer dependency "react-dom@^0.14.0 || ^15.0.0 || ^16.0.1". warning " > react-contextmenu@2.11.0" has unmet peer dependency "prop-types@^15.0.0". warning " > react-sortable-hoc@2.0.0" has unmet peer dependency "prop-types@^15.5.7". warning " > react-virtualized@9.22.3" has incorrect peer dependency "react@^15.3.0 || ^16.0.0-alpha". warning " > react-virtualized@9.22.3" has incorrect peer dependency "react-dom@^15.3.0 || ^16.0.0-alpha". warning " > @storybook/addon-knobs@6.4.0" has unmet peer dependency "@storybook/api@^6.4.0". warning " > @storybook/addon-knobs@6.4.0" has unmet peer dependency "@storybook/components@^6.4.0". warning " > @storybook/addon-knobs@6.4.0" has unmet peer dependency "@storybook/core-events@^6.4.0". warning " > @storybook/addon-knobs@6.4.0" has unmet peer dependency "@storybook/theming@^6.4.0". warning " > @storybook/react@6.5.6" has unmet peer dependency "require-from-string@^2.0.2". warning " > css-loader@3.2.0" has incorrect peer dependency "webpack@^4.0.0". warning " > endanger@7.0.4" has incorrect peer dependency "danger@^10.5.3". warning " > file-loader@4.2.0" has incorrect peer dependency "webpack@^4.0.0". warning " > style-loader@1.0.0" has incorrect peer dependency "webpack@^4.0.0". [5/6] Building fresh packages... error /wrkdirs/usr/ports/net-im/signal-desktop/work/Signal-Desktop-6.6.0/node_modules/@signalapp/better-sqlite3: Command failed. Exit code: 127 Command: npm run download && npm run build-release Arguments: Directory: /wrkdirs/usr/ports/net-im/signal-desktop/work/Signal-Desktop-6.6.0/node_modules/@signalapp/better-sqlite3 Output: /bin/sh: npm: not found info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=bd6533f9ecc2ee628010536d15bcf293a5102801 commit bd6533f9ecc2ee628010536d15bcf293a5102801 Author: Mikael Urankar <mikael@FreeBSD.org> AuthorDate: 2023-02-18 17:52:31 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2023-02-18 17:58:20 +0000 net-im/signal-desktop: Fix build Bump ELECTRON_GYP_VERSION to match electron version Update download.js to the version used in npm-@signalapp-better-sqlite3-8.4.3 PR: 269562 net-im/signal-desktop/Makefile | 2 +- net-im/signal-desktop/distinfo | 6 +++--- net-im/signal-desktop/files/download.js | 9 +++++---- 3 files changed, 9 insertions(+), 8 deletions(-)
After bd6533f9ecc2ee628010536d15bcf293a5102801, building 6.6.0 still fails here. [4/6] Linking dependencies... warning " > focus-trap-react@8.8.1" has unmet peer dependency "prop-types@^15.7.2". warning " > react-contextmenu@2.11.0" has incorrect peer dependency "react@^0.14.0 || ^15.0.0 || ^16.0.1". warning " > react-contextmenu@2.11.0" has incorrect peer dependency "react-dom@^0.14.0 || ^15.0.0 || ^16.0.1". warning " > react-contextmenu@2.11.0" has unmet peer dependency "prop-types@^15.0.0". warning " > react-sortable-hoc@2.0.0" has unmet peer dependency "prop-types@^15.5.7". warning " > react-virtualized@9.22.3" has incorrect peer dependency "react@^15.3.0 || ^16.0.0-alpha". warning " > react-virtualized@9.22.3" has incorrect peer dependency "react-dom@^15.3.0 || ^16.0.0-alpha". warning " > @storybook/addon-knobs@6.4.0" has unmet peer dependency "@storybook/api@^6.4.0". warning " > @storybook/addon-knobs@6.4.0" has unmet peer dependency "@storybook/components@^6.4.0". warning " > @storybook/addon-knobs@6.4.0" has unmet peer dependency "@storybook/core-events@^6.4.0". warning " > @storybook/addon-knobs@6.4.0" has unmet peer dependency "@storybook/theming@^6.4.0". warning " > @storybook/react@6.5.6" has unmet peer dependency "require-from-string@^2.0.2". warning " > css-loader@3.2.0" has incorrect peer dependency "webpack@^4.0.0". warning " > endanger@7.0.4" has incorrect peer dependency "danger@^10.5.3". warning " > file-loader@4.2.0" has incorrect peer dependency "webpack@^4.0.0". warning " > style-loader@1.0.0" has incorrect peer dependency "webpack@^4.0.0". Full build log: http://pkg.ftfl.ca/data/14amd64-default/2023-02-18_15h20m35s/logs/errors/signal-desktop-6.6.0.log
(In reply to Joseph Mingrone from comment #4) can you try to downgrade electron_gyp to 22.2.0, then make makesum and try again?
(In reply to Mikael Urankar from comment #5) In the end it worked (after a `make distclean fetch`), but I initially hit some errors. % git diff diff --git a/net-im/signal-desktop/Makefile b/net-im/signal-desktop/Makefile index 8f0241793876..0edb6102b020 100644 --- a/net-im/signal-desktop/Makefile +++ b/net-im/signal-desktop/Makefile @@ -87,7 +87,7 @@ ELECTRON_VER_MAJOR= 22 # keep NODE_VERSION in sync with www/node16 DISTVERSION NODE_VERSION= 16.19.0 # bump ELECTRON_GYP_VERSION when ELECTRON_VER_MAJOR is changed -ELECTRON_GYP_VERSION= 22.2.1 +ELECTRON_GYP_VERSION= 22.2.0 % sudo make makesum ===> License AGPLv3 accepted by the user ===> License AGPLv3 accepted by the user ===> signal-desktop-6.6.0 depends on file: /usr/local/sbin/pkg - found ===> signal-desktop-6.6.0 depends on package: yarn-node16>0 - not found ===> License BSD2CLAUSE accepted by the user ===> yarn-node16-1.22.19 depends on file: /usr/local/sbin/pkg - found => signal-desktop-6.6.0-yarn-cache.tar.gz doesn't seem to exist in /usr/ports/distfiles/. ===> /!\ Error /!\ The :prefetch group used for signal-desktop-6.6.0-yarn-cache.tar.gz is missing from MASTER_SITES. Check for typos, or errors. *** Error code 1 Stop. make[3]: stopped in /usr/ports/www/yarn-node16 *** Error code 1 Stop. make[2]: stopped in /usr/ports/www/yarn-node16 *** Error code 1 Stop. make[1]: stopped in /usr/ports/net-im/signal-desktop *** Error code 1 Stop. make: stopped in /usr/ports/net-im/signal-desktop Full log of the successful build: http://pkg.ftfl.ca/data/14amd64-default/2023-02-18_18h47m49s/logs/signal-desktop-6.6.0.log
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=725c283a9bb5a4c162c941b7413c69081adf3d2a commit 725c283a9bb5a4c162c941b7413c69081adf3d2a Author: Mikael Urankar <mikael@FreeBSD.org> AuthorDate: 2023-02-20 15:02:12 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2023-02-20 15:06:37 +0000 net-im/signal-desktop: another attempt to fix build ELECTRON_GYP_VERSION is 22.2.0 for electron 22.2.1 Drop :prefetch as it's not used PR: 269562 net-im/signal-desktop/Makefile | 4 ++-- net-im/signal-desktop/distinfo | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)
I don't have any luck unfortunately :-( =======================<phase: build >============================ ===> Building for signal-desktop-6.6.0 echo 'yarn-offline-mirror "../yarn-cache"' > /wrkdirs/usr/ports/net-im/signal-desktop/work/Signal-Desktop-6.6.0/.yarnrc /bin/chmod -R a+w /wrkdirs/usr/ports/net-im/signal-desktop/work/electron22 /bin/mkdir -p /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-libsignal-client-0.22.0-d57441612df46f90df68fc5d9ad45b857b9d2c44-integrity/node_modules/@signalapp/libsignal-client/prebuilds/freebsd-x64 /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-ringrtc-2.24.0-634160d24b2e13967a634e0f3236b2b4b5854091-integrity/node_modules/@signalapp/ringrtc/build/freebsd cp -f /usr/local/lib/libsignal_node.so /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-libsignal-client-0.22.0-d57441612df46f90df68fc5d9ad45b857b9d2c44-integrity/node_modules/@signalapp/libsignal-client/prebuilds/freebsd-x64/node.napi.node cp -f /usr/local/lib/libringrtc.so /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-ringrtc-2.24.0-634160d24b2e13967a634e0f3236b2b4b5854091-integrity/node_modules/@signalapp/ringrtc/build/freebsd/libringrtc-x64.node /bin/mkdir -p /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-better-sqlite3-8.4.3-7ffa8d03d2a12543247936bfb7b9f74cdbc6fe9b-integrity/node_modules/@signalapp/better-sqlite3/deps cp -f /portdistfiles/sqlcipher-4.5.3-fts--3.0.7--0.2.1-b633825cf7e0fdd39a6cdf128f2bd76552a88d325f2b9cd07bb87a457cefb986.tar.gz /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-better-sqlite3-8.4.3-7ffa8d03d2a12543247936bfb7b9f74cdbc6fe9b-integrity/node_modules/@signalapp/better-sqlite3/deps/sqlcipher.tar.gz cp -f /usr/ports/net-im/signal-desktop/files/fetch-prebuild.js /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-ringrtc-2.24.0-634160d24b2e13967a634e0f3236b2b4b5854091-integrity/node_modules/@signalapp/ringrtc/scripts/fetch-prebuild.js cp: /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-ringrtc-2.24.0-634160d24b2e13967a634e0f3236b2b4b5854091-integrity/node_modules/@signalapp/ringrtc/scripts/fetch-prebuild.js: No such file or directory *** Error code 1 Stop. make: stopped in /usr/ports/net-im/signal-desktop
(In reply to Thomas Zander from comment #8) I've pushed signal-desktop 6.7.0, can you try again please?
(In reply to Mikael Urankar from comment #9) I successfully built 6.7.0 in the 4th attempt. Thanks for fixing this, great work! But dear lord, "make fetch" is flaky for this port. Can we do something about this? Can we put the flaky stuff into LOCAL/ ?
(In reply to Thomas Zander from comment #10) I'll revert part of (pre-fetch target) in the next update. https://cgit.freebsd.org/ports/commit/net-im/signal-desktop?id=6caf783eef95f9dbe1f4e39a016a5d30cdb6ecfd
The yarn cache is hosted on LOCAL/