PORTNAME= nitrokey-app DISTVERSIONPREFIX= v DISTVERSION= 1.4.2 root@radziecki:/usr/ports/security/nitrokey-app # make stage-qa ====> Running Q/A tests (stage-qa) Error: /usr/local/bin/nitrokey-app is linked to /usr/local/lib/qt5/libQt5Core.so.5 from devel/qt5-core but it is not declared as a dependency Warning: you need USES=qt:5 and USE_QT+=core /!\ To run stage-qa automatically add DEVELOPER=yes to your environment /!\ root@radziecki:/usr/ports/security/nitrokey-app # make stage-qa Makefile distinfo pkg-descr pkg-plist root@radziecki:/usr/ports/security/nitrokey-app # make stage-qa root@radziecki:/usr/ports/security/nitrokey-app # make check-plist ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: local/share/bash-completion/completions/nitrokey-app ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: etc/bash_completion.d/nitrokey-app ===> Error: Plist issues found. *** Error code 1 The latter prevents clean install
Thanks for the report, I will upload a patch for this issue
Created attachment 240189 [details] fixup staging issue Since this port install a .desktop files, I added desktop-file-utils
Thank you for picking up so quickly! It it better, but still not fully fixed. Here is the result of "make stage-qa check-plist" with the patch applied: ====> Running Q/A tests (stage-qa) Warning: you may not need USES=desktop-file-utils /!\ To run stage-qa automatically add DEVELOPER=yes to your environment /!\ ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: local/share/bash-completion/completions/nitrokey-app ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 Stop. make: stopped in /usr/ports/security/nitrokey-app root@radziecki:/usr/ports/security/nitrokey-app # find `make -V STAGEDIR` -name nitrokey-app /big/ports/usr/ports/security/nitrokey-app/work/stage/usr/local/bin/nitrokey-app /big/ports/usr/ports/security/nitrokey-app/work/stage/usr/local/share/bash-completion/completions/nitrokey-app /big/ports/usr/ports/security/nitrokey-app/work/stage/usr/local/local/share/bash-completion/completions/nitrokey-app Looks like additional copy of the completions gets installed in /usr/local/local/share ...
(In reply to Marcin Cieślak from comment #3) My fixes was to install it to the correct places by copying it to the correct places. I need to find why it tries so hard to install it with a duplicate local prefix. My guess is that it assumes default to be /usr/, so when it detect a localbase it append local. But in our case this gives /usr/local/local
Created attachment 240205 [details] fixup staging issue They detect the bash completion directory with the command pkg-config --variable=completionsdir bash-completion and then remove the beginning with usr/ Since they provide a variable for it, it is easier to pass the correct one.
This time: root@radziecki:/usr/ports/security/nitrokey-app # make clean stage-qa check-plist (...) ====> Running Q/A tests (stage-qa) Warning: you may not need USES=desktop-file-utils /!\ To run stage-qa automatically add DEVELOPER=yes to your environment /!\ ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: local/share/bash-completion/completions/nitrokey-app ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 Stop. make: stopped in /usr/ports/security/nitrokey-app root@radziecki:/usr/ports/security/nitrokey-app # find `make -V STAGEDIR` -name nitrokey-app /big/ports/usr/ports/security/nitrokey-app/work/stage/usr/local/bin/nitrokey-app /big/ports/usr/ports/security/nitrokey-app/work/stage/usr/local/share/bash-completion/completions/nitrokey-app /big/ports/usr/ports/security/nitrokey-app/work/stage/usr/local/local/share/bash-completion/completions/nitrokey-app
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=44dda6cd41a7c640cae50d66e486a028608dea36 commit 44dda6cd41a7c640cae50d66e486a028608dea36 Author: Thibault Payet <monwarez@mailoo.org> AuthorDate: 2023-02-18 17:08:03 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-02-18 17:31:45 +0000 security/nitrokey-app: Fix packaging PR: 269595 Reported by: saper@saper.info (maintainer) security/nitrokey-app/Makefile | 8 ++++++-- security/nitrokey-app/pkg-plist | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-)