Bug 269624 - devel/libbson: Rework port
Summary: devel/libbson: Rework port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-17 13:59 UTC by Daniel Engberg
Modified: 2023-02-20 21:25 UTC (History)
1 user (show)

See Also:
ports: maintainer-feedback+

Attachments
Patch for libbson (38.90 KB, patch)
2023-02-17 13:59 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-02-17 13:59:37 UTC 
Created attachment 240211 [details]
Patch for libbson

* Use upstream release archive as recommended by Porters Handbook
* Use framework helpers when possible
* Rearrange Makefile to better follow Porters Handbook and easier readability
* Don't install unnecessary files in share directory

Compile tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist)
Poudriere testport OK 12.3-RELEASE (amd64)
Poudriere testport OK 13.1-RELEASE (i386)
Comment 1 Krzysztof 2023-02-18 07:17:21 UTC 
Comment on attachment 240211 [details]
Patch for libbson

Well: propably I'm not superhero of porter's book. I'm still learning...
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-02-19 00:18:49 UTC 
My intention was to make it more compliant and make maintainership easier, sorry if it came across as something else. If you're fine with the changes please set maintainer-feedback flag to +.
Comment 3 Krzysztof 2023-02-20 18:30:48 UTC 
Comment on attachment 240211 [details]
Patch for libbson

I was setting "+" flag during may last comment
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-02-20 21:24:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8747537ea6dd5dadd95828474ffe9e3128ae20b7

commit 8747537ea6dd5dadd95828474ffe9e3128ae20b7
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-02-20 21:10:26 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-02-20 21:23:57 +0000

    devel/libbson: Rework port

    * Use upstream release archive as recommended by Porters Handbook
    * Use framework helpers when possible
    * Rearrange Makefile to better follow Porters Handbook and easier
      readability
    * Don't install unnecessary files in share directory

    PR:             269624
    Reviewed by:    Krzysztof <ports@bsdserwis.com> (maintainer)

 devel/libbson/Makefile                   |  41 +--
 devel/libbson/distinfo                   |   6 +-
 devel/libbson/files/patch-CMakeLists.txt |   6 +-
 devel/libbson/pkg-plist                  | 532 +++++++++++++++----------------
 4 files changed, 287 insertions(+), 298 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2023-02-20 21:25:52 UTC 
Committed, thanks