Comment 1 Robert Clausecker 2023-02-17 18:31:07 UTC

In a future commit, please:

 - explain why ONLY_FOR_ARCHS=amd64 is needed using ONLY_FOR_ARCHS_REASON or remove the restriction if it is not.  If you need assistance with build testing on non-x86 hardware, please let me know.
 - change the use of scripts/build.sh to USES=go with the default build target if possible.  It seems like this script just invokes the Go compiler, but with none of our custom options configured by USES=go.

Comment 2 Mina Galić 2023-02-17 19:32:46 UTC

Created attachment 240221 [details]
upgrade net-im/gotosocial to 0.7.0

incorporate feedback from fuz

Comment 3 Mina Galić 2023-02-17 22:58:56 UTC

Created attachment 240224 [details]
upgrade net-im/gotosocial to 0.7.0

use go.mk framework to build:

- use go:modules
- set GO_BUILDFLAGS
- set GO_TARGET
- add CGO_ENABLED=0
- remove binary from do-install
- move rest of do-install to post-install

Comment 4 Mina Galić 2023-02-17 23:09:21 UTC

Created attachment 240225 [details]
upgrade net-im/gotosocial to 0.7.0

add more supported architectures: i386, armv7, aarch64

use go.mk framework to build:

- use go:modules
- set GO_BUILDFLAGS
- set GO_TARGET
- add CGO_ENABLED=0
- remove binary from do-install
- move rest of do-install to post-install

Comment 5 Mina Galić 2023-02-17 23:10:54 UTC

Comment on attachment 240224 [details]
upgrade net-im/gotosocial to 0.7.0

obsoleted

Comment 6 commit-hook 2023-02-20 23:38:51 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8493e29537b12f02304f4097e4db0cf28b97d0bd

commit 8493e29537b12f02304f4097e4db0cf28b97d0bd
Author:     Mina Galić <freebsd@igalic.co>
AuthorDate: 2023-02-17 17:24:01 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-02-20 23:36:43 +0000

    net-im/gotosocial: update to 0.7.0

    Enable on aarch64, i386, and armv7 after successful build test.

    Use go.mk framework to build:
     - use go:modules
     - set GO_BUILDFLAGS
     - set GO_TARGET
     - add CGO_ENABLED=0
     - remove binary from do-install
     - move rest of do-install to post-install

    Changelog: https://github.com/superseriousbusiness/gotosocial/releases/tag/v0.7.0

    PR:             269632
    Approved by:    flo (mentor)
    Differential Revision: https://reviews.freebsd.org/D38688

 net-im/gotosocial/Makefile  | 25 +++++++++++--------------
 net-im/gotosocial/distinfo  | 10 +++++-----
 net-im/gotosocial/pkg-plist | 11 ++++++++---
 3 files changed, 24 insertions(+), 22 deletions(-)

Comment 7 Robert Clausecker 2023-02-20 23:42:56 UTC

Thank you for your contribution.