Bug 269724 - audio/rsgain: Update to 3.2.1
Summary: audio/rsgain: Update to 3.2.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL: https://github.com/complexlogic/rsgai...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-20 17:28 UTC by Daniel Engberg
Modified: 2023-03-18 14:27 UTC (History)
0 users

See Also:
jhale: maintainer-feedback+


Attachments
Patch for rsgain (1.48 KB, patch)
2023-02-20 17:28 UTC, Daniel Engberg
no flags Details | Diff
Patch for rsgain v2 (1.48 KB, patch)
2023-02-27 17:32 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-02-20 17:28:12 UTC
Created attachment 240290 [details]
Patch for rsgain

Compile and runtime tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist)
Poudriere testport OK 12.3-RELEASE (amd64)
Poudriere testport OK 13.1-RELEASE (i386)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-02-27 17:32:54 UTC
Created attachment 240455 [details]
Patch for rsgain v2

Update to 3.2.1
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2023-02-28 13:56:17 UTC
I still can't get this to link when built with GCC. pkg-fallout reported the previous version was failing on arm64 with the same errors: https://pkg-status.freebsd.org/ampere1/data/123arm64-quarterly/ba2be1158c40/logs/rsgain-3.1.1_1.log.

I was able to get rid of the fmt errors by using the fmt::fmt-header-only target, but it still complains about taglib.

If you have any ideas, please let me know.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-02-28 14:01:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cad880b0cfbe00a39c192caebf78059de12696a9

commit cad880b0cfbe00a39c192caebf78059de12696a9
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-02-28 13:58:08 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2023-02-28 13:58:08 +0000

    audio/rsgain: Update to 3.2.1

    https://github.com/complexlogic/rsgain/releases/tag/v3.2.1
    PR:             269724

 audio/rsgain/Makefile  | 5 ++---
 audio/rsgain/distinfo  | 6 +++---
 audio/rsgain/pkg-plist | 1 +
 3 files changed, 6 insertions(+), 6 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-02-28 20:33:28 UTC
I don't think you need to bother with it, feel free to mark it as broken on 12. 13 is when arm64 got usable for "average joe" more or less in my experience.