Bug 269732 - archivers/lha: Perhaps include source in packages?
Summary: archivers/lha: Perhaps include source in packages?
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-21 09:01 UTC by Dennis Clarke
Modified: 2023-03-09 16:43 UTC (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Clarke 2023-02-21 09:01:43 UTC
The pkg repo for FreeBSD 13.1 Quarterly shows that mail/mailscanner
needs the pkg archivers/lha which does not exist in the repo.


-- 
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional
Comment 1 Dennis Clarke 2023-02-21 09:08:42 UTC
I also checked http://pkg.freebsd.org/FreeBSD:14:amd64/latest

where the pkg does not exist in the yaml catalog. 

Truely an absent pkg but MailScanner needs it.
Comment 2 Dennis Clarke 2023-02-21 09:14:34 UTC
Oh no .. seems to be a real license problem ! 

A translation of the Japanese LICENSE says : 


(Following sentences are from man/lha.man of lha-114i.tar.gz.
encoded with UTF-8 and written in Japanese.)

Redistribution, reproduction, and modification are permitted under the following conditions.

1. Do not remove any copyright notices.

2. Regarding the distribution contents,

a. Content present at the time of distribution (i.e. source code, document
   documentation, programmer's guides, etc.) are redistributed.
   Always exist in things. if it has been modified
   , prepare a document that clearly states it.

b. When redistributed with added value for LHa
   try to include them as much as possible. again,
   At that time, the
   prepare documentation.

c. Binary-only distribution is not permitted. (including value-added
   include)

3. Commit to distributing the latest version. (no obligation)

Note: Although distribution on the Internet is free,
    Distribution (by magazine, CD-ROM, etc.)
    Please send an e-mail to here before distribution. before distribution
    If you are unable to do so, please be sure to e-mail me at a later date.

4. damages caused by the existence or use of this program;
   No harm is guaranteed.

5. The author corrects any defects in this program.
   shall not be obliged to do so.

6. Part or all of this program to other programs
   You can incorporate it and use it. In this case, the professional
   Gram is not LHa and must not call himself LHa.

7. Regarding commercial use, in addition to the above conditions, the following conditions shall apply.
   and admit this.

a. Commercial use of this program as the main is prohibited.

b. the other party of the commercial use is inappropriate as a user of this program;
   Do not distribute if determined.

c. When used as a means of installation, this program
   Do not force your opponent to use In this case, commercial users
   does the work. In addition, the damage at that time shall be entirely the responsibility of the commercial user.
   Take responsible.

d. use this program for commercial use as an added value;
   If so, the commercial user will provide that support.



There it seems binary distribution is not allowed per 2.(c)  !
Comment 3 Chris Rees freebsd_committer freebsd_triage 2023-02-21 09:55:44 UTC
I don't see why we couldn't package the source together and stick it in DATADIR somewhere.

What do you think Dirk?  Could be wrapped in a .if PACKAGE_BUILDING or similar?
Comment 4 Tatsuki Makino 2023-02-22 23:47:19 UTC
It seems to me that there is a wit that could be solved by simply writing a pkg-message :)
Comment 5 Tatsuki Makino 2023-02-23 00:05:04 UTC
Another.
If mail/mailscanner uses lha only for archive extraction, it would be possible to replace it with archivers/lhasa.
However, I do not know if that is correct as I am a new human being who does not understand that far back in time :)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-02-23 11:27:47 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b5dcfceeaffa9574c2e45c4f65f09589cd40949a

commit b5dcfceeaffa9574c2e45c4f65f09589cd40949a
Author:     Chris Rees <crees@FreeBSD.org>
AuthorDate: 2023-02-23 11:24:33 +0000
Commit:     Chris Rees <crees@FreeBSD.org>
CommitDate: 2023-02-23 11:26:38 +0000

    mail/mailscanner: Remove archivers/lha dependency

    From inspecting the code it uses 7z to unarchive lha files anyway

    This means that packages will once again be built for MailScanner

    PR:             ports/269732
    Reported by:    Dennis Clarke

 mail/mailscanner/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-03-09 14:29:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9009f2cfb80d5dbc624956449a937c6697015fe8

commit 9009f2cfb80d5dbc624956449a937c6697015fe8
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2023-03-09 14:29:06 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2023-03-09 14:29:06 +0000

    archivers/lha: allow package

    PR: 269732

 archivers/lha/Makefile               | 10 +++++--
 archivers/lha/files/LICENSE.en (new) | 55 ++++++++++++++++++++++++++++++++++++
 2 files changed, 62 insertions(+), 3 deletions(-)