Bug 269771 - devel/p5-Sub-Quote missing depend p5-XString
Summary: devel/p5-Sub-Quote missing depend p5-XString
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-23 04:21 UTC by Zane C. Bowers-Hadley
Modified: 2023-06-08 22:09 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (perl)

Attachments
git diff (394 bytes, patch)
2023-02-23 04:36 UTC, Zane C. Bowers-Hadley 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zane C. Bowers-Hadley 2023-02-23 04:21:16 UTC 
Noticed that this is missing a depend of XString as it breaks spamassassin.

Feb 22 22:14:02 vulpes spamd[70643]: Can't locate XString.pm in @INC (you may need to install the XString module) (@INC contains: lib /usr/local/lib/perl5/site_perl /usr/local/lib/perl5/site_perl/mach/5.32 /usr/local/lib/perl5/5.32/mach /usr/local/lib/perl5/5.32) at /usr/local/lib/perl5/site_perl/Sub/Quote.pm line 50.
Comment 1 Zane C. Bowers-Hadley 2023-02-23 04:36:32 UTC 
Created attachment 240336 [details]
git diff
Comment 2 Wen Heping freebsd_committer freebsd_triage 2023-03-05 05:32:23 UTC 
Build_DEPEND should be RUN_DEPEND ?
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-06-03 23:15:48 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a5d9499c055ace9e4a42de1e47f8eacec79df7b4

commit a5d9499c055ace9e4a42de1e47f8eacec79df7b4
Author:     Wen Heping <wen@FreeBSD.org>
AuthorDate: 2023-06-03 08:41:04 +0000
Commit:     Wen Heping <wen@FreeBSD.org>
CommitDate: 2023-06-03 23:08:49 +0000

    devel/p5-Sub-Quote: Add missing DEPENDS

    PR:             269771
    Reported by:    vvelox@vvelox.net

 devel/p5-Sub-Quote/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 4 Gleb Smirnoff freebsd_committer freebsd_triage 2023-06-08 22:09:54 UTC 
I think this change was incorrect. Sub-Quote shall not need XString with any modern perl installation. This is the actual code:

  # if B is already loaded, just use its perlstring
  if ("$]" >= 5.008_000 && "$]" != 5.010_000 && defined &B::perlstring) {
    *_perlstring = \&B::perlstring;
  }
  # XString is smaller than B, so prefer to use it. Buggy until 0.003.
  elsif (eval { require XString; XString->VERSION(0.003) }) {
    *_perlstring = \&XString::perlstring;
  }

The B module is part of perl and is always present. Zane, can you please check your environment where spamd failed? Wen, the added dependency isn't correct.