Bug 269832 - sysutils/rust-coreutils: Provide more utils and reduce install size
Summary: sysutils/rust-coreutils: Provide more utils and reduce install size
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-26 09:35 UTC by Daniel Engberg
Modified: 2023-03-06 22:35 UTC (History)
1 user (show)

See Also:
pkubaj: maintainer-feedback+

Attachments
Patch for rust-coreutils (19.90 KB, patch)
2023-02-26 09:35 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-02-26 09:35:22 UTC 
Created attachment 240415 [details]
Patch for rust-coreutils

Use cargo to follow framework options more closely, this also allows use of including more utilities
Use multi binary as it substantially reduces install size and allows better overall optimization

Compile and runtime tested on FreeBSD 13.1-STABLE (amd64) (make, make test, make check-plist)
Poudriere testport OK 12.3-RELEASE (amd64)

Previously:
test result: FAILED. 1972 passed; 88 failed; 27 ignored; 0 measured; 0 filtered out; finished in 16.89s

New results:
test result: FAILED. 2244 passed; 107 failed; 37 ignored; 0 measured; 0 filtered out; finished in 19.96s
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-02-26 09:36:55 UTC 
This drops shell completions but they should be much work enabling again by adapting helper script and using cargo.
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2023-02-28 10:55:11 UTC 
LGTM.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-02-28 12:20:24 UTC 
err.. broken english.. ;-)

This drops shell completions but shouldn't be much work enabling again by adapting the helper script and using cargo.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-03-06 22:22:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9bc2075ac31b7578c2447da5f7bc6bac1b5f8b3d

commit 9bc2075ac31b7578c2447da5f7bc6bac1b5f8b3d
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-03-06 21:23:10 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-03-06 22:21:23 +0000

    sysutils/rust-coreutils: Provide more utils and reduce install size

    - Use cargo to follow framework options more closely, this also allows
      including more utilities
    - Use multi binary as it substantially reduces install size and allows
      better overall optimization

    This drops shell completions but it shouldn't be much work enabling
    again by adapting the helper script and using cargo

    PR:             269832
    Reviewed by:    pkubaj (maintainer)

 sysutils/rust-coreutils/Makefile                   |  46 +-
 .../files/symlink-install-helper.sh.in (new)       |   2 +
 sysutils/rust-coreutils/pkg-plist                  | 518 +++++----------------
 3 files changed, 159 insertions(+), 407 deletions(-)