Bug 269837 - devel/aws-sdk-cpp: unbreak i386 & fix TEST option
Summary: devel/aws-sdk-cpp: unbreak i386 & fix TEST option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-26 16:36 UTC by John Hein
Modified: 2023-02-27 13:38 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (eduardo)


Attachments
[patch] fix TEST option; unbreak for i386 (771 bytes, patch)
2023-02-27 00:23 UTC, John Hein
jcfyecrayz: maintainer-approval? (eduardo)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2023-02-26 16:36:12 UTC
I have succeeded building devel/aws-sdk-cpp (currently DISTVERSION=1.11.10) on 12-stable/i386 (2 GB RAM, 6 GB swap, 2 cpus) & DISABLE_MAKE_JOBS=1.  It may build with -j2, but conservatively I did tried -j1 first - no problems with any 'out of swap space' breakage.  I'll try -j2 as well, but it seems that the BROKEN_i386 can e removed.


Also note that using WITHOUT=TEST (TEST option off) currently enables (instead of disabling) building & running tests.  I think the Makefile should specify TEST_CMAKE_BOOL (instead of TEST_CMAKE_BOOL_OFF).
Comment 1 John Hein 2023-02-27 00:23:50 UTC
Created attachment 240435 [details]
[patch] fix TEST option; unbreak for i386

Patch to fix the TEST option, and allow building on i386 (after testing indicates it does not fail as of Feb 2023).

Bumping PORTREVISION should not be necessary as the changes should not change any existing packages.  If the committer feels that there are conditions which merit a PORTREVISION bump, feel free to do so.
Comment 2 John Hein 2023-02-27 00:24:40 UTC
(In reply to John Hein from comment #1)
p.s. I did not test building on other architectures to see if they also are no longer broken.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2023-02-27 08:24:43 UTC
Hello John,

I can confirm that it builds on i386 with TESTS off.
Waiting on results with TESTS on.
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2023-02-27 08:45:22 UTC
(In reply to Nuno Teixeira from comment #3)
(...)

TEST is causing build failure on i386 (and supposely on armv{6,7} and powerpc).

I will do the following commit with TEST_BROKEN_{armv6,armv7,i386,powerpc} and wait for results from build servers on arm and powerpc.

Also, thanks for catching TEST_CMAKE_BOOL_OFF that invert tests option, I think it cames from TEST_CMAKE_OFF -> TEST_CMAKE_BOOL_OFF and forgot to adjust it.

Cheers
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-02-27 13:29:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e7b134bf62ce15bd1daf1f7fbed512262baa8eea

commit e7b134bf62ce15bd1daf1f7fbed512262baa8eea
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2023-02-27 09:00:18 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-02-27 13:28:07 +0000

    devel/aws-sdk-cpp: Update to 1.11.25

    - fix TEST option that was wrongly set to ON and causing build failures
      on some 32bit archs.
    - unbreak on mentioned archs

    ChangeLog:      https://github.com/aws/aws-sdk-cpp/compare/1.11.10...1.11.25
    PR:             269837
    Reported by:    John Hein <jcfyecrayz@liamekaens.com>

 devel/aws-sdk-cpp/Makefile | 13 ++++++-------
 devel/aws-sdk-cpp/distinfo |  6 +++---
 2 files changed, 9 insertions(+), 10 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2023-02-27 13:38:56 UTC
Committed, thanks!