Created attachment 240561 [details] update patch
Hi, Thanks for updating the port. There are the following warnings/errors from the "stage-qa" phase: (to reproduce, execute "make stage-qa") ====> Running Q/A tests (stage-qa) Warning: you may not need USES=desktop-file-utils Error: /usr/local/bin/nestopia is linked to /usr/local/lib/libGL.so.1 from graphics/libglvnd but it is not declared as a dependency Warning: you need USE_GL+=gl Error: /usr/local/bin/nestopia is linked to /usr/local/lib/libpng16.so.16 from graphics/png but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libpng.so:graphics/png Error: /usr/local/bin/nestopia is linked to /usr/local/lib/libjpeg.so.8 from graphics/jpeg-turbo but it is not declared as a dependency Warning: you need USES+=jpeg Error: /usr/local/bin/nestopia is linked to /usr/local/lib/libXrender.so.1 from x11/libXrender but it is not declared as a dependency Warning: you need USE_XORG+=xrender Error: /usr/local/bin/nestopia is linked to /usr/local/lib/libXcursor.so.1 from x11/libXcursor but it is not declared as a dependency Warning: you need USE_XORG+=xcursor Error: /usr/local/bin/nestopia is linked to /usr/local/lib/libXfixes.so.3 from x11/libXfixes but it is not declared as a dependency Warning: you need USE_XORG+=xfixes Error: /usr/local/bin/nestopia is linked to /usr/local/lib/libXext.so.6 from x11/libXext but it is not declared as a dependency Warning: you need USE_XORG+=xext Error: /usr/local/bin/nestopia is linked to /usr/local/lib/libXft.so.2 from x11-fonts/libXft but it is not declared as a dependency Warning: you need USE_XORG+=xft Error: /usr/local/bin/nestopia is linked to /usr/local/lib/libfontconfig.so.1 from x11-fonts/fontconfig but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libfontconfig.so:x11-fonts/fontconfig Error: /usr/local/bin/nestopia is linked to /usr/local/lib/libXinerama.so.1 from x11/libXinerama but it is not declared as a dependency Warning: you need USE_XORG+=xinerama Error: /usr/local/bin/nestopia is linked to /usr/local/lib/libX11.so.6 from x11/libX11 but it is not declared as a dependency Warning: you need USE_XORG+=x11 Can you update the Makefile accordingly?
Created attachment 241173 [details] revised patch
If I remove USES=desktop-file-utils, portlint gives me the message: FATAL: /usr/ports/emulators/nestopia/pkg-plist: [2]: this port installs .desktop files. Please add `desktop-file-utils` to USES. All other issues should be addressed by the new patch.
(In reply to Mitchell Clay from comment #4) Does the .desktop file include a MimeType entry? If not, you can safely remove USES=desktop-file-utils from the Makefile. cf. https://docs.freebsd.org/en/books/porters-handbook/book/#updating-desktop-database
GH_ACCOUNT should be 0ldsk00l Is libao dependency needed? Depending on your use case you might also want to have a look at https://github.com/punesemu/puNES
(In reply to Daniel Engberg from comment #6) Thanks for the suggestions!
Created attachment 241185 [details] revised patch
Committed, thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3b5dd3c9d7989e900155de9d15d68a6deef012d5 commit 3b5dd3c9d7989e900155de9d15d68a6deef012d5 Author: Mitchell Clay <mclay@astate.edu> AuthorDate: 2023-03-29 15:16:03 +0000 Commit: Hiroki Tagato <tagattie@FreeBSD.org> CommitDate: 2023-03-30 01:25:49 +0000 emulators/nestopia: update to 1.52.0 and take maintainership Changelog: http://0ldsk00l.ca/nestopia/ PR: 269940 Reported by: Mitchell Clay <mclay@astate.edu> (new maintainer) Reviewed by: diizzy emulators/nestopia/Makefile | 21 ++++++++++++--------- emulators/nestopia/distinfo | 6 +++--- emulators/nestopia/files/patch-configure.ac (new) | 11 +++++++++++ 3 files changed, 26 insertions(+), 12 deletions(-)