Bug 269981 - sysutils/cpu-x: Russian translation is horrendous
Summary: sysutils/cpu-x: Russian translation is horrendous
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-05 16:40 UTC by Alexey Vyskubov
Modified: 2023-03-23 11:04 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Vyskubov 2023-03-05 16:40:38 UTC
I am a native speaker of Russian, and I had to run "LANG=C cpu-x -h" -- so bad is the Russian translation. For example, "cpu-x -D" means "Dump all data on standard output and exit"; however, in Russian help it is documented as "Собрать все данные стандартного вывода и выйти", and it means "Gather all the data of standard output and exit". Not only has it nothing to do with what the program does -- it is utter nonsense. Another example: "embedded command" in several places is translated as "extended command"; "verbose output" is translated as "текстовый вывод" (meaning "text output"). It is better not to have any localization than to have this "translation".
Comment 1 Mina Galić freebsd_triage 2023-03-05 17:12:21 UTC
i would report this upstream, https://github.com/TheTumultuousUnicornOfDarkness/CPU-X/issues

(also, upstream has a new website that should be reflected in the port: https://thetumultuousunicornofdarkness.github.io/CPU-X )
Comment 2 Alexey Vyskubov 2023-03-05 17:24:41 UTC
Reported translation issue upstream at https://github.com/TheTumultuousUnicornOfDarkness/CPU-X/issues/272
Comment 3 Alexey Vyskubov 2023-03-16 10:43:49 UTC
My bug was closed upstream with a comment that version 4.0.1 (included in FreeBSD) is over three years old, and the translation was updated since then.
Comment 4 Mina Galić freebsd_triage 2023-03-16 11:19:25 UTC
so i assume this port can be considered unmaintained then.
do you wanna take it over and upgrade it?

https://docs.freebsd.org/en/books/porters-handbook/book/#port-upgrading
Comment 5 Alexey Vyskubov 2023-03-16 11:22:53 UTC
Sure, I'll do some RTFMing. I have more than enough time now.
Comment 6 Alexey Dokuchaev freebsd_committer freebsd_triage 2023-03-16 12:53:03 UTC
(In reply to Alexey Vyskubov from comment #3)
> My bug was closed upstream [implying that] the translation was updated
> since then.
However, they did not confirm whether these particular translation bugs had been fixed or not (go figure).

(In reply to Mina Galić from comment #4)
> so i assume this port can be considered unmaintained then.
Wrong, it is maintained.  I was regularly updating it until I got derailed by bug #251785, that's all.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-03-17 10:26:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5d0d0f023e25dd8a4b8a3b7b68e156d71657d574

commit 5d0d0f023e25dd8a4b8a3b7b68e156d71657d574
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2023-03-17 10:25:48 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2023-03-17 10:25:48 +0000

    sysutils/cpu-x: the port had been updated and improved (+)

    - Update to the latest version 4.5.2 and chase that very long
      new upstream name; adjust LICENSE (it's GPLv3 or later)
    - Garbage-collect no longer needed `post-patch' target
    - Allow to disable NLS due to low quality of some translations
      and unbreak the port's build in this case
    - Disable GLFW, Vulkan, and OpenCL for now: on FreeBSD, they
      only provide those components' version numbers because the
      adjacent support code is Linux-specific

    PR:             269981
    Reported by:    portscout

 sysutils/cpu-x/Makefile                       | 23 +++++-----
 sysutils/cpu-x/distinfo                       |  6 +--
 sysutils/cpu-x/files/patch-src_CMakeLists.txt | 13 +++++-
 sysutils/cpu-x/pkg-plist                      | 60 +++++++++++++++++----------
 4 files changed, 62 insertions(+), 40 deletions(-)
Comment 8 Alexey Dokuchaev freebsd_committer freebsd_triage 2023-03-17 10:33:43 UTC
(In reply to Alexey Vyskubov from comment #3)
> ... and the translation was updated since then.
Maybe they were, but the bugs you pointed out are still there.  I'll review the ru.po file and fix those in a separate commit; meanwhile, you can update the port and disable NLS in the options.
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-03-23 11:03:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=74b0665361c473326ca4d7a1af61808f44d91daa

commit 74b0665361c473326ca4d7a1af61808f44d91daa
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2023-03-23 11:01:54 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2023-03-23 11:01:54 +0000

    sysutils/cpu-x: substantially improve Russian translation

    Not just it lacked finesse, some strings were rather inaccurate.
    These changes had been merged upstream and would be included in
    the next version.  While here, sort the `pkg-plist' file.

    PR:     269981

 sysutils/cpu-x/files/patch-po_ru.po (new) | 510 ++++++++++++++++++++++++++++++
 sysutils/cpu-x/pkg-plist                  |  34 +-
 2 files changed, 527 insertions(+), 17 deletions(-)