Created attachment 240688 [details] audio/ardour: Update to 7.3.0 release. Update audio/ardour to 7.3.0 release. Tested with some projects on 13.1-RELEASE. The AVX code had to be patched to compile with clang, but is not active by default.
Hi Florian, Thanks for the patch. I build tested it in 12.4{amd64,i386} and 13.1amd64 and builds fine. However it fails in current with: The configuration failed (complete log in /wrkdirs/usr/ports/audio/ardour/work/Ardour-7.3.0/build/config.log) ===> Script "configure" failed unexpectedly. Please report the problem to dev@submerge.ch [maintainer] and attach the "/wrkdirs/usr/ports/audio/ardour/work/Ardour-7.3.0/config.log" including the output of the failure of your make command. Also, it might be a good idea to provide an overview of all packages installed on your system (e.g. a /usr/local/sbin/pkg-static info -g -Ea). *** Error code 1 It is a bit weird because I can see this: [current-default] Installing libarchive-3.6.2,1... [current-default] Extracting libarchive-3.6.2,1: .......... done ===> ardour-7.3.0 depends on shared library: libarchive.so.13 - found (/usr/local/lib/libarchive.so.13) But somehow the configure script fails in current but not in previous versions. Can you confirm this?
(In reply to Fernando Apesteguía from comment #1) Hi Fernando, that sounds strange, could you provide the full logs of the failed build to me? Unfortunately I don't have CURRENT ready and running, so I won't be able to test this easily.
Created attachment 240727 [details] ardour poudriere log in current Here it is. I will try to have a look tomorrow.
(In reply to Fernando Apesteguía from comment #3) Thanks - maybe it finds libarchive from base by accident? I just checked that here on 13.1-RELEASE it picks up the one from ports: > libarchive.so.13 => /usr/local/lib/libarchive.so.13 (0x65bdd325000) Didn't spot anything else that would be suspicious.
Created attachment 241124 [details] Update to 7.3.0 with fixed -current Hi Florian, Thanks for your patience. It took me a while to find time to work on this. The output of the configure script shows the real problem: yes ---------------------------------------------------- Checking for 'libcurl' >= 7.0.0 ['/usr/local/bin/pkg-config', 'libcurl >= 7.0.0', '--cflags', '--libs', 'libcurl'] out: -I/usr/local/include -L/usr/local/lib -lcurl yes ---------------------------------------------------- Checking for 'libarchive' >= 3.0.0 ['/usr/local/bin/pkg-config', 'libarchive >= 3.0.0', '--cflags', '--libs', 'libarchive'] out: err: Package libssl was not found in the pkg-config search path. Perhaps you should add the directory containing `libssl.pc' to the PKG_CONFIG_PATH environment variable Package 'libssl', required by 'libarchive', not found Package 'libcrypto', required by 'libarchive', not found Package 'libssl', required by 'libarchive', not found Package 'libcrypto', required by 'libarchive', not found not found from /wrkdirs/usr/ports/audio/ardour/work/Ardour-7.3.0: The configuration failed So it seems the problem is with libarchive but it seems to be actually complaining about libssl. The pkg-config file for libarchive tries to find libssl by using again a libssl.pc. That file is only installed by security/openssl and is not present with base libssl. If this port used a GNU configure file, I think it could be workarounded with some environmental variables. However, in this case I can't see how to workaround this except by introducing security/openssl as a dependency. With this, the port builds fine in 12.4{amd64,i386}, 13.1amd64 and -current amd64. I also runt tested in 13.1amd64. What do you think?
(In reply to Fernando Apesteguía from comment #5) Hi Fernando, > Thanks for your patience. It took me a while to find time to work on this. Nevermind, we're all doing this in our spare time - thanks for looking into it! While I'm not opposed to any workable solution, I have some open questions: > So it seems the problem is with libarchive but it seems to be actually > complaining about libssl. > The pkg-config file for libarchive tries to find libssl by using again a > libssl.pc. That file is only installed by security/openssl and is not present > with base libssl. That sounds to me like libarchive.pc is inconsistent on CURRENT, and should be fixed. In 13.x libssl and libcrypto are patched in as "Requires.private" entries in libarchive.pc, see archivers/libarchive/Makefile. How does libarchive.pc refer to it on CURRENT? At least it would explain the difference between 13.x and CURRENT. There's also a comment in the Makefile about openssl.pc, but not libssl.pc. Could you check whether openssl.pc is present with base libssl in CURRENT, and if so try to patch libarchive.pc accordingly?
I've written glewis@ to see if he can help. If the conditional patch is applied also in current, then ardour builds there without any changes. I think the change should be in archivers/libarchive. Cheers.
(In reply to Fernando Apesteguía from comment #7) Any news on this? When I finally came around to update my 14-CURRENT VM, libssl.pc was installed by base and the pkg-config detection command for libarchive executed without error. Also libarchive.pc is the same as on 13.x. Can you still reproduce the build failure?
(In reply to Florian Walpen from comment #8) I'm updating my current and poudriere jail on top of that. I hope I can test tomorrow.
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=53e8e70bba765ec8ff0d4684c7364fc504034bc4 commit 53e8e70bba765ec8ff0d4684c7364fc504034bc4 Author: Florian Walpen <dev@submerge.ch> AuthorDate: 2023-04-04 15:28:51 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-04-05 05:18:59 +0000 audio/ardour: Update to 7.3.0 release. ChangeLog: https://ardour.org/whatsnew.html PR: 270056 Reported by: dev@submerge.ch (maintainer) audio/ardour/Makefile | 5 +- audio/ardour/distinfo | 6 +- .../files/patch-libs_ardour_ardour_cycles.h (gone) | 25 ----- .../patch-libs_ardour_sse__functions__avx.cc (new) | 11 +++ ...libs_ardour_sse__functions__avx__linux.cc (new) | 84 ++++++++++++++++ ...ch-libs_ardour_x86__functions__avx512f.cc (new) | 109 +++++++++++++++++++++ .../patch-libs_ardour_x86__functions__fma.cc (new) | 13 +++ audio/ardour/pkg-plist | 1 + 8 files changed, 223 insertions(+), 31 deletions(-)
Sorry for the delay. After upgrading the jail, many packages needed to be rebuilt (llvm, etc...)