Bug 270104 - editors/setzer: Update to 54
Summary: editors/setzer: Update to 54
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL: https://www.cvfosammmm.org/setzer/
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-11 08:26 UTC by Clockwork
Modified: 2023-03-17 09:04 UTC (History)
2 users (show)

See Also:


Attachments
editors/setzer: Update to 54 (18.22 KB, patch)
2023-03-11 08:26 UTC, Clockwork
no flags Details | Diff
0002-editors-setzer-Update-to-54.patch (18.41 KB, patch)
2023-03-13 17:42 UTC, Clockwork
Clockwork6400: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Clockwork 2023-03-11 08:26:31 UTC
Created attachment 240738 [details]
editors/setzer: Update to 54
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-03-13 14:49:29 UTC
Packages that install files into PYTHON_SITELIBDIR must use flavours and set PKGNAMEPREFIX as indicated in ยง 6.17 Porter's Handbook.  Please add this.

Please check if you can expand pkg-descr a bit.

python:3.5+ can be replaced by python as no version that old is in the Ports tree anymore.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-03-13 14:50:30 UTC
Please also provide a link to a changelog if available.
Comment 3 Clockwork 2023-03-13 17:42:26 UTC
Created attachment 240824 [details]
0002-editors-setzer-Update-to-54.patch

(In reply to Robert Clausecker from comment #2)

* added PKGNAMEPREFIX and flavors
* I added more text to pkg-descr that I found on the site.
* python:3.5+ replaced with python.

Unfortunately I can't guess where his changelog is

I duplicated the changes in the revision. If you have time, can you try to test this program?
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-03-16 09:43:10 UTC
A test run of the program fails, likely due to a missing dependency:

Traceback (most recent call last):
  File "/usr/local/bin/setzer", line 29, in <module>
    from setzer.workspace.workspace import Workspace
  File "/usr/local/lib/python3.9/site-packages/setzer/workspace/workspace.py", line 23, in <module>
    from setzer.document.document_latex import DocumentLaTeX
  File "/usr/local/lib/python3.9/site-packages/setzer/document/document_latex.py", line 22, in <module>
    import setzer.document.build_system.build_system as build_system
  File "/usr/local/lib/python3.9/site-packages/setzer/document/build_system/build_system.py", line 26, in <module>
    import setzer.document.build_system.builder.builder_build_latex as builder_build_latex
  File "/usr/local/lib/python3.9/site-packages/setzer/document/build_system/builder/builder_build_latex.py", line 23, in <module>
    import pexpect
ModuleNotFoundError: No module named 'pexpect'

When you update Python ports, make sure to check for newly required dependencies!
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-03-16 10:03:27 UTC
If I manually add this dependency, the port runs fine.

For the future, you can use "poudriere testport -i" to get an interactive shell in the test jail with the package you just built installed.  This allows you to test it easily.

You should also set NO_ARCH=yes as this port does not install any architecture-specific files.  You can find a warning about this in the testport log:

=======================<phase: package        >============================
===== env: DEVELOPER_MODE=yes PACKAGES=/tmp/pkgs PKGREPOSITORY=/tmp/pkgs PKGLATESTREPOSITORY=/tmp/pkgs/Latest 'PKG_NOTES=build_timestamp built_by' 'PKG_NOTE_build_timestamp=2023-03-16T10:02:03+0000' 'PKG_NOTE_built_by=poudriere-git-3.3.99.20220831' STRICT_DEPENDS=yes USER=nobody UID=65534 GID=65534
===>  Building package for py39-setzer-54
pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:13:amd64" -- no architecture specific files found:
**** could this package use a wildcard architecture?
===========================================================================
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-03-17 09:03:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6eb1f4e572d021446e49e753a65ef7cae20184c3

commit 6eb1f4e572d021446e49e753a65ef7cae20184c3
Author:     Clockwork6400 <Clockwork6400@protonmail.com>
AuthorDate: 2023-03-13 17:19:53 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-03-17 09:02:16 +0000

    editors/setzer: Update to 54

    Changelog: https://github.com/cvfosammmm/Setzer/compare/v0.4.1...v54

    PR:             270104
    Differential Revision: https://reviews.freebsd.org/D39021

 editors/setzer/Makefile  |  18 ++---
 editors/setzer/distinfo  |   6 +-
 editors/setzer/pkg-descr |   4 ++
 editors/setzer/pkg-plist | 173 +++++++++++++++++++++++++++--------------------
 4 files changed, 116 insertions(+), 85 deletions(-)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-03-17 09:04:11 UTC
Thank you for your contribution.