Bug 270105 - science/mpb: Add shared library; Remove NLOPT option; Add test target
Summary: science/mpb: Add shared library; Remove NLOPT option; Add test target
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-11 09:47 UTC by Yuri Victorovich
Modified: 2023-05-14 17:40 UTC (History)
0 users

See Also:
rhurlin: maintainer-feedback+


Attachments
patch (1.86 KB, patch)
2023-03-11 09:47 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2023-03-11 09:47:55 UTC
Created attachment 240739 [details]
patch

The NLOPT was dysfunctional - it wasn't able to disable nlopt. Build still linked to nlopt when it was present regardless of this option.

Shared libraries are expected by some dependencies.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-05-14 17:32:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=244238e1a8dc327a72c6f62f8055c3044dbb7442

commit 244238e1a8dc327a72c6f62f8055c3044dbb7442
Author:     Yuri Victorovich <yuri@freebsd.org>
AuthorDate: 2023-05-14 16:51:02 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2023-05-14 17:29:44 +0000

    science/mpb: Additions and improvements

    - Add shared library
    - Remove NLOPT option
    - Add test target
    - Pet portlint

    Contrary to the patch from the PR, USE_GCC=yes is kept, otherwise errors under CURRENT (with LLVM15).

    Co-authored-by: Rainer Hurling <rhurlin@FreeBSD.org>
    PR:             270105

 science/mpb/Makefile  | 22 +++++++++++++---------
 science/mpb/pkg-plist |  3 +++
 2 files changed, 16 insertions(+), 9 deletions(-)
Comment 2 Rainer Hurling freebsd_committer freebsd_triage 2023-05-14 17:40:20 UTC
Hi Yuri,

Thanks for the patch and sorry for the long delay.

I haven't removed USE_GCC=yes yet because there are problems building under CURRENT or with LLVM15+. There are probably missing adjustments as shown in Issue #120 [1], but even that doesn't seem to be enough for newer LLVM versions.


Also, I tried the repo on current version dated 01/24/2023 [2] and couldn't get it to run, even with GCC :( 


[1] https://github.com/NanoComp/mpb/pull/120

[2] https://github.com/NanoComp/mpb/commit/a6da0e8ed2c20f04cf8a55c6f75668be6cdd6826