Bug 270192 - audio/bliss: Update to latest commit (2023-03-23)
Summary: audio/bliss: Update to latest commit (2023-03-23)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks: 261302
  Show dependency treegraph
 
Reported: 2023-03-14 09:22 UTC by Daniel Engberg
Modified: 2023-03-25 17:56 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments
Patch for bliss (979 bytes, patch)
2023-03-25 15:54 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-03-14 09:22:38 UTC
- Deprecated upstream in favour of https://github.com/Polochon-street/bliss-rs
- Fails to build with FFmpeg 6
  Reference: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261302#c44
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-03-14 09:35:44 UTC
(In reply to Daniel Engberg from comment #0)

I see. Thanks.

I will add audio/bliss-rs tomorrow.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2023-03-14 09:45:59 UTC
Build fails for Polochon-street/bliss-rs:
https://github.com/Polochon-street/bliss-rs/issues/60
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2023-03-14 10:05:00 UTC
audio/bliss isn't deprecated, because bliss-rs is a Rust app and library, and isn't usable from C/C++ like bliss is.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-03-14 11:22:44 UTC
https://github.com/Polochon-street/bliss

"Note: this is now in support-mode only.
For new features, see bliss-rs."

To me that looks like upstream have no intentions continuing developing it
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2023-03-19 13:40:13 UTC
fwiw, bliss-rs just added ffmpeg 6.0 support
https://github.com/Polochon-street/bliss-rs/commit/743f7795291070431ae32564ae1271761379ba4e
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2023-03-19 16:31:41 UTC
(In reply to Daniel Engberg from comment #4)

"support-mode only" means no new features, but they should maintain compatibility with dependencies.
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2023-03-25 15:54:23 UTC
Created attachment 241106 [details]
Patch for bliss

Update to latest commit to fix compatibility with FFmpeg 6.0

Compile tested on FreeBSD 13.2-BETA1 (amd64)
Poudriere testport OK 12.3-RELEASE (amd64)
Poudriere testport OK 12.4-RELEASE (amd64) - FFmpeg 4
Comment 8 Yuri Victorovich freebsd_committer freebsd_triage 2023-03-25 17:55:48 UTC
Patch committed.
Thanks for the patch!
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-03-25 17:56:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=375b9c0eb0391051c8ecaa78b2c7fe30e9cb7e89

commit 375b9c0eb0391051c8ecaa78b2c7fe30e9cb7e89
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-03-25 17:55:04 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-03-25 17:55:51 +0000

    audio/bliss: Update 1.2.0-6 → 1.2.0-209

    PR:     270192

 audio/bliss/Makefile | 4 ++--
 audio/bliss/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)