Bug 270221 - graphics/libplacebo fails to configure if GLSLANG=on
Summary: graphics/libplacebo fails to configure if GLSLANG=on
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-14 20:34 UTC by Philipp Ost
Modified: 2023-05-21 03:18 UTC (History)
2 users (show)

See Also:
jbeich: maintainer-feedback+
jbeich: merge-quarterly+


Attachments
poudriere testport logfile for graphics/libplacebo with GLSLANG=on (21.34 KB, text/plain)
2023-03-14 20:34 UTC, Philipp Ost
no flags Details
meson-log.txt for failed build attempt of graphics/libplacebo (19.69 KB, text/plain)
2023-03-14 20:35 UTC, Philipp Ost
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2023-03-14 20:34:10 UTC
Created attachment 240850 [details]
poudriere testport logfile for graphics/libplacebo with GLSLANG=on

graphics/libplacebo (version 5.264.0) fails to configure if GLSLANG=on:

----8<----
===>  Configuring for libplacebo-5.264.0
The Meson build system
Version: 1.0.1
Source dir: /wrkdirs/usr/ports/graphics/libplacebo/work/libplacebo-5.264.0
Build dir: /wrkdirs/usr/ports/graphics/libplacebo/work/libplacebo-5.264.0/_build
Build type: native build
Project name: libplacebo
Project version: 5.264.0
C compiler for the host machine: cc (clang 13.0.0 "FreeBSD clang version 13.0.0 (git@github.com:llvm/llvm-project.git llvmorg-13.0.0-0-gd7b669b3a303)")
C linker for the host machine: cc ld.lld 13.0.0
C++ compiler for the host machine: c++ (clang 13.0.0 "FreeBSD clang version 13.0.0 (git@github.com:llvm/llvm-project.git llvmorg-13.0.0-0-gd7b669b3a303)")
C++ linker for the host machine: c++ ld.lld 13.0.0
Host machine cpu family: x86_64
Host machine cpu: x86_64
Compiler for C supports arguments -Wincompatible-pointer-types: YES 
Compiler for C supports link arguments -Wl,--exclude-libs=ALL: YES 
Library m found: YES
Program python3 found: YES (/usr/local/bin/python3.9)
Run-time dependency threads found: YES
Header "pthread.h" has symbol "pthread_condattr_setclock" with dependency threads: YES 
Found pkg-config: /usr/local/bin/pkgconf (1.8.1)
Run-time dependency libunwind found: YES 1.6.2
Library execinfo found: YES
Checking for function "backtrace_symbols" with dependency -lexecinfo: YES 
Library dl found: YES
Dependency shaderc skipped: feature shaderc disabled
Library glslang-default-resource-limits found: YES
Library SPIRV found: NO

src/glsl/meson.build:34:4: ERROR: C++ static library 'SPIRV' not found

A full log can be found at /wrkdirs/usr/ports/graphics/libplacebo/work/libplacebo-5.264.0/_build/meson-logs/meson-log.txt
WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.
---->8----

Everything is fine with SHADERC=on.

Logfiles are attached.
Comment 1 Philipp Ost 2023-03-14 20:35:07 UTC
Created attachment 240851 [details]
meson-log.txt for failed build attempt of graphics/libplacebo
Comment 2 gja822 2023-03-25 07:53:15 UTC
Yes, the same problem is here for me.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-05-21 03:14:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=506f67ea200f6858dd4f49efb28ccdd33456e0d9

commit 506f67ea200f6858dd4f49efb28ccdd33456e0d9
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-05-21 02:57:13 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-05-21 03:13:27 +0000

    graphics/libplacebo: unbreak GLSLANG=on after 1801dc29cec9

    compiler.find_library(static: true) ignores LDFLAGS and LIBRARY_PATH
    as Meson uses --print-search-dirs instead of trying to link.

    src/glsl/meson.build:34:4: ERROR: C++ static library 'SPIRV' not found
    src/glsl/meson.build:45:12: ERROR: C++ static library 'MachineIndependent' not found

    PR:             270221
    Reported by:    Philipp Ost
    Regressed by:   https://code.videolan.org/videolan/libplacebo/-/commit/980f2574aa0f

 graphics/libplacebo/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-05-21 03:15:04 UTC
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1885fe5b0cd69e136a5bf5e51cd203dfdc44c37d

commit 1885fe5b0cd69e136a5bf5e51cd203dfdc44c37d
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-05-21 02:57:13 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-05-21 03:13:59 +0000

    graphics/libplacebo: unbreak GLSLANG=on after 1801dc29cec9

    compiler.find_library(static: true) ignores LDFLAGS and LIBRARY_PATH
    as Meson uses --print-search-dirs instead of trying to link.

    src/glsl/meson.build:34:4: ERROR: C++ static library 'SPIRV' not found
    src/glsl/meson.build:45:12: ERROR: C++ static library 'MachineIndependent' not found

    PR:             270221
    Reported by:    Philipp Ost
    Regressed by:   https://code.videolan.org/videolan/libplacebo/-/commit/980f2574aa0f

    (cherry picked from commit 506f67ea200f6858dd4f49efb28ccdd33456e0d9)

 graphics/libplacebo/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 5 Jan Beich freebsd_committer freebsd_triage 2023-05-21 03:18:43 UTC
Kinda similar to https://github.com/mesonbuild/meson/issues/11237#issuecomment-1399338829