Hi, Can you look into what options we have since we're moving to FFmpeg 6.0? I found a few refences but having a quick look at the repo it doesn't seem to be backported to 20.x? References: https://github.com/xbmc/xbmc/issues/21766 https://github.com/xbmc/xbmc/pull/21248 https://github.com/xbmc/xbmc/pull/22899 Best regards, Daniel
I'm not authoritative on this but from what I have read in the mentioned PR upstream kodi is always only targeting one ffmpeg release per Kodi major version. For Kodi 20/Nexus this is ffmpeg 4.4.1. They also mention that Kodi brings his own internal ffmpeg 4.4.1 as a fallback if their cmake does not find a matching system ffmpeg but I don't know if that is useable on FreeBSD. It is also unclear to me if updating ffmpeg could have any side effects on kodi plugins or not.
The support is being worked on: https://github.com/xbmc/xbmc/pull/22967, and looks like it does work in its current form. API changes seem minimal, I should be able to backport it for Kodi 20. If you can point me to a ports tree with FFmpeg 6.0 to test against?
(In reply to Bernhard Froehlich from comment #1) The fallback system involves downloading a source tarball during build time. You can already tell why it won't work...
There's a patch in the referenced bug report (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261302) bumping multimedia/ffmpeg to 6.0 Best regards, Daniel
Created attachment 240886 [details] Patch from upstream
Created attachment 240887 [details] testport log (bzip2)
(In reply to yzrh from comment #5) Builds with no error. Ready for multimedia/kodi/files, something like multimedia/kodi/files/patch-ffmpeg. As I said, it is a work in progress. I will fix any bug discovered later. Many thanks!
Created attachment 240906 [details] Patch from upstream (fix DVD playback) Includes an important fix from upstream. Backport for 20.x.
Created attachment 240907 [details] testport log (bzip2, r1)
Can it be committed as soon as FFmpeg 6.0 lands?
Thanks for looking into it and sure, we'll arrange that.
Created attachment 241584 [details] Patch from upstream (merged)
Created attachment 241585 [details] testport log (bzip2, r2)
This is the final revision for backport, upstream merged ffmpeg 6 support.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=915391ac40ad0175583f572d999680f5ae8397bc commit 915391ac40ad0175583f572d999680f5ae8397bc Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2023-04-27 10:43:32 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2023-04-27 12:01:44 +0000 multimedia/kodi: Add patch to support FFmpeg 6 Add patch from maintainer PR: 270237 Reviewed by: yrzh <yzrh@noema.org> (maintainer) multimedia/kodi/files/patch-ffmpeg6-support (new) | 2150 +++++++++++++++++++++ 1 file changed, 2150 insertions(+)
Committed, thanks
Created attachment 242768 [details] Kodi 20 with ffmpeg 6 log - dolby transcoding broken
Audio passthrough with Dolby Digital is not working for me with kodi 20 / ffmpeg 6. I'm getting no audio when passthrough is enabled and configured correctly. Attached my kodi.log file. How about using existing port ffmpeg4 (currently at 4.4.4) with kodi instead of current ffmpeg port which is now at 6? I'm using recommended settings for my set up as stated on https://kodi.wiki/view/Audio_quickstart_guide. I've set output device to my HDMI device, set "Number of Channels" to 2, disabled "Stereo upmix", enabled "Dolby Digital (AC3) capable receiver" and "Enable Dolby Digital transcoding". The same settings worked great for me with Kodi 18 / ffmpeg 4.3 and exact same hardware and setup. If I unset "Enable Dolby Digital transcoding" I get audio from front speakers, but no surround sound.
Thanks for the bug report. I should be able to fix the encoding, I will open a new bug for that.