Bug 270255 - multimedia/gstreamer1-libav: Update to 1.22.1
Summary: multimedia/gstreamer1-libav: Update to 1.22.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL: https://gitlab.freedesktop.org/gstrea...
Keywords:
Depends on:
Blocks: 261302
  Show dependency treegraph
 
Reported: 2023-03-15 21:19 UTC by Daniel Engberg
Modified: 2023-04-15 19:15 UTC (History)
3 users (show)

See Also:


Attachments
Patch for gstreamer1-libav (1.86 KB, patch)
2023-03-15 21:19 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-03-15 21:19:51 UTC
Created attachment 240881 [details]
Patch for gstreamer1-libav

Fixes build with FFmpeg 6.0

Compile tested on FreeBSD 13.2-BETA1 (amd64)
Poudriere testport OK 12.3-RELEASE (amd64)

Tested with following users in Poudriere:
audio/amberol
audio/gnome-podcasts
audio/lollypop
audio/mpz
audio/pragha
audio/sayonara
audio/shortwave
audio/tuner
multimedia/clapper
multimedia/elementary-videos
multimedia/gstreamer1-plugins-all
multimedia/handbrake
multimedia/video-trimmer
www/badwolf
Comment 1 Jan Beich freebsd_committer freebsd_triage 2023-03-15 21:41:50 UTC
gstreamer1-libav version should probably be in sync with gstreamer1-plugins as it doesn't have independent releases. Missed in bug 269895.

https://gitlab.freedesktop.org/gstreamer/gst-libav/-/tags has no new tags for >1 year due to https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/474
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-03-15 22:17:26 UTC
I asked arrowd about that actually on irc and he said it looked fine but feel free to test it with 1.22.0. It takes my box half a day with all deps and whatnot and I have days of building queued up.

There are only a few bugfixes committed to gst-libav so it shouldn't matter as far as I can tell.
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commits/1.22.1/subprojects/gst-libav
Comment 3 Jan Beich freebsd_committer freebsd_triage 2023-03-18 14:09:10 UTC
Looks OK. Changes between 1.22.0 and 1.22.1 appear ABI-safe. 1.22.1 runtime works against ffmpeg 4.*, tested via shortwave and clapper. Also builds fine on 12.3 i386.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-03-20 16:59:32 UTC
Thanks, I guess we can push this. Can multimedia@ approve?
Comment 5 George Mitchell 2023-03-28 19:55:55 UTC
Patch as it stands does not apply cleanly to the head-of-tree Makefile: it now contains the line "MESON_ARGS=     -Ddoc=disabled" which wasn't there at the time your patch was created.  But with that change and your patch applied, I can compile with ffmpeg6.  Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-04-15 19:14:30 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ebf585f64335d443b68d20d93c7c3fdf186b9e31

commit ebf585f64335d443b68d20d93c7c3fdf186b9e31
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-04-15 18:58:41 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-04-15 19:13:24 +0000

    multimedia/gstreamer1-libav: Update to 1.22.1

    Fixes build with FFmpeg 6.0

    Changelog: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/1.22.1/subprojects/gst-libav/NEWS

    PR:             270255
    Reviewed by:    arrowd
    Tested by:      jbeich, George Mitchell <george@m5p.com>
    Approved by:    portmgr (maintainer timeout, 1 month)

 multimedia/gstreamer1-libav/Makefile | 13 +++++++------
 multimedia/gstreamer1-libav/distinfo |  6 +++---
 2 files changed, 10 insertions(+), 9 deletions(-)
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2023-04-15 19:15:29 UTC
Committed, thanks everyone involved